Page MenuHomePhabricator

[AMDGPU] Switched HSA metadata to use MsgPackDocument
AcceptedPublic

Authored by tpr on Jan 21 2019, 9:35 AM.

Details

Summary

MsgPackDocument is the lighter-weight replacement for MsgPackTypes. This
commit switches AMDGPU HSA metadata processing to use MsgPackDocument
instead of MsgPackTypes.

Change-Id: I0751668013abe8c87db01db1170831a76079b3a6

Diff Detail

Event Timeline

tpr created this revision.Jan 21 2019, 9:35 AM

Thank you for updating this! I only have one small suggestion, but otherwise it LGTM.

lib/Target/AMDGPU/AMDGPUHSAMetadataStreamer.h
55

Small nit, but could this be llvm::make_unique<msgpack::Document>()?

Herald added a project: Restricted Project. · View Herald TranscriptFri, Feb 1, 11:50 AM
tpr updated this revision to Diff 185082.Mon, Feb 4, 10:12 AM

V2: Addressed review comment.

This revision is now accepted and ready to land.Mon, Feb 4, 11:54 AM