Page MenuHomePhabricator

[AMDGPU][MC] Disabled use of 2 different literals with SOP2/SOPC instructions
ClosedPublic

Authored by dp on Jan 17 2019, 4:50 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

dp created this revision.Jan 17 2019, 4:50 AM

Do we support different constants if one is literal and another one is inline constant?

s_and_b32 s2, 2, 1234

AFAIR gpu supports arbitrary number of inline constants.

artem.tamazov accepted this revision.Jan 17 2019, 5:07 AM

This patch LGTM

This revision is now accepted and ready to land.Jan 17 2019, 5:07 AM
dp added a comment.Jan 17 2019, 5:38 AM

Do we support different constants if one is literal and another one is inline constant?

Sure. Inline constants are free. The code in this patch only limits use of literals.

This revision was automatically updated to reflect the committed changes.