Page MenuHomePhabricator

[MSP430] Add msp430 toochain
ClosedPublic

Authored by krisb on Jan 14 2019, 4:29 AM.

Details

Summary

This is an initial implementation for msp430 toolchain including

  • -mmcu option support
  • -mhwmult options support
  • -integrated-as by default
  • msp430-elf-as as a linker

Diff Detail

Repository
rL LLVM

Event Timeline

krisb created this revision.Jan 14 2019, 4:29 AM
krisb added a reviewer: asl.Jan 14 2019, 4:30 AM
krisb edited the summary of this revision. (Show Details)
asl accepted this revision.Jan 15 2019, 11:44 AM
This revision is now accepted and ready to land.Jan 15 2019, 11:44 AM
This revision was automatically updated to reflect the committed changes.
nathanchance added inline comments.
cfe/trunk/lib/CodeGen/CodeGenModule.cpp
141

I'm just curious, was committing this change intentional? Seems like something for debugging purposes, rather than a useful diagnostic, since it doesn't appear to be related to the rest of the patch (as far as I can tell).

I see it quite a bit on a Linux kernel build: https://gist.github.com/nathanchance/0b2d3b199996d5b30396038d86f5cba3

asl added inline comments.Jan 15 2019, 1:26 PM
cfe/trunk/lib/CodeGen/CodeGenModule.cpp
141

Oh... Sorry, maybe unclean tree or something like this. Will fix!

nathanchance marked an inline comment as done.Jan 15 2019, 1:30 PM
nathanchance added inline comments.
cfe/trunk/lib/CodeGen/CodeGenModule.cpp
141

Thanks for the quick reply, looks like Peter Collingbourne beat you to it :) https://reviews.llvm.org/rC351241

asl added inline comments.Jan 15 2019, 1:32 PM
cfe/trunk/lib/CodeGen/CodeGenModule.cpp
141

Pete already fixed this in r351241.