Page MenuHomePhabricator

krisb (Kristina Bessonova)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 1 2018, 11:54 PM (166 w, 5 d)

Recent Activity

Tue, Apr 13

krisb added inline comments to D100029: [libcxx][test] Properly construct containers in debug mode tests for map/set.
Tue, Apr 13, 12:42 AM · Restricted Project

Mon, Apr 12

krisb added inline comments to D100029: [libcxx][test] Properly construct containers in debug mode tests for map/set.
Mon, Apr 12, 2:23 AM · Restricted Project

Fri, Apr 9

krisb added a comment to D100029: [libcxx][test] Properly construct containers in debug mode tests for map/set.

@curdeius thank you for looking at this!

Fri, Apr 9, 12:31 AM · Restricted Project
krisb updated the diff for D100029: [libcxx][test] Properly construct containers in debug mode tests for map/set.

Simplify the changes a bit.

Fri, Apr 9, 12:28 AM · Restricted Project

Thu, Apr 8

krisb updated the diff for D100029: [libcxx][test] Properly construct containers in debug mode tests for map/set.

Address @curdeius' comments.

Thu, Apr 8, 11:19 PM · Restricted Project
krisb added a comment to D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations).

Do we still need the following tests:

  • clang/test/CXX/temp/temp.spec/temp.explicit/p11.cpp
  • clang/test/CXX/temp/temp.spec/temp.explicit/p12.cpp

?

Thu, Apr 8, 2:09 PM · Restricted Project, Restricted Project
krisb updated the diff for D100029: [libcxx][test] Properly construct containers in debug mode tests for map/set.

Make it compiled with c++03.

Thu, Apr 8, 5:18 AM · Restricted Project

Wed, Apr 7

krisb requested review of D100029: [libcxx][test] Properly construct containers in debug mode tests for map/set.
Wed, Apr 7, 3:30 AM · Restricted Project
krisb added inline comments to D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations).
Wed, Apr 7, 2:46 AM · Restricted Project, Restricted Project

Tue, Mar 23

krisb accepted D98687: Fix demangling of optional template-args for vendor extended type qualifier..

LGTM, thank you!

Tue, Mar 23, 3:17 PM · Restricted Project, Restricted Project
krisb added a comment to D98687: Fix demangling of optional template-args for vendor extended type qualifier..

It seems it makes sense to apply the same changes to libcxxabi (see, libcxxabi/src/demangle/ItaniumDemangle.h) to keep them in sync.

Tue, Mar 23, 1:31 AM · Restricted Project, Restricted Project

Feb 21 2021

krisb committed rGe97aab8d1510: [ThinLTO] Fix import of multiply defined global variables (authored by krisb).
[ThinLTO] Fix import of multiply defined global variables
Feb 21 2021, 8:43 AM
krisb closed D95943: [ThinLTO] Fix import of multiply defined global variables.
Feb 21 2021, 8:43 AM · Restricted Project

Feb 16 2021

krisb added inline comments to D95943: [ThinLTO] Fix import of multiply defined global variables.
Feb 16 2021, 5:47 AM · Restricted Project
krisb updated the diff for D95943: [ThinLTO] Fix import of multiply defined global variables.

Applied review comments, reduced the test.

Feb 16 2021, 5:47 AM · Restricted Project

Feb 15 2021

krisb updated the diff for D95943: [ThinLTO] Fix import of multiply defined global variables.

Made comments more detailed and acccurate.

Feb 15 2021, 1:24 AM · Restricted Project

Feb 13 2021

krisb committed rGf042fd46b527: [libunwind][cmake] Add an option to enable/disable tests (authored by krisb).
[libunwind][cmake] Add an option to enable/disable tests
Feb 13 2021, 2:52 AM
krisb closed D96342: [libunwind][cmake] Add an option to enable/disable tests.
Feb 13 2021, 2:52 AM · Restricted Project, Restricted Project

Feb 9 2021

krisb requested review of D96342: [libunwind][cmake] Add an option to enable/disable tests.
Feb 9 2021, 7:32 AM · Restricted Project, Restricted Project

Feb 8 2021

krisb added a comment to D95943: [ThinLTO] Fix import of multiply defined global variables.

Thanks, @tejohnson, for reviewing this!
I'll make the comment more accurate.

Feb 8 2021, 5:01 AM · Restricted Project

Feb 4 2021

krisb updated the diff for D95943: [ThinLTO] Fix import of multiply defined global variables.

Add the comment and FIXME.

Feb 4 2021, 8:18 AM · Restricted Project

Feb 3 2021

krisb requested review of D95943: [ThinLTO] Fix import of multiply defined global variables.
Feb 3 2021, 5:13 AM · Restricted Project

Sep 7 2020

krisb committed rG04ea680a8ccc: [cmake] Fix build of attribute plugin example on Windows (authored by krisb).
[cmake] Fix build of attribute plugin example on Windows
Sep 7 2020, 1:05 AM
krisb closed D86091: [cmake] Fix build of attribute plugin example on Windows.
Sep 7 2020, 1:05 AM · Restricted Project

Aug 17 2020

krisb requested review of D86091: [cmake] Fix build of attribute plugin example on Windows.
Aug 17 2020, 9:57 AM · Restricted Project

Jul 28 2020

krisb committed rGad4ab81dccaa: [clang][cmake] Force CMAKE_LINKER for multistage build in case of… (authored by krisb).
[clang][cmake] Force CMAKE_LINKER for multistage build in case of…
Jul 28 2020, 1:13 AM
krisb closed D80873: [clang][cmake] Force CMAKE_LINKER for multistage build in case of BOOTSTRAP_LLVM_ENABLE_LLD and MSVC.
Jul 28 2020, 1:13 AM · Restricted Project, Restricted Project

Jul 27 2020

krisb added a comment to D80873: [clang][cmake] Force CMAKE_LINKER for multistage build in case of BOOTSTRAP_LLVM_ENABLE_LLD and MSVC.

@phosek thank you for reviewing this!

Jul 27 2020, 3:32 AM · Restricted Project, Restricted Project
krisb updated the diff for D80873: [clang][cmake] Force CMAKE_LINKER for multistage build in case of BOOTSTRAP_LLVM_ENABLE_LLD and MSVC.

Addressed the review comment.

Jul 27 2020, 3:10 AM · Restricted Project, Restricted Project

Jul 21 2020

krisb added a comment to D80873: [clang][cmake] Force CMAKE_LINKER for multistage build in case of BOOTSTRAP_LLVM_ENABLE_LLD and MSVC.

Ping

Jul 21 2020, 10:43 AM · Restricted Project, Restricted Project

Jul 14 2020

krisb accepted D81676: [MSP430] Align the toolchain definition with the TI's msp430-gcc v9.2.0.

Sorry for the delays in response, busy days.
LGTM, thanks!

Jul 14 2020, 7:10 AM · Restricted Project
krisb added inline comments to D80873: [clang][cmake] Force CMAKE_LINKER for multistage build in case of BOOTSTRAP_LLVM_ENABLE_LLD and MSVC.
Jul 14 2020, 6:48 AM · Restricted Project, Restricted Project
krisb updated the diff for D80873: [clang][cmake] Force CMAKE_LINKER for multistage build in case of BOOTSTRAP_LLVM_ENABLE_LLD and MSVC.

Changed MSVC -> WIN32 check and simplified the warning fix.

Jul 14 2020, 6:13 AM · Restricted Project, Restricted Project

Jul 7 2020

krisb added reviewers for D80873: [clang][cmake] Force CMAKE_LINKER for multistage build in case of BOOTSTRAP_LLVM_ENABLE_LLD and MSVC: ikudrin, vvereschaka.
Jul 7 2020, 5:41 AM · Restricted Project, Restricted Project

Jul 6 2020

krisb added a comment to D81676: [MSP430] Align the toolchain definition with the TI's msp430-gcc v9.2.0.

Thank you!
LGTM, except some minor nits below.

Jul 6 2020, 2:46 AM · Restricted Project

Jun 22 2020

krisb added inline comments to D81676: [MSP430] Align the toolchain definition with the TI's msp430-gcc v9.2.0.
Jun 22 2020, 4:16 AM · Restricted Project

Jun 20 2020

krisb committed rGcd058033b900: [CMake] Fix runtimes build for host Windows (default target) (authored by krisb).
[CMake] Fix runtimes build for host Windows (default target)
Jun 20 2020, 2:05 AM
krisb closed D81877: [CMake] Fix runtimes build for host Windows (default target).
Jun 20 2020, 2:05 AM · Restricted Project
krisb abandoned D80866: [cmake] Allow llvm_ExternalProject_Add to find CMAKE_SYSTEM_NAME among ${proj}_CMAKE_ARGS.
Jun 20 2020, 2:05 AM · Restricted Project
krisb added a comment to D81877: [CMake] Fix runtimes build for host Windows (default target).

@plotfi @compnerd @phosek Thank you all for reviewing this!

Jun 20 2020, 2:05 AM · Restricted Project

Jun 17 2020

krisb added a comment to D80873: [clang][cmake] Force CMAKE_LINKER for multistage build in case of BOOTSTRAP_LLVM_ENABLE_LLD and MSVC.

Ping

Jun 17 2020, 12:56 PM · Restricted Project, Restricted Project

Jun 15 2020

krisb added a comment to D80866: [cmake] Allow llvm_ExternalProject_Add to find CMAKE_SYSTEM_NAME among ${proj}_CMAKE_ARGS.

@plotfi @compnerd
I created another review with an alternative solution at D81877. I'll appreciate if you have a chance to look at it. Thank you.

Jun 15 2020, 2:20 PM · Restricted Project
krisb created D81877: [CMake] Fix runtimes build for host Windows (default target).
Jun 15 2020, 1:51 PM · Restricted Project
krisb committed rG5a39bf2dc5ae: [CMake][runtimes] Skip adding 2nd set of the same variables for a generic target (authored by krisb).
[CMake][runtimes] Skip adding 2nd set of the same variables for a generic target
Jun 15 2020, 1:04 AM
krisb closed D81574: [CMake][runtimes] Skip adding 2nd set of the same variables for a generic target.
Jun 15 2020, 1:03 AM · Restricted Project

Jun 10 2020

krisb created D81574: [CMake][runtimes] Skip adding 2nd set of the same variables for a generic target.
Jun 10 2020, 7:37 AM · Restricted Project

Jun 9 2020

krisb added a comment to D80866: [cmake] Allow llvm_ExternalProject_Add to find CMAKE_SYSTEM_NAME among ${proj}_CMAKE_ARGS.

@compnerd @plotfi thank you for the comments! Sorry if the description looks confusing. I'll try to be more clear.
I'm trying to build something like

Jun 9 2020, 4:54 AM · Restricted Project

Jun 8 2020

krisb added a comment to D80866: [cmake] Allow llvm_ExternalProject_Add to find CMAKE_SYSTEM_NAME among ${proj}_CMAKE_ARGS.

Ping

Jun 8 2020, 1:02 AM · Restricted Project

May 30 2020

krisb created D80873: [clang][cmake] Force CMAKE_LINKER for multistage build in case of BOOTSTRAP_LLVM_ENABLE_LLD and MSVC.
May 30 2020, 11:39 AM · Restricted Project, Restricted Project
krisb created D80866: [cmake] Allow llvm_ExternalProject_Add to find CMAKE_SYSTEM_NAME among ${proj}_CMAKE_ARGS.
May 30 2020, 5:48 AM · Restricted Project

Jan 28 2020

krisb committed rG5499e2f455ca: [llvm-dwarfdump][Statistics] Distinguish parameters with same name or w/o a name (authored by krisb).
[llvm-dwarfdump][Statistics] Distinguish parameters with same name or w/o a name
Jan 28 2020, 10:59 AM
krisb committed rG4b0a7fe008e6: [llvm-dwarfdump][Statistics] Make calculations of vars in global scope more… (authored by krisb).
[llvm-dwarfdump][Statistics] Make calculations of vars in global scope more…
Jan 28 2020, 10:59 AM
krisb committed rG57839e517815: [llvm-dwarfdump][Statistics] Count more than one conrete out-of-line instances… (authored by krisb).
[llvm-dwarfdump][Statistics] Count more than one conrete out-of-line instances…
Jan 28 2020, 10:59 AM
krisb closed D73004: llvm-dwarfdump][Statistics] Make calculations of vars in global scope more accurate.
Jan 28 2020, 10:58 AM · Restricted Project, debug-info
krisb closed D73002: [llvm-dwarfdump][Statistics] Count more than one concrete out-of-line instance of a function.
Jan 28 2020, 10:58 AM · Restricted Project, debug-info
krisb closed D73003: [llvm-dwarfdump][Statistics] Distinguish parameters with same name or w/o a name.
Jan 28 2020, 10:58 AM · Restricted Project, debug-info
krisb committed rG2e5d20bd4788: [llvm-dwarfdump][Statistics] Ignore declarations of global variables (authored by krisb).
[llvm-dwarfdump][Statistics] Ignore declarations of global variables
Jan 28 2020, 9:52 AM
krisb closed D73001: [llvm-dwarfdump][Statistics] Ignore declarations of global variables.
Jan 28 2020, 9:52 AM · Restricted Project, debug-info
krisb committed rGe76106e01c4b: [llvm-dwarfdump][Statistics] Ignore DW_TAG_subroutine_type in statistics (authored by krisb).
[llvm-dwarfdump][Statistics] Ignore DW_TAG_subroutine_type in statistics
Jan 28 2020, 9:52 AM
krisb closed D72983: [llvm-dwarfdump][Statistics] Ignore DW_TAG_subroutine_type in statistics.
Jan 28 2020, 9:51 AM · Restricted Project, debug-info
krisb committed rG9806b39dae18: [llvm-dwarfdump][Statistics] Distinguish functions/variables with same name… (authored by krisb).
[llvm-dwarfdump][Statistics] Distinguish functions/variables with same name…
Jan 28 2020, 9:51 AM
krisb closed D72797: [llvm-dwarfdump][Statistics] Distinguish functions/variables with same name across different CUs.
Jan 28 2020, 9:51 AM · debug-info, Restricted Project
krisb added a comment to D72797: [llvm-dwarfdump][Statistics] Distinguish functions/variables with same name across different CUs.

@djtodoro @aprantl thanks for reviewing this whole set of patches!

Jan 28 2020, 6:31 AM · debug-info, Restricted Project

Jan 24 2020

krisb added a comment to D73002: [llvm-dwarfdump][Statistics] Count more than one concrete out-of-line instance of a function.

@aprantl thanks for the review! Are you okay with this test?

Jan 24 2020, 10:13 AM · Restricted Project, debug-info

Jan 22 2020

krisb added inline comments to D73004: llvm-dwarfdump][Statistics] Make calculations of vars in global scope more accurate.
Jan 22 2020, 11:37 AM · Restricted Project, debug-info
krisb updated the diff for D73004: llvm-dwarfdump][Statistics] Make calculations of vars in global scope more accurate.

Refactor checks for constant members a bit.

Jan 22 2020, 11:37 AM · Restricted Project, debug-info
krisb updated the diff for D73002: [llvm-dwarfdump][Statistics] Count more than one concrete out-of-line instance of a function.

Added a test.

Jan 22 2020, 11:19 AM · Restricted Project, debug-info
krisb added a comment to D73001: [llvm-dwarfdump][Statistics] Ignore declarations of global variables.

@djtodoro thanks! Are you okay with this test case?

Jan 22 2020, 10:42 AM · Restricted Project, debug-info
krisb updated the diff for D73001: [llvm-dwarfdump][Statistics] Ignore declarations of global variables.

Add a test.

Jan 22 2020, 10:42 AM · Restricted Project, debug-info
krisb added a comment to D72797: [llvm-dwarfdump][Statistics] Distinguish functions/variables with same name across different CUs.

@djtodoro those two binaries with 99% of availability just have some variables w/o locations (mostly artificial 'this' parameters of member functions).
But this change reveals one more interesting case.
For code like this:

int foo() {
	if (cond1) {
		static const int a = 1;
		...
	}
	if (cond2) {
		static const int a = 1;
		...
	}
}

clang (unlike gcc) generates both a variables in the function scope, not in a corresponded DW_TAG_lexical_block (as gcc does).
I'm not sure clang is right here, cause a - despite it is static - isn't visible outside the if.
What do you think about this?

Jan 22 2020, 8:22 AM · debug-info, Restricted Project
krisb updated the diff for D72797: [llvm-dwarfdump][Statistics] Distinguish functions/variables with same name across different CUs.

Use declaration info only to identify functions, global variables, and members.

Jan 22 2020, 8:12 AM · debug-info, Restricted Project

Jan 20 2020

krisb added a comment to D72797: [llvm-dwarfdump][Statistics] Distinguish functions/variables with same name across different CUs.

So, this increases number of 'total vars' because these 'a' and 'b' variables counted twice.

I see... Can we do something to avoid the additional calculation? Somehow to recognize we already observed the a and b, although they have different DIE ID.

I also was a bit optimistic about how this patch(es) affects the performance of the statistics, it actually became two times slower than before the patches.

What patch from the stack adds the overhead? This one?

Yeah, this one mostly causes the overhead.
Actually, adding declaration info for ID is only necessary for functions, global variables, and members (because we need to handle static/inline functions/variables, and don't respect namespaces, classes, and structures). For local variables and parameters, Prefix + Name should be enough to distinguish all the cases (because their prefix already guaranteed uniqueness, for parameters the prefix is going to be added in D73003).
This approach shows better results:

Jan 20 2020, 8:13 AM · debug-info, Restricted Project

Jan 19 2020

krisb created D73004: llvm-dwarfdump][Statistics] Make calculations of vars in global scope more accurate.
Jan 19 2020, 8:59 AM · Restricted Project, debug-info
krisb created D73003: [llvm-dwarfdump][Statistics] Distinguish parameters with same name or w/o a name.
Jan 19 2020, 8:13 AM · Restricted Project, debug-info
krisb created D73002: [llvm-dwarfdump][Statistics] Count more than one concrete out-of-line instance of a function.
Jan 19 2020, 8:03 AM · Restricted Project, debug-info
krisb created D73001: [llvm-dwarfdump][Statistics] Ignore declarations of global variables.
Jan 19 2020, 7:08 AM · Restricted Project, debug-info

Jan 18 2020

krisb created D72983: [llvm-dwarfdump][Statistics] Ignore DW_TAG_subroutine_type in statistics.
Jan 18 2020, 12:53 PM · Restricted Project, debug-info
krisb added a comment to D72797: [llvm-dwarfdump][Statistics] Distinguish functions/variables with same name across different CUs.

@aprantl @djtodoro thanks for the comments!

Jan 18 2020, 10:13 AM · debug-info, Restricted Project
krisb updated the summary of D72797: [llvm-dwarfdump][Statistics] Distinguish functions/variables with same name across different CUs.
Jan 18 2020, 10:13 AM · debug-info, Restricted Project
krisb updated the diff for D72797: [llvm-dwarfdump][Statistics] Distinguish functions/variables with same name across different CUs.

Applied the comments.

Jan 18 2020, 10:07 AM · debug-info, Restricted Project

Jan 15 2020

krisb created D72797: [llvm-dwarfdump][Statistics] Distinguish functions/variables with same name across different CUs.
Jan 15 2020, 12:05 PM · debug-info, Restricted Project

Dec 26 2019

krisb committed rGcdd25a4c7410: [DebugInfo][SelectionDAG] Change order while transferring SDDbgValue to another… (authored by krisb).
[DebugInfo][SelectionDAG] Change order while transferring SDDbgValue to another…
Dec 26 2019, 10:06 AM
krisb closed D71175: [DebugInfo][SelectionDAG] Change order while transferring SDDbgValue to another node.
Dec 26 2019, 10:06 AM · debug-info, Restricted Project
krisb added a comment to D71175: [DebugInfo][SelectionDAG] Change order while transferring SDDbgValue to another node.

Yeah, the rest of the code around SelectionDAG doesn't do a good job of keeping location intrinsics in order; I think it's acceptable to suffer a little bit more re-ordering here for an increase in available locations, for now.

Okay, I'll commit the patch as is, then. This issue with 'IROrder' in SelectionDAG is quite tricky, so I'll submit further changes in separate patches.

Dec 26 2019, 9:28 AM · debug-info, Restricted Project
krisb updated the diff for D71175: [DebugInfo][SelectionDAG] Change order while transferring SDDbgValue to another node.

Rebased and reduced the test a bit more.

Dec 26 2019, 8:51 AM · debug-info, Restricted Project

Dec 13 2019

krisb added a comment to D71070: [llvm-dwarfdump][Statistics] Don't count coverage less than 1% as 0%.

@spatel thanks for reporting this!
Could you, please, check that llvm-locstat wasn't cached in the build/install directory? llvm-locstat should look for a variables with (0%,10%) of its scope covered as was changed by the patch, so I guess it didn't get updated for some reason.

Dec 13 2019, 7:56 AM · debug-info, Restricted Project
krisb committed rGd5655c4d2e18: [llvm-dwarfdump][Statistics] Don't count coverage less than 1% as 0% (authored by krisb).
[llvm-dwarfdump][Statistics] Don't count coverage less than 1% as 0%
Dec 13 2019, 6:44 AM
krisb closed D71070: [llvm-dwarfdump][Statistics] Don't count coverage less than 1% as 0%.
Dec 13 2019, 6:44 AM · debug-info, Restricted Project
krisb committed rG1cc4b603ba79: [llvm-dwarfdump][Statistics] Change the coverage buckets representation. NFC (authored by krisb).
[llvm-dwarfdump][Statistics] Change the coverage buckets representation. NFC
Dec 13 2019, 5:13 AM
krisb closed D71366: [llvm-dwarfdump][Statistics] Change the coverage buckets representation. NFC.
Dec 13 2019, 5:12 AM · debug-info, Restricted Project

Dec 12 2019

krisb updated the summary of D71070: [llvm-dwarfdump][Statistics] Don't count coverage less than 1% as 0%.
Dec 12 2019, 4:06 AM · debug-info, Restricted Project
krisb updated the diff for D71070: [llvm-dwarfdump][Statistics] Don't count coverage less than 1% as 0%.

Updated the doc, rebased on D71366.

Dec 12 2019, 3:59 AM · debug-info, Restricted Project
krisb updated the diff for D71366: [llvm-dwarfdump][Statistics] Change the coverage buckets representation. NFC.

Fixed one more misprint.

Dec 12 2019, 1:12 AM · debug-info, Restricted Project

Dec 11 2019

krisb updated the diff for D71366: [llvm-dwarfdump][Statistics] Change the coverage buckets representation. NFC.

Fixed a misprint in llvm/docs/CommandGuide/llvm-locstats.rst.

Dec 11 2019, 11:48 PM · debug-info, Restricted Project
krisb added a comment to D71366: [llvm-dwarfdump][Statistics] Change the coverage buckets representation. NFC.

@djtodoro , Ah, missed this one. Thank you so much!

Dec 11 2019, 11:48 PM · debug-info, Restricted Project
krisb added a comment to D71070: [llvm-dwarfdump][Statistics] Don't count coverage less than 1% as 0%.

@djtodoro , @dblaikie thanks for your opinions! I created a separate review for this change https://reviews.llvm.org/D71366. Please, take a look if you have a chance.

Dec 11 2019, 10:39 AM · debug-info, Restricted Project
krisb updated the diff for D71366: [llvm-dwarfdump][Statistics] Change the coverage buckets representation. NFC.

Fix indentation in llvm-locstats output.

Dec 11 2019, 10:32 AM · debug-info, Restricted Project
krisb created D71366: [llvm-dwarfdump][Statistics] Change the coverage buckets representation. NFC.
Dec 11 2019, 10:20 AM · debug-info, Restricted Project
krisb added a comment to D71175: [DebugInfo][SelectionDAG] Change order while transferring SDDbgValue to another node.

@aprantl, @djtodoro thanks! I reduced the test a bit more.

Dec 11 2019, 8:49 AM · debug-info, Restricted Project
krisb updated the diff for D71175: [DebugInfo][SelectionDAG] Change order while transferring SDDbgValue to another node.

Reduced the test.

Dec 11 2019, 8:46 AM · debug-info, Restricted Project