User Details
- User Since
- Feb 1 2018, 11:54 PM (166 w, 5 d)
Tue, Apr 13
Mon, Apr 12
Fri, Apr 9
@curdeius thank you for looking at this!
Simplify the changes a bit.
Thu, Apr 8
Address @curdeius' comments.
Do we still need the following tests:
- clang/test/CXX/temp/temp.spec/temp.explicit/p11.cpp
- clang/test/CXX/temp/temp.spec/temp.explicit/p12.cpp
?
Make it compiled with c++03.
Wed, Apr 7
Tue, Mar 23
LGTM, thank you!
It seems it makes sense to apply the same changes to libcxxabi (see, libcxxabi/src/demangle/ItaniumDemangle.h) to keep them in sync.
Feb 21 2021
Feb 16 2021
Applied review comments, reduced the test.
Feb 15 2021
Made comments more detailed and acccurate.
Feb 13 2021
Feb 9 2021
Feb 8 2021
Thanks, @tejohnson, for reviewing this!
I'll make the comment more accurate.
Feb 4 2021
Add the comment and FIXME.
Feb 3 2021
Sep 7 2020
Aug 17 2020
Jul 28 2020
Jul 27 2020
@phosek thank you for reviewing this!
Addressed the review comment.
Jul 21 2020
Ping
Jul 14 2020
Sorry for the delays in response, busy days.
LGTM, thanks!
Changed MSVC -> WIN32 check and simplified the warning fix.
Jul 7 2020
Jul 6 2020
Thank you!
LGTM, except some minor nits below.
Jun 22 2020
Jun 20 2020
Jun 17 2020
Ping
Jun 15 2020
@plotfi @compnerd
I created another review with an alternative solution at D81877. I'll appreciate if you have a chance to look at it. Thank you.
Jun 10 2020
Jun 9 2020
@compnerd @plotfi thank you for the comments! Sorry if the description looks confusing. I'll try to be more clear.
I'm trying to build something like
Jun 8 2020
Ping
May 30 2020
Jan 28 2020
Jan 24 2020
@aprantl thanks for the review! Are you okay with this test?
Jan 22 2020
Refactor checks for constant members a bit.
Added a test.
@djtodoro thanks! Are you okay with this test case?
Add a test.
@djtodoro those two binaries with 99% of availability just have some variables w/o locations (mostly artificial 'this' parameters of member functions).
But this change reveals one more interesting case.
For code like this:
int foo() { if (cond1) { static const int a = 1; ... } if (cond2) { static const int a = 1; ... } }
clang (unlike gcc) generates both a variables in the function scope, not in a corresponded DW_TAG_lexical_block (as gcc does).
I'm not sure clang is right here, cause a - despite it is static - isn't visible outside the if.
What do you think about this?
Use declaration info only to identify functions, global variables, and members.
Jan 20 2020
Yeah, this one mostly causes the overhead.
Actually, adding declaration info for ID is only necessary for functions, global variables, and members (because we need to handle static/inline functions/variables, and don't respect namespaces, classes, and structures). For local variables and parameters, Prefix + Name should be enough to distinguish all the cases (because their prefix already guaranteed uniqueness, for parameters the prefix is going to be added in D73003).
This approach shows better results:
Jan 19 2020
Jan 18 2020
Applied the comments.
Jan 15 2020
Dec 26 2019
Yeah, the rest of the code around SelectionDAG doesn't do a good job of keeping location intrinsics in order; I think it's acceptable to suffer a little bit more re-ordering here for an increase in available locations, for now.
Okay, I'll commit the patch as is, then. This issue with 'IROrder' in SelectionDAG is quite tricky, so I'll submit further changes in separate patches.
Rebased and reduced the test a bit more.
Dec 13 2019
@spatel thanks for reporting this!
Could you, please, check that llvm-locstat wasn't cached in the build/install directory? llvm-locstat should look for a variables with (0%,10%) of its scope covered as was changed by the patch, so I guess it didn't get updated for some reason.
Dec 12 2019
Updated the doc, rebased on D71366.
Fixed one more misprint.
Dec 11 2019
Fixed a misprint in llvm/docs/CommandGuide/llvm-locstats.rst.
@djtodoro , Ah, missed this one. Thank you so much!
@djtodoro , @dblaikie thanks for your opinions! I created a separate review for this change https://reviews.llvm.org/D71366. Please, take a look if you have a chance.
Fix indentation in llvm-locstats output.
Reduced the test.