Page MenuHomePhabricator

[CMake][Fuchsia] Synchronize first and second stage builds
ClosedPublic

Authored by phosek on Jan 13 2019, 3:15 PM.

Details

Summary

This reorders options between the first and second stage builds to make
them better lined up. The change also re-enables tests for first stage
which is useful e.g. for cross-compiling when we cannot run tests for
second stage directly (i.e. without emulation).

Diff Detail

Repository
rL LLVM

Event Timeline

phosek created this revision.Jan 13 2019, 3:15 PM
This revision is now accepted and ready to land.Jan 14 2019, 12:53 PM
This revision was automatically updated to reflect the committed changes.
smeenai added inline comments.
cfe/trunk/cmake/caches/Fuchsia-stage2.cmake
29

Out of curiosity, how come you decided to disable assertions? https://reviews.llvm.org/D41471 said "Release+Asserts is fast enough. No need to let insanity through.", and I do think assertions end up catching a bunch of issues, so I was wondering if the build time penalty became too high.