Page MenuHomePhabricator

[llvm-symbolizer] Add -addresses, -a as aliases for -print-address
ClosedPublic

Authored by Quolyk on Jan 12 2019, 3:33 AM.

Diff Detail

Event Timeline

Quolyk created this revision.Jan 12 2019, 3:33 AM
This revision is now accepted and ready to land.Jan 14 2019, 1:58 AM

One thing I've noticed is that single-letter arguments can be combined in GNU addr2line (e.g. addr2line -aC means demangle and print addresses), but not llvm-symbolizer as things stand. I'll file a bug for it, as it's probably worth fixing this all in one go.

The fix can be done by using the cl::Grouping attribute, I believe.

I'll file a bug for it, as it's probably worth fixing this all in one go.

https://bugs.llvm.org/show_bug.cgi?id=40304

This revision was automatically updated to reflect the committed changes.

I'll file a bug for it, as it's probably worth fixing this all in one go.

https://bugs.llvm.org/show_bug.cgi?id=40304

Thanks for review. I'll take a look at that and try to handle.