[llvm-symbolizer] Add -addresses, -a as aliases for -print-address

[Quolyk]

Summary

Provides -addresses, -a as aliases for -print-address. Motivation: https://bugs.llvm.org/show_bug.cgi?id=40067.

[jhenderson]

LGTM.

[jhenderson]

One thing I've noticed is that single-letter arguments can be combined in GNU addr2line (e.g. addr2line -aC means demangle and print addresses), but not llvm-symbolizer as things stand. I'll file a bug for it, as it's probably worth fixing this all in one go.

The fix can be done by using the cl::Grouping attribute, I believe.

[jhenderson]

In D56635#1355781, @jhenderson wrote:

I'll file a bug for it, as it's probably worth fixing this all in one go.

https://bugs.llvm.org/show_bug.cgi?id=40304

[Quolyk]

In D56635#1355791, @jhenderson wrote:

In D56635#1355781, @jhenderson wrote:

I'll file a bug for it, as it's probably worth fixing this all in one go.

https://bugs.llvm.org/show_bug.cgi?id=40304

Thanks for review. I'll take a look at that and try to handle.

docs/CommandGuide/llvm-symbolizer.rst

  address will not be symbolized. Defaults to empty string.
 
 .. option:: -dsym-hint=<path/to/file.dSYM>
 
  (Darwin-only flag). If the debug info for a binary isn't present in the default
  location, look for the debug info at the .dSYM path provided via the
  ``-dsym-hint`` flag. This flag can be used multiple times.
 
-.. option:: -print-address
+.. option:: -print-address, -addresses, -a
 
  Print address before the source code location. Defaults to false.
 
 .. option:: -pretty-print, -p
 
  Print human readable output. If ``-inlining`` is specified, enclosing scope is
  prefixed by (inlined by). Refer to listed examples.
 
 EXIT STATUS
 -----------
 
 :program:`llvm-symbolizer` returns 0. Other exit codes imply internal program error.

test/tools/llvm-symbolizer/sym.test

 #int main () {
 #  int x = 1;
 #  return inc(&x);
 #}
 #
 #Build as : clang -g -O2 addr.c
 
 RUN: llvm-symbolizer -print-address -obj=%p/Inputs/addr.exe < %p/Inputs/addr.inp | FileCheck %s
+RUN: llvm-symbolizer -addresses -obj=%p/Inputs/addr.exe < %p/Inputs/addr.inp | FileCheck %s
+RUN: llvm-symbolizer -a -obj=%p/Inputs/addr.exe < %p/Inputs/addr.inp | FileCheck %s
 RUN: llvm-symbolizer -inlining -print-address -pretty-print -obj=%p/Inputs/addr.exe < %p/Inputs/addr.inp | FileCheck -check-prefix="PRETTY" %s 
 RUN: llvm-symbolizer -inlining -print-address -p -obj=%p/Inputs/addr.exe < %p/Inputs/addr.inp | FileCheck -check-prefix="PRETTY" %s
 RUN: echo "0x1" > %t.input
 RUN: llvm-symbolizer -obj=%p/Inputs/zero < %t.input | FileCheck -check-prefix="ZERO" %s
 
 #CHECK: some text
 #CHECK: 0x40054d
 #CHECK: main

tools/llvm-symbolizer/llvm-symbolizer.cpp

 static cl::opt<std::string>
     ClDwpName("dwp", cl::init(""),
               cl::desc("Path to DWP file to be use for any split CUs"));
 
 static cl::list<std::string>
 ClDsymHint("dsym-hint", cl::ZeroOrMore,
            cl::desc("Path to .dSYM bundles to search for debug info for the "
                     "object files"));
+
+// -print-address, -addresses, -a
 static cl::opt<bool>
-    ClPrintAddress("print-address", cl::init(false),
-                   cl::desc("Show address before line information"));
+static cl::alias
+ClPrintAddressAliasAddresses("addresses", cl::desc("Alias for -print-address"),
+                             cl::NotHidden, cl::aliasopt(ClPrintAddress));
+static cl::alias
+ClPrintAddressAliasA("a", cl::desc("Alias for -print-address"),
+                     cl::NotHidden, cl::aliasopt(ClPrintAddress));
 
 // -pretty-print, -p
 static cl::opt<bool>
     ClPrettyPrint("pretty-print", cl::init(false),
                   cl::desc("Make the output more human friendly"));
 static cl::alias ClPrettyPrintShort("p", cl::desc("Alias for -pretty-print"),
                                     cl::NotHidden,
                                     cl::aliasopt(ClPrettyPrint));