This is an archive of the discontinued LLVM Phabricator instance.

Filesystem tests: fix fs.op.relative
ClosedPublic

Authored by jfb on Jan 9 2019, 3:37 PM.

Event Timeline

jfb created this revision.Jan 9 2019, 3:37 PM
ldionne accepted this revision.Jan 9 2019, 3:39 PM

LGTM, I wonder why it was written that way (perhaps just an oversight)? @EricWF , please chime-in if this change is wrong and it can be reverted.

This revision is now accepted and ready to land.Jan 9 2019, 3:39 PM
EricWF added a comment.Jan 9 2019, 3:43 PM

So there is certainly a bug here. Thanks for fixing it.

The test was written in this weird way to aid in debugging test failures. Without the additional output it's not clear what test case failed or why.

jfb added a comment.Jan 9 2019, 3:49 PM

So there is certainly a bug here. Thanks for fixing it.

The test was written in this weird way to aid in debugging test failures. Without the additional output it's not clear what test case failed or why.

I can just split up each entry in TestCases into its own TEST_CASE if you want. Trivial :)

jfb updated this revision to Diff 180957.Jan 9 2019, 4:06 PM
  • Split up tests
jfb added a comment.Jan 9 2019, 4:07 PM
In D56519#1352024, @jfb wrote:

So there is certainly a bug here. Thanks for fixing it.

The test was written in this weird way to aid in debugging test failures. Without the additional output it's not clear what test case failed or why.

I can just split up each entry in TestCases into its own TEST_CASE if you want. Trivial :)

Alright I was waiting for a build, so I just did a few regular expressions and voila!

This revision was automatically updated to reflect the committed changes.