Page MenuHomePhabricator

[Sema] Teach Clang that aligned allocation is not supported with macosx10.13

Authored by ldionne on Jan 8 2019, 9:45 AM.



r306722 added diagnostics when aligned allocation is used with deployment
targets that do not support it, but the first macosx supporting aligned
allocation was incorrectly set to 10.13. In reality, the dylib shipped
with macosx10.13 does not support aligned allocation, but the dylib
shipped with macosx10.14 does.

Diff Detail


Event Timeline

ldionne created this revision.Jan 8 2019, 9:45 AM
ahatanak accepted this revision.Jan 8 2019, 11:32 AM


We should probably check that alignedAllocMinVersion returns the correct versions for other OSes too, but this patch is fine.

This revision is now accepted and ready to land.Jan 8 2019, 11:32 AM
This revision was automatically updated to reflect the committed changes.
hans added a subscriber: hans.Jan 17 2019, 4:59 AM

This (I think) caused a bunch of libc++ tests to start failing during testing of the newly created 8.0 branch on my machine, see