Page MenuHomePhabricator

[Sema] Teach Clang that aligned allocation is not supported with macosx10.13
ClosedPublic

Authored by ldionne on Tue, Jan 8, 9:45 AM.

Details

Summary

r306722 added diagnostics when aligned allocation is used with deployment
targets that do not support it, but the first macosx supporting aligned
allocation was incorrectly set to 10.13. In reality, the dylib shipped
with macosx10.13 does not support aligned allocation, but the dylib
shipped with macosx10.14 does.

Diff Detail

Repository
rL LLVM

Event Timeline

ldionne created this revision.Tue, Jan 8, 9:45 AM
ahatanak accepted this revision.Tue, Jan 8, 11:32 AM

LGTM.

We should probably check that alignedAllocMinVersion returns the correct versions for other OSes too, but this patch is fine.

This revision is now accepted and ready to land.Tue, Jan 8, 11:32 AM
This revision was automatically updated to reflect the committed changes.