Page MenuHomePhabricator

[DebugInfo] Don't emit DW_AT_enum_class unless it's actually an 'enum class'.
ClosedPublic

Authored by probinson on Jan 7 2019, 8:14 AM.

Details

Summary

The original fix for PR36168 would emit DW_AT_enum_class for both of these cases:

enum Fixed : short { F1 = 1 };
enum class Class { C1 = 1 };

However, it really should be applied only to the latter case.

I'd just do this, except I'm not sure whether PDB cares about this difference. If it does, let me know and I guess we'll have to invent a new flag so the DWARF and PDB generators can each DTRT.

If not, I'll follow up with NFC name changes so the flag becomes DIFlagEnumClass.

Diff Detail

Event Timeline

probinson created this revision.Jan 7 2019, 8:14 AM
This revision was not accepted when it landed; it landed in state Needs Review.Jan 8 2019, 8:32 AM
This revision was automatically updated to reflect the committed changes.