Page MenuHomePhabricator

[ELF] Remove checking for spurious '@' at the end of dynamic symbol names
ClosedPublic

Authored by jhenderson on Jan 7 2019, 7:17 AM.

Details

Summary

llvm-readobj currently has a bug (see PR40097) where it prints '@' at the end of unversioned symbols. I have a fix for this bug ready (see D56319), but the fix breaks a number of LLD tests which explicitly check the spurious '@'. This change removes this checking.

I don't have my system setup to do cross-repo commits, so this change is needed before D56319 can land.

Diff Detail

Repository
rLLD LLVM Linker

Event Timeline

jhenderson created this revision.Jan 7 2019, 7:17 AM
This revision is now accepted and ready to land.Jan 7 2019, 9:25 AM
ruiu accepted this revision.Jan 7 2019, 10:52 AM

LGTM

This revision was automatically updated to reflect the committed changes.