This is an archive of the discontinued LLVM Phabricator instance.

Differential D56352

GlobalISel: Implement widenScalar for implicit_def
ClosedPublic

Authored by arsenm on Jan 5 2019, 4:35 AM.

Details

Reviewers
t.p.northover
dsanders
aditya_nandakumar
ab
aemerson

Diff Detail

Event Timeline

arsenm created this revision.Jan 5 2019, 4:35 AM
Herald added subscribers: javed.absar, kristof.beyls, rovka, wdng. · View Herald TranscriptJan 5 2019, 4:35 AM
arsenm added a reviewer: aemerson.Jan 7 2019, 10:39 PM
aditya_nandakumar accepted this revision.Jan 8 2019, 9:15 AM

Looks good. Thanks

This revision is now accepted and ready to land.Jan 8 2019, 9:15 AM
arsenm closed this revision.Jan 8 2019, 11:38 PM

r350695

Revision Contents

PathSize
lib/
CodeGen/
GlobalISel/
6 lines
test/
CodeGen/
AArch64/
GlobalISel/
20 lines

Diff 180367

lib/CodeGen/GlobalISel/LegalizerHelper.cpp

Show First 20 Lines • Show All 932 Lines • ▼ Show 20 Lines case TargetOpcode::G_FCONSTANT: {
} }
Observer.changingInstr(MI); Observer.changingInstr(MI);
SrcMO.setFPImm(ConstantFP::get(Ctx, Val)); SrcMO.setFPImm(ConstantFP::get(Ctx, Val));
widenScalarDst(MI, WideTy, 0, TargetOpcode::G_FPTRUNC); widenScalarDst(MI, WideTy, 0, TargetOpcode::G_FPTRUNC);
Observer.changedInstr(MI); Observer.changedInstr(MI);
return Legalized; return Legalized;
} }
case TargetOpcode::G_IMPLICIT_DEF: {
Observer.changingInstr(MI);
widenScalarDst(MI, WideTy);
Observer.changedInstr(MI);
return Legalized;
}
case TargetOpcode::G_BRCOND: case TargetOpcode::G_BRCOND:
Observer.changingInstr(MI); Observer.changingInstr(MI);
widenScalarSrc(MI, WideTy, 0, TargetOpcode::G_ANYEXT); widenScalarSrc(MI, WideTy, 0, TargetOpcode::G_ANYEXT);
Observer.changedInstr(MI); Observer.changedInstr(MI);
return Legalized; return Legalized;
case TargetOpcode::G_FCMP: case TargetOpcode::G_FCMP:
Observer.changingInstr(MI); Observer.changingInstr(MI);
▲ Show 20 Lines • Show All 606 Lines • Show Last 20 Lines

test/CodeGen/AArch64/GlobalISel/legalize-undef.mir

# NOTE: Assertions have been autogenerated by utils/update_mir_test_checks.py # NOTE: Assertions have been autogenerated by utils/update_mir_test_checks.py
# RUN: llc -march=aarch64 -run-pass=legalizer %s -o - | FileCheck %s # RUN: llc -march=aarch64 -run-pass=legalizer -O0 %s -o - | FileCheck %s
--- ---
name: test_implicit_def name: test_implicit_def
body: | body: |
bb.0.entry: bb.0.entry:
liveins: liveins:
; CHECK-LABEL: name: test_implicit_def ; CHECK-LABEL: name: test_implicit_def
; CHECK: [[DEF:%[0-9]+]]:_(s64) = G_IMPLICIT_DEF ; CHECK: [[DEF:%[0-9]+]]:_(s64) = G_IMPLICIT_DEF
; CHECK: [[DEF1:%[0-9]+]]:_(s64) = G_IMPLICIT_DEF ; CHECK: [[DEF1:%[0-9]+]]:_(s64) = G_IMPLICIT_DEF
; CHECK: [[MV:%[0-9]+]]:_(s128) = G_MERGE_VALUES [[DEF]](s64), [[DEF1]](s64) ; CHECK: [[MV:%[0-9]+]]:_(s128) = G_MERGE_VALUES [[DEF]](s64), [[DEF1]](s64)
; CHECK: [[TRUNC:%[0-9]+]]:_(s64) = G_TRUNC [[MV]](s128) ; CHECK: [[TRUNC:%[0-9]+]]:_(s64) = G_TRUNC [[MV]](s128)
; CHECK: $x0 = COPY [[TRUNC]](s64) ; CHECK: $x0 = COPY [[TRUNC]](s64)
%0:_(s128) = G_IMPLICIT_DEF %0:_(s128) = G_IMPLICIT_DEF
%1:_(s64) = G_TRUNC %0(s128) %1:_(s64) = G_TRUNC %0(s128)
$x0 = COPY %1(s64) $x0 = COPY %1(s64)
... ...
---
name: test_implicit_def_s3
body: |
bb.0:
liveins:
; CHECK-LABEL: name: test_implicit_def_s3
; CHECK: [[DEF:%[0-9]+]]:_(s8) = G_IMPLICIT_DEF
; CHECK: [[TRUNC:%[0-9]+]]:_(s3) = G_TRUNC [[DEF]](s8)
; CHECK: [[SEXT:%[0-9]+]]:_(s64) = G_SEXT [[TRUNC]](s3)
; CHECK: $x0 = COPY [[SEXT]](s64)
%0:_(s3) = G_IMPLICIT_DEF
%1:_(s64) = G_SEXT %0
$x0 = COPY %1(s64)
...
# FIXME: s2 not correctly handled