[Core] Use the implementation method `GetAddressOf` in `ValueObjectConstResultChild`

[aleksandr.urakov]

Summary

This patch allows to retrieve an address object for ValueObject's children retrieved through e.g. GetChildAtIndex or GetChildMemberWithName. It just uses the corresponding method of the implementation object m_impl to achieve that.

[aleksandr.urakov]

Thanks!

include/lldb/Core/ValueObjectConstResultChild.h

public:
   }
 
   lldb::ValueObjectSP GetSyntheticChildAtOffset(
       uint32_t offset, const CompilerType &type, bool can_create,
       ConstString name_const_str = ConstString()) override;
 
   lldb::ValueObjectSP AddressOf(Status &error) override;
 
+  lldb::addr_t GetAddressOf(bool scalar_is_load_address = true,
+                            AddressType *address_type = nullptr) override;
+
   size_t GetPointeeData(DataExtractor &data, uint32_t item_idx = 0,
                         uint32_t item_count = 1) override;
 
   lldb::ValueObjectSP Cast(const CompilerType &compiler_type) override;
 
 protected:
   ValueObjectConstResultImpl m_impl;
 

packages/Python/lldbsuite/test/python_api/value/TestValueAPI.py

def test(self):
         self.DebugSBValue(val2)
         self.assertTrue(child.GetValue() == val2.GetValue() and
                         child.GetSummary() == val2.GetSummary())
 
         val_i = target.EvaluateExpression('i')
         val_s = target.EvaluateExpression('s')
         val_a = target.EvaluateExpression('a')
         self.assertTrue(
+            val_s.GetChildMemberWithName('a').GetAddress().IsValid(),
+            VALID_VARIABLE)
+        self.assertTrue(
             val_s.GetChildMemberWithName('a').AddressOf(),
             VALID_VARIABLE)
         self.assertTrue(
             val_a.Cast(
                 val_i.GetType()).AddressOf(),
             VALID_VARIABLE)
 
         self.assertTrue(int(lldb.value(frame0.FindVariable('uinthex')))

source/Core/ValueObjectConstResultChild.cpp

lldb::ValueObjectSP ValueObjectConstResultChild::GetSyntheticChildAtOffset(
   return m_impl.GetSyntheticChildAtOffset(offset, type, can_create,
                                           name_const_str);
 }
 
 lldb::ValueObjectSP ValueObjectConstResultChild::AddressOf(Status &error) {
   return m_impl.AddressOf(error);
 }
 
+lldb::addr_t ValueObjectConstResultChild::GetAddressOf(
+  bool scalar_is_load_address, AddressType* address_type) {
+  return m_impl.GetAddressOf(scalar_is_load_address, address_type);
+}
+
 ValueObject *ValueObjectConstResultChild::CreateChildAtIndex(
     size_t idx, bool synthetic_array_member, int32_t synthetic_index) {
   return m_impl.CreateChildAtIndex(idx, synthetic_array_member,
                                    synthetic_index);
 }
 
 size_t ValueObjectConstResultChild::GetPointeeData(DataExtractor &data,
                                                    uint32_t item_idx,
                                                    uint32_t item_count) {
   return m_impl.GetPointeeData(data, item_idx, item_count);
 }
 
 lldb::ValueObjectSP
 ValueObjectConstResultChild::Cast(const CompilerType &compiler_type) {
   return m_impl.Cast(compiler_type);
 }