Page MenuHomePhabricator

leonid.mashinskiy (Leonid Mashinskiy)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 28 2018, 6:35 AM (51 w, 1 d)

Recent Activity

Sep 5 2019

leonid.mashinskiy added a comment to D66994: [lldb][CMake] Fix windows-x86-debug compilation with python enabled using multi-target generator.

Thanks for the review!

Sep 5 2019, 8:17 AM · Restricted Project, Restricted Project
leonid.mashinskiy updated the diff for D66994: [lldb][CMake] Fix windows-x86-debug compilation with python enabled using multi-target generator.

Extracted python lookup logic into function

Sep 5 2019, 3:08 AM · Restricted Project, Restricted Project

Sep 2 2019

leonid.mashinskiy added a comment to D66994: [lldb][CMake] Fix windows-x86-debug compilation with python enabled using multi-target generator.

Since this patch appeared to be arguable from your point of view I will write some comments before making any further changes.

Sep 2 2019, 3:00 AM · Restricted Project, Restricted Project

Aug 30 2019

leonid.mashinskiy created D66994: [lldb][CMake] Fix windows-x86-debug compilation with python enabled using multi-target generator.
Aug 30 2019, 2:47 AM · Restricted Project, Restricted Project

Aug 27 2019

leonid.mashinskiy added a comment to D66655: [lldb] Fix x86 compilation .

@tatyana-krasnukha Can you commit this please because I have no commit access

Aug 27 2019, 7:51 AM · Restricted Project, Restricted Project
leonid.mashinskiy updated the diff for D66655: [lldb] Fix x86 compilation .
Aug 27 2019, 4:11 AM · Restricted Project, Restricted Project

Aug 26 2019

leonid.mashinskiy updated the diff for D66655: [lldb] Fix x86 compilation .
Aug 26 2019, 7:09 AM · Restricted Project, Restricted Project
leonid.mashinskiy updated the diff for D66655: [lldb] Fix x86 compilation .

Updated used guarding macros to cut-off ARM and ARM64 architectures as @tatyana-krasnukha mentioned

Aug 26 2019, 3:10 AM · Restricted Project, Restricted Project

Aug 23 2019

leonid.mashinskiy created D66655: [lldb] Fix x86 compilation .
Aug 23 2019, 8:10 AM · Restricted Project, Restricted Project

Apr 25 2019

leonid.mashinskiy added a comment to D60519: [Windows] Dump more information about access violation exception.

Thanks!
I think I can ask @aleksandr.urakov to land changes.

Apr 25 2019, 11:23 AM · Restricted Project, Restricted Project
leonid.mashinskiy added a comment to D60519: [Windows] Dump more information about access violation exception.

Ping!
Are these changes accepted ?

Apr 25 2019, 6:15 AM · Restricted Project, Restricted Project

Apr 17 2019

leonid.mashinskiy updated the diff for D60519: [Windows] Dump more information about access violation exception.
  • increased buffer size in GetStopDescription call to fit new message
Apr 17 2019, 5:58 AM · Restricted Project, Restricted Project

Apr 11 2019

leonid.mashinskiy added a comment to D60519: [Windows] Dump more information about access violation exception.

Does this affect any existing tests?

I didn't notice new failures and didn't find any existing tests for windows exceptions.

Apr 11 2019, 5:26 AM · Restricted Project, Restricted Project
leonid.mashinskiy updated the diff for D60519: [Windows] Dump more information about access violation exception.
  • added access violation exception message test
Apr 11 2019, 5:14 AM · Restricted Project, Restricted Project

Apr 10 2019

leonid.mashinskiy added a comment to D60519: [Windows] Dump more information about access violation exception.

Thanks for review!

Apr 10 2019, 10:52 AM · Restricted Project, Restricted Project
leonid.mashinskiy created D60519: [Windows] Dump more information about access violation exception.
Apr 10 2019, 9:31 AM · Restricted Project, Restricted Project

Jan 31 2019

leonid.mashinskiy added a comment to D55122: [PDB] Fix location retrieval for function local variables and arguments that are stored relative to VFRAME.

Thanks for review!
Please, commit this for me, because I have no commit access.

Jan 31 2019, 7:48 AM · Restricted Project, Restricted Project
leonid.mashinskiy added inline comments to D55122: [PDB] Fix location retrieval for function local variables and arguments that are stored relative to VFRAME.
Jan 31 2019, 2:02 AM · Restricted Project, Restricted Project
leonid.mashinskiy updated the diff for D55122: [PDB] Fix location retrieval for function local variables and arguments that are stored relative to VFRAME.
  • made changes related to review
Jan 31 2019, 1:59 AM · Restricted Project, Restricted Project

Jan 30 2019

leonid.mashinskiy added a comment to D55122: [PDB] Fix location retrieval for function local variables and arguments that are stored relative to VFRAME.

As D56725 committed, can you please look at latest changes here?

Jan 30 2019, 3:57 AM · Restricted Project, Restricted Project
leonid.mashinskiy added a comment to D56725: [NativePDB] Fix access to both old & new fpo data entries from dbi stream.

Thank you for the review!
Please, commit this for me? I have no commit access but I need to attach pdb from patch that phabricator removed from raw diff.

Jan 30 2019, 2:13 AM

Jan 29 2019

leonid.mashinskiy updated the diff for D56725: [NativePDB] Fix access to both old & new fpo data entries from dbi stream.
  • used new fpo related methods from DbiStream in llvm-pdbutil
  • added test to check fpo data using llvm-pdbutil
Jan 29 2019, 6:16 AM

Jan 17 2019

leonid.mashinskiy updated the diff for D56725: [NativePDB] Fix access to both old & new fpo data entries from dbi stream.
Jan 17 2019, 2:02 AM

Jan 15 2019

leonid.mashinskiy updated the diff for D55122: [PDB] Fix location retrieval for function local variables and arguments that are stored relative to VFRAME.
  • Ported implementation to NativePDB plugin.
  • Implemented GetVariableLocationInfo for local variables of S_DEFRANGE_FRAMEPOINTER_REL and S_DEFRANGE_REGISTER_REL type
Jan 15 2019, 8:13 AM · Restricted Project, Restricted Project
leonid.mashinskiy created D56725: [NativePDB] Fix access to both old & new fpo data entries from dbi stream.
Jan 15 2019, 8:05 AM

Dec 4 2018

leonid.mashinskiy added a comment to D55122: [PDB] Fix location retrieval for function local variables and arguments that are stored relative to VFRAME.

Is this true? Is it not possible for a program to depend on a value of a register which will be defined later?

I am not totally sure about this, but all valid fpo programs that I've seen in existing pdb support this invariant.
So I think that we can assume that every assignment depends only to precedent statements.

Dec 4 2018, 4:28 AM · Restricted Project, Restricted Project
leonid.mashinskiy updated the diff for D55122: [PDB] Fix location retrieval for function local variables and arguments that are stored relative to VFRAME.
  • add more tests on dependent programs
  • handle parsing of cyclically dependent programs properly
  • remove default cases for fully covered enums as mentioned in conding standart
Dec 4 2018, 4:25 AM · Restricted Project, Restricted Project

Dec 3 2018

leonid.mashinskiy added a comment to D55122: [PDB] Fix location retrieval for function local variables and arguments that are stored relative to VFRAME.

Seems like we can't move to NativePDB plugin right now, because there are still not implemented some methods like ParseVariablesForContext which this code integration based on.
But when it will - we can easily do the transition.

Dec 3 2018, 8:11 AM · Restricted Project, Restricted Project
leonid.mashinskiy updated the diff for D55122: [PDB] Fix location retrieval for function local variables and arguments that are stored relative to VFRAME.

Added unit tests for translator and fix issues mentioned by review

Dec 3 2018, 8:04 AM · Restricted Project, Restricted Project

Nov 30 2018

leonid.mashinskiy created D55122: [PDB] Fix location retrieval for function local variables and arguments that are stored relative to VFRAME.
Nov 30 2018, 6:44 AM · Restricted Project, Restricted Project
leonid.mashinskiy added a comment to D55002: [NativePDB] Fix ast-reconstruction test on x86 .

Thank you for the review!
Please, commit this for me? I have no commit access.

Nov 30 2018, 1:18 AM · Restricted Project

Nov 28 2018

leonid.mashinskiy updated subscribers of D55002: [NativePDB] Fix ast-reconstruction test on x86 .
Nov 28 2018, 6:46 AM · Restricted Project
leonid.mashinskiy created D55002: [NativePDB] Fix ast-reconstruction test on x86 .
Nov 28 2018, 6:45 AM · Restricted Project