This is an archive of the discontinued LLVM Phabricator instance.

[ELF] Use SymbolTable::ComdatGroups instead of DummyGroups in LTO
AbandonedPublic

Authored by MaskRay on Dec 21 2018, 10:53 AM.

Details

Event Timeline

MaskRay created this revision.Dec 21 2018, 10:53 AM
ruiu added a comment.Dec 21 2018, 10:56 AM

That doesn't work -- you always want to add symbols again after LTO to override existing bitcode symbols with real symbols, so you don't want to guard bitcode symbols with the same set of strings.

pcc added a subscriber: pcc.Dec 21 2018, 11:03 AM

Yes, unless you're guaranteed that none of the object files will contain any comdats (and I don't believe that the backend makes anything near this guarantee right now), you're going to end up dropping "real" definitions on the floor with this.

MaskRay updated this revision to Diff 179316.Dec 21 2018, 11:07 AM

Use ruiu@'s version

MaskRay abandoned this revision.Dec 21 2018, 11:09 AM

Abandon since ruiu wants to work on this in D56015