Page MenuHomePhabricator

[pstl] Initial integration with LLVM's CMake
ClosedPublic

Authored by ldionne on Dec 20 2018, 3:29 PM.

Details

Summary

This commit adds a check-pstl CMake target that will run the tests
we currently have for pstl. Those tests are not using LLVM lit yet,
but switching them over should be a transparent change. With this
change, we can start relying on the check-pstl target for workflows
and CI.

Note that this commit purposefully does not support the pre-monorepo
layout (with subprojects in projects/), since LLVM is moving towards
the monorepo layout anyway.

Diff Detail

Repository
rL LLVM

Event Timeline

ldionne created this revision.Dec 20 2018, 3:29 PM
ldionne marked an inline comment as done.Dec 20 2018, 3:31 PM
ldionne added a subscriber: MikeDvorskiy.
ldionne added inline comments.
pstl/cmake/FindTBB.cmake
12 ↗(On Diff #179176)

This is required because otherwise they look for both the release and the Debug version of TBB, and we don't find anything if both are not provided. The rest of FindTBB.cmake handles this properly, so I'm not sure why they even try to defer to the TBBConfig.cmake.

MikeDvorskiy added inline comments.Dec 21 2018, 3:24 AM
pstl/cmake/FindTBB.cmake
12 ↗(On Diff #179176)

Yes, the changes may be accepted, at least till the TBBConfig.cmake will not require both Release and Debug TBB.

ldionne accepted this revision.Dec 21 2018, 8:00 AM
ldionne marked an inline comment as done.

@jfb is on vacation, going forward. This is really more for exposition than anything anyway, since this is to get some testing going.

pstl/cmake/FindTBB.cmake
12 ↗(On Diff #179176)

Please consider chiming in here: https://github.com/01org/tbb/issues/113

This revision is now accepted and ready to land.Dec 21 2018, 8:00 AM
This revision was automatically updated to reflect the committed changes.