Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

[libcxx] [test] Add target_info for NetBSD, and XFAIL some of locale tests

Authored by mgorny on Dec 17 2018, 7:46 AM.



Add a target_info definition for NetBSD. The definition is based
on the one used by FreeBSD, with libcxxrt replaced by libc++abi,
and using llvm-libunwind since we need to use its unwinder
implementation to build anyway.

Additionally, XFAIL the 30 tests that fail because of non-implemented
locale features. According to the manual, NetBSD implements only
LC_CTYPE part of locale handling. However, there is a locale database
in the system and locale specifications are validated against it,
so it makes sense to list the common locales as supported.

If I'm counting correctly, this change enables additional 43 passing

Diff Detail


Event Timeline

mgorny created this revision.Dec 17 2018, 7:46 AM
ldionne accepted this revision.Dec 17 2018, 7:59 AM
This revision is now accepted and ready to land.Dec 17 2018, 7:59 AM
krytarowski accepted this revision.Dec 17 2018, 9:55 AM
This revision was automatically updated to reflect the committed changes.