Page MenuHomePhabricator

[CMake] Add support for NO_INSTALL_RPATH argument in llvm_add_library()
ClosedPublic

Authored by sgraenitz on Dec 5 2018, 5:18 AM.

Details

Summary

Allow clients to suppress setup of default RPATHs in designated library targets. This is used in LLDB when emitting liblldb as a framework bundle, which itself doesn't load further RPATH-dependent libraries.
This follows the approach in add_llvm_executable().

Diff Detail

Event Timeline

sgraenitz created this revision.Dec 5 2018, 5:18 AM
aprantl accepted this revision.Dec 5 2018, 9:20 AM
aprantl added inline comments.
cmake/modules/AddLLVM.cmake
460

Any kind of comment that we could add here that explains why this is happening? This looks quite mysterious to the casual reader otherwise :-)

This revision is now accepted and ready to land.Dec 5 2018, 9:20 AM
sgraenitz updated this revision to Diff 177142.Dec 7 2018, 1:06 AM

Add short comment for NO_INSTALL_RPATH parameter to function description

sgraenitz marked 2 inline comments as done.Dec 7 2018, 1:12 AM
sgraenitz added inline comments.
cmake/modules/AddLLVM.cmake
460

Good point, thanks. Added short comment to the function description.

This revision was automatically updated to reflect the committed changes.