[CMake] Move debugserver options to separate debugserverConfig.cmake

[sgraenitz]

Summary

One place for debugserver options, analog to LLDBConfig for LLDB options (see D55317). It was discussed in earlier reviews already, e.g. D55013.

[aprantl]

cmake/modules/debugserverConfig.cmake

2 ↗

(On Diff #176803)

I don't know CMake enough, but would it be feasible to have both file #include a fragment with the shared code?

[sgraenitz]

Avoid conflicts: updating diff for recent changes on master

[sgraenitz]

Remove LLDB_VERSION as it's not currently used by debugserver

[sgraenitz]

Revert accidental change utils/lldb-dotest/CMakeLists.txt

[sgraenitz]

cmake/modules/debugserverConfig.cmake

2 ↗

(On Diff #176803)

Yes I think this makes sense as soon as the number of duplicates grows.

BTW I double-checked and we don't use LLDB_VERSION in debugserver standalone yet, so for now I won't add it. Updated the review accordingly.

[sgraenitz]

Also remove code sign configuration as it moved back into debugserver in D55013. With this, debugserverConfig became really small (for the moment), but I still think it's good to have it as counterpart for LLDBConfig.

lldb/trunk/cmake/modules/debugserverConfig.cmake

+# Duplicate options from LLDBConfig that are relevant for debugserver Standalone builds.
+
+option(LLDB_USE_ENTITLEMENTS "When code signing, use entitlements if available" ON)

lldb/trunk/tools/debugserver/CMakeLists.txt

 cmake_minimum_required(VERSION 3.4.3)
 
 project(Debugserver LANGUAGES C CXX ASM-ATT)
 
 if (CMAKE_SOURCE_DIR STREQUAL CMAKE_CURRENT_SOURCE_DIR)
   set(CMAKE_MODULE_PATH
     ${CMAKE_MODULE_PATH}
     "${CMAKE_SOURCE_DIR}/../../cmake"
     "${CMAKE_SOURCE_DIR}/../../cmake/modules"
     )
 
   include(LLDBStandalone)
+  include(debugserverConfig)
   include(AddLLDB)
 
   set(LLDB_SOURCE_DIR "${CMAKE_SOURCE_DIR}/../../")
   include_directories(${LLDB_SOURCE_DIR}/include)
 
-  option(LLDB_USE_ENTITLEMENTS "When code signing, use entitlements if available" ON)
-
   # lldb-suite is a dummy target that encompasses all the necessary tools and
   # libraries for building a fully-functioning liblldb.
   add_custom_target(lldb-suite)
   set(LLDB_SUITE_TARGET lldb-suite)
 endif()
 
 add_subdirectory(source)