Page MenuHomePhabricator

[test] Split strip-preserve-time.test, and skip atime test on NetBSD
ClosedPublic

Authored by mgorny on Dec 4 2018, 7:50 AM.

Details

Summary

Split timestamp preservation tests into atime and mtime test, and skip
the former on NetBSD. When the filesystem is mounted noatime, NetBSD
not only inhibits implicit atime updates but also prevents setting atime
via utime(), causing the test to fail.

Diff Detail

Repository
rL LLVM

Event Timeline

mgorny created this revision.Dec 4 2018, 7:50 AM
krytarowski added inline comments.Dec 4 2018, 7:55 AM
test/tools/llvm-objcopy/ELF/strip-preserve-atime.test
2 ↗(On Diff #176637)

Please include inlined comment why this unsupported as of now.

Looks good, with a couple of nits.

test/tools/llvm-objcopy/ELF/strip-preserve-atime.test
52 ↗(On Diff #176637)

You should delete and it's corresponding NO-PRESERVE, since it's unused.

test/tools/llvm-objcopy/ELF/strip-preserve-mtime.test
50 ↗(On Diff #176637)

Same comment as in the other test.

mgorny updated this revision to Diff 176644.Dec 4 2018, 8:24 AM
mgorny marked 3 inline comments as done.

Updated wrt comments.

jhenderson accepted this revision.Dec 4 2018, 8:35 AM

LGTM, with one minor comment.

test/tools/llvm-objcopy/ELF/strip-preserve-mtime.test
51 ↗(On Diff #176644)

Ditto.

This revision is now accepted and ready to land.Dec 4 2018, 8:35 AM
mgorny added inline comments.Dec 4 2018, 9:02 AM
test/tools/llvm-objcopy/ELF/strip-preserve-mtime.test
51 ↗(On Diff #176644)

Do you mean the empty line?

rupprecht accepted this revision.Dec 4 2018, 9:29 AM
krytarowski accepted this revision.Dec 4 2018, 9:57 AM
mgorny updated this revision to Diff 176685.Dec 4 2018, 12:09 PM
mgorny marked 2 inline comments as done.
jhenderson accepted this revision.Dec 5 2018, 2:14 AM

LGTM.

test/tools/llvm-objcopy/ELF/strip-preserve-mtime.test
51 ↗(On Diff #176644)

Yes.

This revision was automatically updated to reflect the committed changes.