Page MenuHomePhabricator

[asan] Add clang flag -fsanitize-address-use-odr-indicator
ClosedPublic

Authored by vitalybuka on Nov 30 2018, 5:21 PM.

Diff Detail

Event Timeline

vitalybuka created this revision.Nov 30 2018, 5:21 PM
vitalybuka updated this revision to Diff 176717.Dec 4 2018, 2:52 PM

"use" everywhere for consistency

eugenis added inline comments.Dec 4 2018, 4:09 PM
clang/docs/ClangCommandLineReference.rst
805 ↗(On Diff #176717)

Please expand this a little bit.

vitalybuka updated this revision to Diff 176728.Dec 4 2018, 4:21 PM

changed doc string

vitalybuka updated this revision to Diff 176730.Dec 4 2018, 4:25 PM
vitalybuka marked an inline comment as done.

more doc strings

vitalybuka marked an inline comment as done.Dec 4 2018, 4:28 PM
vitalybuka added inline comments.
clang/docs/ClangCommandLineReference.rst
805 ↗(On Diff #176717)

I've reworded this, but this file does not contains details.

eugenis added inline comments.Dec 4 2018, 5:22 PM
clang/docs/ClangCommandLineReference.rst
805 ↗(On Diff #176717)

Ideally this documentation should be enough for a user to make a decision whether they need the flag or not. How about adding something like " in partially sanitized programs at the cost of an increase in binary size"?

vitalybuka marked an inline comment as done.Dec 4 2018, 5:44 PM
eugenis accepted this revision.Dec 4 2018, 5:45 PM

LGTM

This revision is now accepted and ready to land.Dec 4 2018, 5:45 PM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: Restricted Project. · View Herald TranscriptDec 4 2018, 5:47 PM