This is an archive of the discontinued LLVM Phabricator instance.

Differential D55157

[asan] Add clang flag -fsanitize-address-use-odr-indicator
ClosedPublic

Authored by vitalybuka on Nov 30 2018, 5:21 PM.

Download Raw Diff

Details

Reviewers

eugenis
m.ostapenko
ygribov

Commits

rG8076c57fd2f9: [asan] Add clang flag -fsanitize-address-use-odr-indicator
rC348327: [asan] Add clang flag -fsanitize-address-use-odr-indicator
rL348327: [asan] Add clang flag -fsanitize-address-use-odr-indicator
rCRT348327: [asan] Add clang flag -fsanitize-address-use-odr-indicator

Diff Detail

Repository: rCRT Compiler Runtime

Event Timeline

vitalybuka created this revision.Nov 30 2018, 5:21 PM

Herald added subscribers: llvm-commits, hiraditya. · View Herald TranscriptNov 30 2018, 5:21 PM

Harbormaster completed remote builds in B25577: Diff 176232.Nov 30 2018, 5:22 PM

vitalybuka added a parent revision: D55156: [asan] Split -asan-use-private-alias to -asan-use-odr-indicator.Nov 30 2018, 5:23 PM

Rebase

Herald added a subscriber: kubamracek. · View Herald TranscriptDec 4 2018, 2:40 PM

Harbormaster completed remote builds in B25693: Diff 176713.Dec 4 2018, 2:40 PM

update

Harbormaster completed remote builds in B25694: Diff 176714.Dec 4 2018, 2:43 PM

update

Harbormaster completed remote builds in B25695: Diff 176716.Dec 4 2018, 2:46 PM

"use" everywhere for consistency

Harbormaster completed remote builds in B25696: Diff 176717.Dec 4 2018, 2:53 PM

eugenis added inline comments.Dec 4 2018, 4:09 PM

clang/docs/ClangCommandLineReference.rst
805 ↗	(On Diff #176717)	Please expand this a little bit.

changed doc string

Harbormaster completed remote builds in B25697: Diff 176728.Dec 4 2018, 4:21 PM

more doc strings

Harbormaster completed remote builds in B25698: Diff 176730.Dec 4 2018, 4:26 PM

vitalybuka marked an inline comment as done.Dec 4 2018, 4:28 PM

vitalybuka added inline comments.

clang/docs/ClangCommandLineReference.rst
805 ↗	(On Diff #176717)	I've reworded this, but this file does not contains details.

eugenis added inline comments.Dec 4 2018, 5:22 PM

clang/docs/ClangCommandLineReference.rst
805 ↗	(On Diff #176717)	Ideally this documentation should be enough for a user to make a decision whether they need the flag or not. How about adding something like " in partially sanitized programs at the cost of an increase in binary size"?

docs

vitalybuka marked an inline comment as done.Dec 4 2018, 5:44 PM

Harbormaster completed remote builds in B25702: Diff 176747.Dec 4 2018, 5:44 PM

LGTM

This revision is now accepted and ready to land.Dec 4 2018, 5:45 PM

Closed by commit rCRT348327: [asan] Add clang flag -fsanitize-address-use-odr-indicator (authored by vitalybuka). · Explain WhyDec 4 2018, 5:47 PM

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: Restricted Project. · View Herald TranscriptDec 4 2018, 5:47 PM

Revision Contents

Path

Size

test/

asan/

TestCases/

Linux/

odr-violation.cc

5 lines

Diff 176748

test/asan/TestCases/Linux/odr-violation.cc

	Show All 27 Lines
	// RUN: %clangxx_asan -mllvm -asan-use-private-alias %s %t-ODR-SO.so -Wl,-R. -o %t-ODR-EXE			// RUN: %clangxx_asan -mllvm -asan-use-private-alias %s %t-ODR-SO.so -Wl,-R. -o %t-ODR-EXE
	// RUN: %env_asan_opts=fast_unwind_on_malloc=0 %run %t-ODR-EXE 2>&1 \| FileCheck %s --check-prefix=DISABLED			// RUN: %env_asan_opts=fast_unwind_on_malloc=0 %run %t-ODR-EXE 2>&1 \| FileCheck %s --check-prefix=DISABLED

	// Use private aliases for global variables: use indicator symbol to detect ODR violation.			// Use private aliases for global variables: use indicator symbol to detect ODR violation.
	// RUN: %clangxx_asan -DBUILD_SO=1 -fPIC -shared -mllvm -asan-use-private-alias -mllvm -asan-use-odr-indicator %s -o %t-ODR-SO.so -DSZ=100			// RUN: %clangxx_asan -DBUILD_SO=1 -fPIC -shared -mllvm -asan-use-private-alias -mllvm -asan-use-odr-indicator %s -o %t-ODR-SO.so -DSZ=100
	// RUN: %clangxx_asan -mllvm -asan-use-private-alias -mllvm -asan-use-odr-indicator %s %t-ODR-SO.so -Wl,-R. -o %t-ODR-EXE			// RUN: %clangxx_asan -mllvm -asan-use-private-alias -mllvm -asan-use-odr-indicator %s %t-ODR-SO.so -Wl,-R. -o %t-ODR-EXE
	// RUN: %env_asan_opts=fast_unwind_on_malloc=0 not %run %t-ODR-EXE 2>&1 \| FileCheck %s			// RUN: %env_asan_opts=fast_unwind_on_malloc=0 not %run %t-ODR-EXE 2>&1 \| FileCheck %s

				// Same as above but with clang switches.
				// RUN: %clangxx_asan -DBUILD_SO=1 -fPIC -shared -fsanitize-address-use-odr-indicator %s -o %t-ODR-SO.so -DSZ=100
				// RUN: %clangxx_asan -fsanitize-address-use-odr-indicator %s %t-ODR-SO.so -Wl,-R. -o %t-ODR-EXE
				// RUN: %env_asan_opts=fast_unwind_on_malloc=0 not %run %t-ODR-EXE 2>&1 \| FileCheck %s

	// GNU driver doesn't handle .so files properly.			// GNU driver doesn't handle .so files properly.
	// REQUIRES: Clang			// REQUIRES: Clang

	#ifndef SZ			#ifndef SZ
	# define SZ 4			# define SZ 4
	#endif			#endif

	#if BUILD_SO			#if BUILD_SO
	Show All 17 Lines