Page MenuHomePhabricator

[asan] Reduce binary size by using unnamed private aliases
ClosedPublic

Authored by vitalybuka on Nov 30 2018, 1:45 PM.

Details

Summary

--asan-use-private-alias increases binary sizes by 10% or more.
Most of this space was long names of aliases and new symbols.
These symbols are not needed for the ODR check at all.

Diff Detail

Repository
rL LLVM

Event Timeline

vitalybuka created this revision.Nov 30 2018, 1:45 PM
eugenis edited the summary of this revision. (Show Details)Nov 30 2018, 4:01 PM
eugenis added reviewers: m.ostapenko, ygribov.

I've added original contributors of the private-alias thing to double check that we are not breaking any assumptions by doing this.

m.ostapenko accepted this revision.Dec 3 2018, 6:56 AM

I think this should be fine, aliases don't need names at all.

This revision is now accepted and ready to land.Dec 3 2018, 6:56 AM
This revision was automatically updated to reflect the committed changes.