- User Since
- Nov 10 2013, 10:06 PM (358 w, 1 d)
Sep 26 2018
Meanwhile few more tests required changes.
Sep 18 2018
Reopening (commit caused lit regressions).
Aug 31 2018
Good catch, the fix looks good to me. I assume you built llvm will all (non-experimental) targets and tested them?
Aug 30 2018
Apr 27 2017
Mar 28 2017
Mar 18 2017
Looks good, thanks!
Mar 15 2017
Mar 1 2017
Feb 28 2017
E.g. check for '-mthumb' flag into lit configs and enable/disable tests accordingly?
However, I think I have not yet understood why using strict_strings should only verify the string until the first delimiter.
Feb 27 2017
I suggest to regenerate patch with -U99999, to get more context.
Feb 17 2017
BTW how is the situation different from Asan? Fast unwinder should have _exactly_ same problems there but I guess just decided to live with them.
One option is to force libasan and tests to compile to ARM (via -marm switch) which is known to work. I think common understanding is that fast unwinder is unfixable in Thumb mode.
Feb 6 2017
Feb 2 2017
Jan 19 2017
Jan 12 2017
Dec 16 2016
What's the said problem with wrapping btw?
Dec 15 2016
Should we change
There's nothing wrong with this patch, but it's a binary-compatibility issue
Dec 13 2016
Jul 28 2016
Ideally, this race in ScopedInErrorReport should be eliminated
There's no guarantee of write operation atomicity unless we open corresponding file with O_APPEND flag in Unix
Jul 14 2016
As discussed in private email, I'm ok with this change (provided that change of checked file has been tested). I'm not a reviewer though.
May 23 2016
May 13 2016
May 5 2016
Can we have generic option for other sanitizers?
This may need a test.
Apr 11 2016
Could someone check this: https://github.com/google/sanitizers/issues/669 ? Seems to be caused by this patch.
Mar 4 2016
linux will be present in android also making SANITIZER_LINUX true for android.
Feb 29 2016
Shouldn't all this be in TestCases/Posix?
Feb 26 2016
Feb 18 2016
Feb 16 2016
Feb 8 2016
Append -UNDEBUG instead of filtering flags, per Laszlo's advice.
Feb 6 2016
Feb 3 2016
Feb 1 2016
why not just append a -UNDEBUG to the end of the argument list? would not it make the same effect?
Jan 31 2016
Jan 29 2016
Addressed Laszlo's comments.
Jan 28 2016
Jan 27 2016
Laszlo, Anna, does this look better?
Jan 26 2016
Max, what about test?
Guys, what do you think? This is complex but we see no other way to robustly support globals.
Jan 25 2016
Jan 22 2016
Addressed Laszlo's comments.
$ PATH=$(pwd)/bin:$PATH python -m unittest -vI don't think so:
the command i gave to you works fine on my environment.
would be curious to know what OS/python do you use to have the differences.
Jan 21 2016
nice idea and good work! i personally think that even more aggressive ways to explore bugs. (like call it with and without optimization/debug flags,
collect the report from multiple runs and merge it into a single report.)
Like the perl scan-build, you shouldn't need to install scan-build-py to run it.
You can just run the scan-build script in the 'tools/scan-build-py/bin/' directory in the clang source directory.
Addressed some of the comments, seems to work.
Jan 20 2016
Jan 19 2016
I guess you need to update asan_init version.
Jan 18 2016
Updated the patch with draft scan-build-py support which I don't know how to test. Also renamed option according to Alexey's comment.
scan-build is being re-implemented in python. Please, add this option to scan-build-py as well; otherwise, it will get lost when we transition.
Jan 14 2016
Jan 11 2016
What's the problem with Vfork though?
Dec 30 2015
But still, failing with CHECK error looks a bit scary for users
Dec 29 2015
Added a test.
Relevant snippet from bionic/libc/include/assert.h:
# if __ISO_C_VISIBLE >= 1999 # define assert(e) ((e) ? (void)0 : __assert2(__FILE__, __LINE__, __func__, #e)) ... __dead void __assert2(const char *, int, const char *, const char *);
I'm not sure upstream people will take this but probably still makes sense to publish FTR.
Forgot to mention - no regressions in make check-all.