Page MenuHomePhabricator

ygribov (Yury Gribov)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 10 2013, 10:06 PM (305 w, 2 d)

Recent Activity

Sep 26 2018

ygribov committed rL343090: Fixes removal of dead elements from PressureDiff (PR37252)..
Fixes removal of dead elements from PressureDiff (PR37252).
Sep 26 2018, 3:44 AM
ygribov closed D51495: Fix removal of dead elements from PressureDiff.
Sep 26 2018, 3:44 AM
ygribov updated the diff for D51495: Fix removal of dead elements from PressureDiff.

Meanwhile few more tests required changes.

Sep 26 2018, 3:44 AM

Sep 18 2018

ygribov reopened D51495: Fix removal of dead elements from PressureDiff.

Reopening (commit caused lit regressions).

Sep 18 2018, 7:53 AM
ygribov committed rL342457: Fixes removal of dead elements from PressureDiff (PR37252)..
Fixes removal of dead elements from PressureDiff (PR37252).
Sep 18 2018, 2:55 AM
ygribov closed D51495: Fix removal of dead elements from PressureDiff.
Sep 18 2018, 2:55 AM

Aug 31 2018

ygribov added a comment to D51495: Fix removal of dead elements from PressureDiff.

Good catch, the fix looks good to me. I assume you built llvm will all (non-experimental) targets and tested them?

Aug 31 2018, 1:37 AM

Aug 30 2018

ygribov created D51495: Fix removal of dead elements from PressureDiff.
Aug 30 2018, 10:01 AM

Apr 27 2017

ygribov added inline comments to D32589: [sanitizer] Intercept mcheck and mprobe on Linux.
Apr 27 2017, 5:37 AM · Restricted Project

Mar 28 2017

ygribov added inline comments to D31420: [asan] Move AsanCheckDynamicRTPrereqs check under flag..
Mar 28 2017, 7:17 AM · Restricted Project

Mar 18 2017

ygribov added a comment to D30384: [asan] Add an interceptor for strtok.

Looks good, thanks!

Mar 18 2017, 1:57 AM

Mar 15 2017

ygribov added inline comments to D30384: [asan] Add an interceptor for strtok.
Mar 15 2017, 2:59 PM
ygribov added inline comments to D30384: [asan] Add an interceptor for strtok.
Mar 15 2017, 2:56 PM

Mar 1 2017

ygribov added inline comments to D30504: [sanitizer] Bail out with warning if user dlopens shared library with RTLD_DEEPBIND flag.
Mar 1 2017, 10:21 AM · Restricted Project

Feb 28 2017

ygribov added a comment to D29586: [lsan] Enable LSan for arm Linux.

E.g. check for '-mthumb' flag into lit configs and enable/disable tests accordingly?

Feb 28 2017, 10:42 AM · Restricted Project
ygribov added a comment to D30384: [asan] Add an interceptor for strtok.

However, I think I have not yet understood why using strict_strings should only verify the string until the first delimiter.

Feb 28 2017, 1:33 AM

Feb 27 2017

ygribov added a comment to D30384: [asan] Add an interceptor for strtok.

I suggest to regenerate patch with -U99999, to get more context.

Feb 27 2017, 1:45 AM

Feb 17 2017

ygribov added a comment to D29586: [lsan] Enable LSan for arm Linux.

BTW how is the situation different from Asan? Fast unwinder should have _exactly_ same problems there but I guess just decided to live with them.

Feb 17 2017, 3:53 AM · Restricted Project
ygribov added a comment to D29586: [lsan] Enable LSan for arm Linux.

One option is to force libasan and tests to compile to ARM (via -marm switch) which is known to work. I think common understanding is that fast unwinder is unfixable in Thumb mode.

Feb 17 2017, 2:34 AM · Restricted Project

Feb 6 2017

ygribov added inline comments to D29586: [lsan] Enable LSan for arm Linux.
Feb 6 2017, 9:55 PM · Restricted Project
ygribov added inline comments to D29586: [lsan] Enable LSan for arm Linux.
Feb 6 2017, 11:13 AM · Restricted Project
ygribov added inline comments to D29586: [lsan] Enable LSan for arm Linux.
Feb 6 2017, 9:04 AM · Restricted Project

Feb 2 2017

ygribov added inline comments to D29382: [lsan] Respect default value of detect_leaks flag.
Feb 2 2017, 9:09 AM · Restricted Project

Jan 19 2017

ygribov added inline comments to D28609: [lsan] Enable LSan for x86 Linux..
Jan 19 2017, 6:29 AM · Restricted Project

Jan 12 2017

ygribov added inline comments to D28609: [lsan] Enable LSan for x86 Linux..
Jan 12 2017, 8:30 AM · Restricted Project
ygribov added inline comments to D28609: [lsan] Enable LSan for x86 Linux..
Jan 12 2017, 8:03 AM · Restricted Project

Dec 16 2016

ygribov added a comment to D27659: [sanitizer] intercept bstring functions.

What's the said problem with wrapping btw?

Dec 16 2016, 9:57 AM

Dec 15 2016

ygribov added a comment to D27659: [sanitizer] intercept bstring functions.

Should we change

Dec 15 2016, 10:57 AM
ygribov added a comment to D27659: [sanitizer] intercept bstring functions.

There's nothing wrong with this patch, but it's a binary-compatibility issue

Dec 15 2016, 1:18 AM

Dec 13 2016

ygribov added inline comments to D27659: [sanitizer] intercept bstring functions.
Dec 13 2016, 11:12 PM

Jul 28 2016

ygribov added a comment to D22921: [asan] Reduce flakiness of heavy recovery mode tests..

Ideally, this race in ScopedInErrorReport should be eliminated

Jul 28 2016, 9:39 AM · Restricted Project
ygribov added a comment to D22921: [asan] Reduce flakiness of heavy recovery mode tests..

There's no guarantee of write operation atomicity unless we open corresponding file with O_APPEND flag in Unix

Jul 28 2016, 9:33 AM · Restricted Project

Jul 14 2016

ygribov added a comment to D22309: [asan] Reduce flakiness of halt_on_error-torture.cc testcase..

As discussed in private email, I'm ok with this change (provided that change of checked file has been tested). I'm not a reviewer though.

Jul 14 2016, 6:12 AM · Restricted Project

May 23 2016

ygribov added a comment to D20524: [asan] Fix a deadlock halt_on_error-signals.c when `reporting_thread_tid_` is 0.

+1

May 23 2016, 9:52 AM · Restricted Project

May 13 2016

ygribov added inline comments to D20235: [asan] Fix asan initialization failure with newer (2.23+) glibc in use..
May 13 2016, 7:42 AM

May 5 2016

ygribov added a comment to D19666: [ubsan] Add -fubsan-strip-path-components=N.

Can we have generic option for other sanitizers?

May 5 2016, 4:29 AM
ygribov added a comment to D19958: [asan] Bail out on stack overflow in recovery mode..

This may need a test.

May 5 2016, 2:29 AM

Apr 11 2016

ygribov added a comment to D11719: [asan] Fix dyld version detection on OS X.

Could someone check this: https://github.com/google/sanitizers/issues/669 ? Seems to be caused by this patch.

Apr 11 2016, 8:45 PM

Mar 4 2016

ygribov added a comment to D17880: [Compiler-rt] Use __gnu_linux__ instead of __linux__ to detect Linux OS.

linux will be present in android also making SANITIZER_LINUX true for android.

Mar 4 2016, 2:31 AM

Feb 29 2016

ygribov added a comment to D17639: [asan] Fix recvfrom.cc testcase failure in large parallel tests run..

Shouldn't all this be in TestCases/Posix?

Feb 29 2016, 4:20 AM

Feb 26 2016

ygribov added inline comments to D17639: [asan] Fix recvfrom.cc testcase failure in large parallel tests run..
Feb 26 2016, 6:38 AM
ygribov added inline comments to D17639: [asan] Fix recvfrom.cc testcase failure in large parallel tests run..
Feb 26 2016, 3:10 AM
ygribov added inline comments to D17639: [asan] Fix recvfrom.cc testcase failure in large parallel tests run..
Feb 26 2016, 3:01 AM

Feb 18 2016

ygribov committed rL261219: [analyzer] dump_ast_matchers.py: fix replacement regexps.
[analyzer] dump_ast_matchers.py: fix replacement regexps
Feb 18 2016, 7:48 AM
ygribov closed D17376: dump_ast_matchers.py: fix replacement regexps by committing rL261219: [analyzer] dump_ast_matchers.py: fix replacement regexps.
Feb 18 2016, 7:48 AM
ygribov committed rL261204: [analyzer] Add --force-analyze-debug-code option to scan-build.
[analyzer] Add --force-analyze-debug-code option to scan-build
Feb 18 2016, 3:13 AM
ygribov closed D16200: Add --force-analyze-debug-code option to scan-build to force debug build and hopefully enable more precise warnings. by committing rL261204: [analyzer] Add --force-analyze-debug-code option to scan-build.
Feb 18 2016, 3:13 AM

Feb 16 2016

ygribov added a comment to D16200: Add --force-analyze-debug-code option to scan-build to force debug build and hopefully enable more precise warnings..

Ping.

Feb 16 2016, 4:56 AM

Feb 8 2016

ygribov updated the diff for D16200: Add --force-analyze-debug-code option to scan-build to force debug build and hopefully enable more precise warnings..

Append -UNDEBUG instead of filtering flags, per Laszlo's advice.

Feb 8 2016, 5:59 AM

Feb 6 2016

ygribov edited reviewers for D16946: Add link to llvm git documentation, and recommend always building libcxx on OSX, added: kubamracek; removed: ygribov.
Feb 6 2016, 10:41 AM

Feb 3 2016

ygribov committed rL259647: Forgot to remove file in previous commit..
Forgot to remove file in previous commit.
Feb 3 2016, 5:40 AM
ygribov committed rL259646: [analyzer] AnalysisConsumer: print fully-qualified function name while….
[analyzer] AnalysisConsumer: print fully-qualified function name while…
Feb 3 2016, 5:39 AM
ygribov closed D16804: [analyzer] AnalysisConsumer: print fully-qualified function name while displaying progress by committing rL259646: [analyzer] AnalysisConsumer: print fully-qualified function name while….
Feb 3 2016, 5:39 AM

Feb 1 2016

ygribov added a comment to D16200: Add --force-analyze-debug-code option to scan-build to force debug build and hopefully enable more precise warnings..

why not just append a -UNDEBUG to the end of the argument list? would not it make the same effect?

Feb 1 2016, 1:45 AM

Jan 31 2016

ygribov removed a reviewer for D16682: 19957 - OpenCL incorrectly accepts implicit address space conversion with ternary operator: ygribov.
Jan 31 2016, 8:07 AM

Jan 29 2016

ygribov updated the diff for D16200: Add --force-analyze-debug-code option to scan-build to force debug build and hopefully enable more precise warnings..

Addressed Laszlo's comments.

Jan 29 2016, 5:36 AM

Jan 28 2016

ygribov committed rL259031: Fix isBeforeInTranslationUnit to not abort on macros defined in cmdline..
Fix isBeforeInTranslationUnit to not abort on macros defined in cmdline.
Jan 28 2016, 1:32 AM
ygribov committed rL259030: Small refactor in isBeforeInTranslationUnit..
Small refactor in isBeforeInTranslationUnit.
Jan 28 2016, 1:31 AM
ygribov closed D15804: Fix isBeforeInTranslationUnit to not abort on macros defined in cmdline. by committing rL259030: Small refactor in isBeforeInTranslationUnit..
Jan 28 2016, 1:31 AM

Jan 27 2016

ygribov added a comment to D15804: Fix isBeforeInTranslationUnit to not abort on macros defined in cmdline..

Ping.

Jan 27 2016, 2:34 AM
ygribov added a reviewer for D15804: Fix isBeforeInTranslationUnit to not abort on macros defined in cmdline.: akyrtzi.
Jan 27 2016, 2:34 AM
ygribov added a comment to D16200: Add --force-analyze-debug-code option to scan-build to force debug build and hopefully enable more precise warnings..

Laszlo, Anna, does this look better?

Jan 27 2016, 2:28 AM

Jan 26 2016

ygribov added a comment to D15807: [asan] Fix internal CHECK failure on double free in recovery mode..

Max, what about test?

Jan 26 2016, 5:56 AM
ygribov added a comment to D15642: [asan] Use private aliases for global variables (LLVM part)..

Guys, what do you think? This is complex but we see no other way to robustly support globals.

Jan 26 2016, 5:55 AM

Jan 25 2016

ygribov added inline comments to D15225: [Driver] Sanitizer support based on runtime library presence.
Jan 25 2016, 9:34 AM
ygribov added inline comments to D15225: [Driver] Sanitizer support based on runtime library presence.
Jan 25 2016, 6:21 AM

Jan 22 2016

ygribov added a comment to D15804: Fix isBeforeInTranslationUnit to not abort on macros defined in cmdline..

Ping.

Jan 22 2016, 6:42 AM
ygribov updated the diff for D16200: Add --force-analyze-debug-code option to scan-build to force debug build and hopefully enable more precise warnings..

Addressed Laszlo's comments.

Jan 22 2016, 6:23 AM
ygribov added a comment to D16200: Add --force-analyze-debug-code option to scan-build to force debug build and hopefully enable more precise warnings..
$ PATH=$(pwd)/bin:$PATH python -m unittest -v
I don't think so:

the command i gave to you works fine on my environment.
would be curious to know what OS/python do you use to have the differences.

Jan 22 2016, 2:53 AM

Jan 21 2016

ygribov added a comment to D16200: Add --force-analyze-debug-code option to scan-build to force debug build and hopefully enable more precise warnings..
Jan 21 2016, 12:07 PM
ygribov added a comment to D16200: Add --force-analyze-debug-code option to scan-build to force debug build and hopefully enable more precise warnings..

nice idea and good work! i personally think that even more aggressive ways to explore bugs. (like call it with and without optimization/debug flags,
collect the report from multiple runs and merge it into a single report.)

Jan 21 2016, 12:06 PM
ygribov added a comment to D16200: Add --force-analyze-debug-code option to scan-build to force debug build and hopefully enable more precise warnings..

Like the perl scan-build, you shouldn't need to install scan-build-py to run it.
You can just run the scan-build script in the 'tools/scan-build-py/bin/' directory in the clang source directory.

Jan 21 2016, 12:03 PM
ygribov updated the diff for D16200: Add --force-analyze-debug-code option to scan-build to force debug build and hopefully enable more precise warnings..

Addressed some of the comments, seems to work.

Jan 21 2016, 12:00 PM

Jan 20 2016

ygribov added inline comments to D15644: [asan] Use private aliases for global variables (compiler-rt part)..
Jan 20 2016, 1:08 PM
ygribov added inline comments to D15642: [asan] Use private aliases for global variables (LLVM part)..
Jan 20 2016, 12:49 PM

Jan 19 2016

ygribov added a comment to D15644: [asan] Use private aliases for global variables (compiler-rt part)..

I guess you need to update asan_init version.

Jan 19 2016, 1:07 PM
ygribov added inline comments to D15642: [asan] Use private aliases for global variables (LLVM part)..
Jan 19 2016, 12:51 PM

Jan 18 2016

ygribov updated the diff for D16200: Add --force-analyze-debug-code option to scan-build to force debug build and hopefully enable more precise warnings..

Updated the patch with draft scan-build-py support which I don't know how to test. Also renamed option according to Alexey's comment.

Jan 18 2016, 1:44 AM
ygribov added a comment to D16200: Add --force-analyze-debug-code option to scan-build to force debug build and hopefully enable more precise warnings..

scan-build is being re-implemented in python. Please, add this option to scan-build-py as well; otherwise, it will get lost when we transition.

Jan 18 2016, 1:21 AM

Jan 14 2016

ygribov retitled D16200: Add --force-analyze-debug-code option to scan-build to force debug build and hopefully enable more precise warnings. from to Add --force-debug option to scan-build to force debug build and hopefully enable more precise warnings..
Jan 14 2016, 10:53 AM
ygribov added inline comments to D16070: [asan] Optionally print reproducer cmdline in ASan reports..
Jan 14 2016, 4:38 AM

Jan 11 2016

ygribov added inline comments to D16070: [asan] Optionally print reproducer cmdline in ASan reports..
Jan 11 2016, 9:13 AM
ygribov committed rL257318: AnalysisConsumer: use canonical decl for both lookup and store of.
AnalysisConsumer: use canonical decl for both lookup and store of
Jan 11 2016, 1:42 AM
ygribov closed D15410: AnalysisConsumer: use canonical decl for both lookup and store of visited decls by committing rL257318: AnalysisConsumer: use canonical decl for both lookup and store of.
Jan 11 2016, 1:42 AM
ygribov added a comment to D15804: Fix isBeforeInTranslationUnit to not abort on macros defined in cmdline..

Ping.

Jan 11 2016, 1:32 AM
ygribov added a comment to D15888: [Analyzer] Change the default SA checkers for PS4.

What's the problem with Vfork though?

Jan 11 2016, 12:42 AM

Dec 30 2015

ygribov added a comment to D15807: [asan] Fix internal CHECK failure on double free in recovery mode..

But still, failing with CHECK error looks a bit scary for users

Dec 30 2015, 10:25 AM

Dec 29 2015

ygribov updated the diff for D15810: [analyzer] Handle another Android assert function..

Added a test.

Dec 29 2015, 10:01 AM
ygribov added a comment to D15810: [analyzer] Handle another Android assert function..

Relevant snippet from bionic/libc/include/assert.h:

# if __ISO_C_VISIBLE >= 1999
#  define       assert(e)       ((e) ? (void)0 : __assert2(__FILE__, __LINE__, __func__, #e))
...
__dead void __assert2(const char *, int, const char *, const char *);
Dec 29 2015, 7:52 AM
ygribov retitled D15810: [analyzer] Handle another Android assert function. from to [analyzer] Handle another Android assert function..
Dec 29 2015, 7:51 AM
ygribov added a comment to D15807: [asan] Fix internal CHECK failure on double free in recovery mode..

I'm not sure upstream people will take this but probably still makes sense to publish FTR.

Dec 29 2015, 6:23 AM
ygribov added a comment to D15804: Fix isBeforeInTranslationUnit to not abort on macros defined in cmdline..

Forgot to mention - no regressions in make check-all.

Dec 29 2015, 2:27 AM
ygribov retitled D15804: Fix isBeforeInTranslationUnit to not abort on macros defined in cmdline. from to Fix isBeforeInTranslationUnit to not abort on macros defined in cmdline..
Dec 29 2015, 2:26 AM

Dec 18 2015

ygribov added inline comments to D15644: [asan] Use private aliases for global variables (compiler-rt part)..
Dec 18 2015, 11:55 AM

Dec 10 2015

ygribov committed rL255242: [asan] Use atomic_uintptr_t instead of atomic_uint64_t in SuppressErrorReport..
[asan] Use atomic_uintptr_t instead of atomic_uint64_t in SuppressErrorReport.
Dec 10 2015, 3:10 AM
ygribov committed rL255230: [asan] Move halt_on_error_suppress_equal_pcs.cc to Posix directory..
[asan] Move halt_on_error_suppress_equal_pcs.cc to Posix directory.
Dec 10 2015, 12:37 AM
ygribov committed rL255228: [asan] Suppress duplicated errors in ASan recovery mode..
[asan] Suppress duplicated errors in ASan recovery mode.
Dec 10 2015, 12:12 AM
ygribov closed D15080: [asan] Reports suppressions for ASan recovery mode (compiler-rt part). by committing rL255228: [asan] Suppress duplicated errors in ASan recovery mode..
Dec 10 2015, 12:12 AM

Dec 9 2015

ygribov added inline comments to D15080: [asan] Reports suppressions for ASan recovery mode (compiler-rt part)..
Dec 9 2015, 3:17 PM
ygribov added inline comments to D15080: [asan] Reports suppressions for ASan recovery mode (compiler-rt part)..
Dec 9 2015, 9:26 AM