This is an archive of the discontinued LLVM Phabricator instance.

[libcxx] Reorganize tests since the application of P0602R4
ClosedPublic

Authored by ldionne on Nov 20 2018, 1:09 PM.

Details

Summary

P0602R4 makes the special member functions of optional and variant
conditionally trivial based on the types in the optional/variant.
We already implemented that, but the tests were organized as if this
were a non-standard extension. This patch reorganizes the tests in a
way that makes more sense since this is not an extension anymore.

Event Timeline

ldionne created this revision.Nov 20 2018, 1:09 PM
mclow.lists added inline comments.Nov 20 2018, 2:17 PM
libcxx/test/std/utilities/optional/optional.object/optional.object.assign/copy.pass.cpp
56

For future proofing, we never explicitly test for unreleased standard versions .
Instead, we say TEST_STD_VER > 17

libcxx/www/upcoming_meeting.html
53

You don't have to edit this file.

ldionne marked 2 inline comments as done.Nov 20 2018, 2:24 PM
ldionne added inline comments.
libcxx/test/std/utilities/optional/optional.object/optional.object.assign/copy.pass.cpp
56

Ah, sorry, it feels like you've told me before. Eventually I'll remember.

ldionne updated this revision to Diff 174843.Nov 20 2018, 2:24 PM
ldionne marked an inline comment as done.

Address Marshall's comments

mclow.lists accepted this revision.Jan 10 2019, 10:29 AM

Sorry this took me so long.

This revision is now accepted and ready to land.Jan 10 2019, 10:29 AM
This revision was automatically updated to reflect the committed changes.
libcxx/test/std/utilities/optional/optional.object/optional.object.assign/move.pass.cpp