Page MenuHomePhabricator

mpark (Michael Park)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 7 2016, 8:04 PM (225 w, 17 h)

Recent Activity

Oct 27 2020

mpark accepted D90168: [libc++] Re-apply the switch-based std::variant implementation.
Oct 27 2020, 3:44 PM · Restricted Project

Sep 17 2020

mpark abandoned D69132: [libc++][P0784] Marked the default allocator constexpr..
Sep 17 2020, 1:20 PM · Restricted Project
mpark abandoned D69803: [libc++][P0784] Marked allocator_traits constexpr..
Sep 17 2020, 1:20 PM · Restricted Project

Aug 28 2020

mpark requested review of D86827: [libcxx/variant] Implement workaround for GCC bug..
Aug 28 2020, 6:26 PM · Restricted Project

Aug 17 2020

mpark committed rGe0ec7a020649: [libcxx/variant] Correctly propagate return type of the visitor. (authored by mpark).
[libcxx/variant] Correctly propagate return type of the visitor.
Aug 17 2020, 10:55 AM
mpark closed D86006: [libcxx/variant] Correctly propagate return type of the visitor..
Aug 17 2020, 10:55 AM · Restricted Project
mpark updated subscribers of D85420: [libcxx/variant] Introduce `switch`-based mechanism for `std::visit`..

Hi Mehdi,

Aug 17 2020, 10:34 AM · Restricted Project
mpark added a reviewer for D86006: [libcxx/variant] Correctly propagate return type of the visitor.: EricWF.
Aug 17 2020, 10:31 AM · Restricted Project

Aug 14 2020

mpark requested review of D86006: [libcxx/variant] Correctly propagate return type of the visitor..
Aug 14 2020, 4:52 PM · Restricted Project
mpark committed rG02197f7e50b9: [libcxx/variant] Avoided variable name shadowing. (authored by mpark).
[libcxx/variant] Avoided variable name shadowing.
Aug 14 2020, 4:31 PM
mpark committed rGa175a96517c5: [libcxx/variant] Introduce `switch`-based mechanism for `std::visit`. (authored by mpark).
[libcxx/variant] Introduce `switch`-based mechanism for `std::visit`.
Aug 14 2020, 12:56 PM
mpark closed D85420: [libcxx/variant] Introduce `switch`-based mechanism for `std::visit`..
Aug 14 2020, 12:55 PM · Restricted Project
mpark updated the diff for D85420: [libcxx/variant] Introduce `switch`-based mechanism for `std::visit`..

s/std::integral_constant/integral_constant/

Aug 14 2020, 12:24 PM · Restricted Project
mpark updated the diff for D85420: [libcxx/variant] Introduce `switch`-based mechanism for `std::visit`..

Add inline _LIBCPP_INLINE_VISIBILITY to several functions.

Aug 14 2020, 12:19 PM · Restricted Project

Aug 12 2020

mpark added inline comments to D85420: [libcxx/variant] Introduce `switch`-based mechanism for `std::visit`..
Aug 12 2020, 9:27 AM · Restricted Project
mpark updated the summary of D85420: [libcxx/variant] Introduce `switch`-based mechanism for `std::visit`..
Aug 12 2020, 4:18 AM · Restricted Project
mpark updated the summary of D85420: [libcxx/variant] Introduce `switch`-based mechanism for `std::visit`..
Aug 12 2020, 4:18 AM · Restricted Project
mpark updated the diff for D85420: [libcxx/variant] Introduce `switch`-based mechanism for `std::visit`..

Addressed ldionne's comments.

Aug 12 2020, 4:12 AM · Restricted Project

Aug 11 2020

mpark committed rGc6f51377e12b: [libcxx/variant] Add a few benchmarks for `std::visit`. (authored by mpark).
[libcxx/variant] Add a few benchmarks for `std::visit`.
Aug 11 2020, 3:50 PM
mpark closed D85419: [libcxx/variant] Add a few benchmarks for `std::visit`..
Aug 11 2020, 3:50 PM · Restricted Project
mpark added inline comments to D85420: [libcxx/variant] Introduce `switch`-based mechanism for `std::visit`..
Aug 11 2020, 1:54 PM · Restricted Project
mpark added a comment to D85420: [libcxx/variant] Introduce `switch`-based mechanism for `std::visit`..

The improvements are from enabling compilers to inline the invocation by using a switch.
Compilers currently can't seem to inline through function pointers even if it's constexpr.

Aug 11 2020, 12:25 PM · Restricted Project

Aug 10 2020

mpark updated the diff for D85420: [libcxx/variant] Introduce `switch`-based mechanism for `std::visit`..

Use _LIBCPP_CONCAT.

Aug 10 2020, 1:34 AM · Restricted Project
mpark updated the diff for D85420: [libcxx/variant] Introduce `switch`-based mechanism for `std::visit`..

Minor cleanup update.

Aug 10 2020, 1:16 AM · Restricted Project
mpark updated the summary of D85420: [libcxx/variant] Introduce `switch`-based mechanism for `std::visit`..
Aug 10 2020, 12:08 AM · Restricted Project
mpark updated the summary of D85420: [libcxx/variant] Introduce `switch`-based mechanism for `std::visit`..
Aug 10 2020, 12:07 AM · Restricted Project

Aug 9 2020

mpark updated the diff for D85420: [libcxx/variant] Introduce `switch`-based mechanism for `std::visit`..

Used a different switch-based approach.

Aug 9 2020, 11:50 PM · Restricted Project

Aug 7 2020

mpark planned changes to D85420: [libcxx/variant] Introduce `switch`-based mechanism for `std::visit`..
Aug 7 2020, 5:22 AM · Restricted Project

Aug 6 2020

mpark added inline comments to D85420: [libcxx/variant] Introduce `switch`-based mechanism for `std::visit`..
Aug 6 2020, 4:40 AM · Restricted Project
mpark updated the summary of D85420: [libcxx/variant] Introduce `switch`-based mechanism for `std::visit`..
Aug 6 2020, 4:38 AM · Restricted Project
mpark updated the summary of D85420: [libcxx/variant] Introduce `switch`-based mechanism for `std::visit`..
Aug 6 2020, 4:38 AM · Restricted Project
mpark retitled D85419: [libcxx/variant] Add a few benchmarks for `std::visit`. from [libcxx/variant] Added a few benchmarks for `std::visit`. to [libcxx/variant] Add a few benchmarks for `std::visit`..
Aug 6 2020, 3:32 AM · Restricted Project
mpark requested review of D85420: [libcxx/variant] Introduce `switch`-based mechanism for `std::visit`..
Aug 6 2020, 3:31 AM · Restricted Project
mpark requested review of D85419: [libcxx/variant] Add a few benchmarks for `std::visit`..
Aug 6 2020, 3:22 AM · Restricted Project

Jul 8 2020

mpark committed rG6ab3208d779f: Remove the unnecessary `is_nothrow_swappable` condition in `swap`. (authored by mpark).
Remove the unnecessary `is_nothrow_swappable` condition in `swap`.
Jul 8 2020, 10:47 AM
mpark closed D83274: Remove the unnecessary `is_nothrow_swappable` condition in `swap`..
Jul 8 2020, 10:47 AM · Restricted Project

Jul 6 2020

mpark added inline comments to D81954: Remove the try/catch codepath if `swap` is `noexcept`..
Jul 6 2020, 7:12 PM · Restricted Project
Herald added a reviewer for D83274: Remove the unnecessary `is_nothrow_swappable` condition in `swap`.: Restricted Project.
Jul 6 2020, 7:10 PM · Restricted Project

Jun 18 2020

mpark committed rG8fbd6d99a093: [libcxx/variant] Fix build error for when exceptions disabled. (authored by mpark).
[libcxx/variant] Fix build error for when exceptions disabled.
Jun 18 2020, 7:35 AM
mpark closed D81973: [libcxx/variant] Fix build error for when exceptions disabled..
Jun 18 2020, 7:35 AM · Restricted Project

Jun 16 2020

mpark updated the diff for D81973: [libcxx/variant] Fix build error for when exceptions disabled..

Added a comment.

Jun 16 2020, 4:28 PM · Restricted Project
mpark updated the summary of D81973: [libcxx/variant] Fix build error for when exceptions disabled..
Jun 16 2020, 3:23 PM · Restricted Project
mpark created D81973: [libcxx/variant] Fix build error for when exceptions disabled..
Jun 16 2020, 3:23 PM · Restricted Project
mpark committed rGada2a8ea4a9c: Remove the try/catch codepath if `swap` is `noexcept`. (authored by mpark).
Remove the try/catch codepath if `swap` is `noexcept`.
Jun 16 2020, 2:52 PM
mpark closed D81954: Remove the try/catch codepath if `swap` is `noexcept`..
Jun 16 2020, 2:51 PM · Restricted Project
mpark added inline comments to D81954: Remove the try/catch codepath if `swap` is `noexcept`..
Jun 16 2020, 12:05 PM · Restricted Project
mpark added a comment to D81954: Remove the try/catch codepath if `swap` is `noexcept`..

@ldionne I didn't know we had a mechanism to check codegen. Could you point me to an example?

Jun 16 2020, 12:05 PM · Restricted Project
mpark updated the diff for D81954: Remove the try/catch codepath if `swap` is `noexcept`..

Uglify is_noexcept variable.

Jun 16 2020, 12:05 PM · Restricted Project
mpark added inline comments to D81954: Remove the try/catch codepath if `swap` is `noexcept`..
Jun 16 2020, 12:04 PM · Restricted Project
mpark retitled D81954: Remove the try/catch codepath if `swap` is `noexcept`. from Remove the try/catch codepath if swap is noexcept. to Remove the try/catch codepath if `swap` is `noexcept`..
Jun 16 2020, 11:00 AM · Restricted Project
mpark created D81954: Remove the try/catch codepath if `swap` is `noexcept`..
Jun 16 2020, 11:00 AM · Restricted Project

Feb 27 2020

mpark added a reviewer for D74186: Removing *_equality.: EricWF.
Feb 27 2020, 1:30 PM · Restricted Project

Feb 14 2020

mpark added inline comments to D69132: [libc++][P0784] Marked the default allocator constexpr..
Feb 14 2020, 8:41 AM · Restricted Project
mpark added inline comments to D69132: [libc++][P0784] Marked the default allocator constexpr..
Feb 14 2020, 8:41 AM · Restricted Project
mpark updated the diff for D70117: [libc++][P0174] Deprecated/removed parts of default allocator..

Fixed build error.

Feb 14 2020, 12:41 AM · Restricted Project

Feb 13 2020

mpark added inline comments to D70117: [libc++][P0174] Deprecated/removed parts of default allocator..
Feb 13 2020, 5:31 AM · Restricted Project
mpark added inline comments to D70117: [libc++][P0174] Deprecated/removed parts of default allocator..
Feb 13 2020, 5:31 AM · Restricted Project

Nov 12 2019

mpark updated the diff for D69803: [libc++][P0784] Marked allocator_traits constexpr..

Rebased.

Nov 12 2019, 10:43 PM · Restricted Project
mpark updated the diff for D69134: [libc++][P0784] Added construct_at and marked destroy_at/destroy/destroy_n constexpr..

Rebased.

Nov 12 2019, 10:43 PM · Restricted Project
mpark updated the diff for D69132: [libc++][P0784] Marked the default allocator constexpr..

Rebased.

Nov 12 2019, 10:34 PM · Restricted Project
mpark updated the diff for D70117: [libc++][P0174] Deprecated/removed parts of default allocator..

Refined the tests.

Nov 12 2019, 10:25 PM · Restricted Project
mpark updated the diff for D69803: [libc++][P0784] Marked allocator_traits constexpr..
  • Rebased.
  • Fixed tests
  • Addressed @ldionne's comment about passing objects.
Nov 12 2019, 3:38 PM · Restricted Project
mpark updated the diff for D69134: [libc++][P0784] Added construct_at and marked destroy_at/destroy/destroy_n constexpr..

Rebased.

Nov 12 2019, 3:38 PM · Restricted Project
mpark retitled D69132: [libc++][P0784] Marked the default allocator constexpr. from [libc++][P0784] Marked default allocator constexpr. to [libc++][P0784] Marked the default allocator constexpr..
Nov 12 2019, 3:38 PM · Restricted Project
mpark retitled D69132: [libc++][P0784] Marked the default allocator constexpr. from [libc++][P0784] Marked allocator constexpr. to [libc++][P0784] Marked default allocator constexpr..
Nov 12 2019, 3:38 PM · Restricted Project
mpark updated the diff for D69132: [libc++][P0784] Marked the default allocator constexpr..

Marked max_size, construct and destroy constexpr as well.

Nov 12 2019, 3:38 PM · Restricted Project
mpark updated the diff for D70117: [libc++][P0174] Deprecated/removed parts of default allocator..
  • Replaced use of allocator_traits::max_size with implementation of max_size(). This will be replaced to allocator_traits::max_size once allocator::max_size and allocator_traits::max_size are both marked constexpr.
  • Removed deprecated attributes from C++03 codepaths.
  • Moved/added more tests.
Nov 12 2019, 3:38 PM · Restricted Project
mpark updated the diff for D69803: [libc++][P0784] Marked allocator_traits constexpr..

Updated the synopsis of tests.

Nov 12 2019, 4:37 AM · Restricted Project
mpark added inline comments to D69803: [libc++][P0784] Marked allocator_traits constexpr..
Nov 12 2019, 4:37 AM · Restricted Project
mpark updated the diff for D70117: [libc++][P0174] Deprecated/removed parts of default allocator..

Fixed the allocate.depr_in_cxx17.fail.cpp test.

Nov 12 2019, 4:37 AM · Restricted Project
mpark updated the diff for D69134: [libc++][P0784] Added construct_at and marked destroy_at/destroy/destroy_n constexpr..

Rebased.

Nov 12 2019, 4:27 AM · Restricted Project
mpark updated the diff for D70117: [libc++][P0174] Deprecated/removed parts of default allocator..

Added a new test allocate.depr_in_cxx17.fail.cpp.

Nov 12 2019, 4:27 AM · Restricted Project
mpark updated the diff for D69132: [libc++][P0784] Marked the default allocator constexpr..

Rebased on top of D70117.

Nov 12 2019, 4:16 AM · Restricted Project
mpark updated the diff for D70117: [libc++][P0174] Deprecated/removed parts of default allocator..

Fixed the static_cast result out of allocator<const T>.

Nov 12 2019, 4:04 AM · Restricted Project
mpark updated the diff for D70117: [libc++][P0174] Deprecated/removed parts of default allocator..

Updated to use allocator_traits<>::max_size().

Nov 12 2019, 4:04 AM · Restricted Project
mpark created D70117: [libc++][P0174] Deprecated/removed parts of default allocator..
Nov 12 2019, 3:41 AM · Restricted Project

Nov 11 2019

mpark committed rGeb8710cb93a5: [libc++][P0980] Marked member functions move/copy/assign of char_traits… (authored by mpark).
[libc++][P0980] Marked member functions move/copy/assign of char_traits…
Nov 11 2019, 9:55 AM
mpark closed D68840: [libc++][P0980] Marked member functions move/copy/assign of char_traits constexpr..
Nov 11 2019, 9:55 AM · Restricted Project

Nov 9 2019

mpark updated the diff for D68840: [libc++][P0980] Marked member functions move/copy/assign of char_traits constexpr..

Rebased on master.

Nov 9 2019, 1:44 AM · Restricted Project
mpark updated the diff for D68840: [libc++][P0980] Marked member functions move/copy/assign of char_traits constexpr..

Updated char_traits synopsis.

Nov 9 2019, 1:35 AM · Restricted Project

Nov 8 2019

mpark updated the diff for D69134: [libc++][P0784] Added construct_at and marked destroy_at/destroy/destroy_n constexpr..

Fixed the new test.

Nov 8 2019, 7:31 AM · Restricted Project
mpark updated the diff for D69134: [libc++][P0784] Added construct_at and marked destroy_at/destroy/destroy_n constexpr..

Added the test for construct_at onto a pointer to const.

Nov 8 2019, 7:31 AM · Restricted Project
mpark updated the diff for D69134: [libc++][P0784] Added construct_at and marked destroy_at/destroy/destroy_n constexpr..

Updated to be compatible with compilers with partial constexpr dynamic allocation support.

Nov 8 2019, 7:22 AM · Restricted Project
mpark updated the diff for D68840: [libc++][P0980] Marked member functions move/copy/assign of char_traits constexpr..

Rebased

Nov 8 2019, 7:22 AM · Restricted Project
mpark updated the diff for D69132: [libc++][P0784] Marked the default allocator constexpr..

Rebased

Nov 8 2019, 7:22 AM · Restricted Project

Nov 7 2019

mpark updated the diff for D69132: [libc++][P0784] Marked the default allocator constexpr..

Updated to check for __cpp_constexpr_dynamic_alloc.

Nov 7 2019, 10:01 AM · Restricted Project
mpark updated the diff for D68840: [libc++][P0980] Marked member functions move/copy/assign of char_traits constexpr..

Rebased on top of the new is_constant_evaluated aware macro.

Nov 7 2019, 8:55 AM · Restricted Project
mpark abandoned D69939: [libc++] Initialized variables for compilers that do not allow this in constexpr..
Nov 7 2019, 5:24 AM · Restricted Project
mpark created D69940: [libc++] Fixed copy/copy_n/copy_backward for compilers that do not support is_constant_evaluated..
Nov 7 2019, 4:01 AM · Restricted Project
mpark created D69939: [libc++] Initialized variables for compilers that do not allow this in constexpr..
Nov 7 2019, 4:01 AM · Restricted Project

Nov 6 2019

mpark updated the diff for D68840: [libc++][P0980] Marked member functions move/copy/assign of char_traits constexpr..

Rebased on master.

Nov 6 2019, 5:58 AM · Restricted Project
mpark added a comment to D69132: [libc++][P0784] Marked the default allocator constexpr..

I'm planning to add __cpp_lib_constexpr_dynamic_alloc in a later patch, after the rest of P0784.

Nov 6 2019, 1:37 AM · Restricted Project
mpark updated the diff for D69132: [libc++][P0784] Marked the default allocator constexpr..

Removed unnecessary calls to is_constant_evaluated.

Nov 6 2019, 1:28 AM · Restricted Project

Nov 5 2019

mpark updated the diff for D68837: [libc++][P0202] Marked algorithms copy/copy_n/copy_if/copy_backward constexpr..

Added missing "test_macros.h" header include.

Nov 5 2019, 12:55 AM · Restricted Project

Nov 4 2019

mpark created D69803: [libc++][P0784] Marked allocator_traits constexpr..
Nov 4 2019, 6:46 AM · Restricted Project

Oct 17 2019

mpark added inline comments to D68837: [libc++][P0202] Marked algorithms copy/copy_n/copy_if/copy_backward constexpr..
Oct 17 2019, 6:21 PM · Restricted Project
mpark updated the diff for D68837: [libc++][P0202] Marked algorithms copy/copy_n/copy_if/copy_backward constexpr..

Removed unnecessary marking of runtime code path.

Oct 17 2019, 2:57 PM · Restricted Project
mpark created D69134: [libc++][P0784] Added construct_at and marked destroy_at/destroy/destroy_n constexpr..
Oct 17 2019, 1:31 PM · Restricted Project
mpark updated the diff for D69132: [libc++][P0784] Marked the default allocator constexpr..

Fixed allocate.size.fail.cpp test.

Oct 17 2019, 12:54 PM · Restricted Project
mpark created D69132: [libc++][P0784] Marked the default allocator constexpr..
Oct 17 2019, 12:45 PM · Restricted Project