Page MenuHomePhabricator

mpark (Michael Park)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 7 2016, 8:04 PM (174 w, 2 d)

Recent Activity

Tue, Nov 12

mpark updated the diff for D69803: [libc++][P0784] Marked allocator_traits constexpr..

Rebased.

Tue, Nov 12, 10:43 PM · Restricted Project
mpark updated the diff for D69134: [libc++][P0784] Added construct_at and marked destroy_at/destroy/destroy_n constexpr..

Rebased.

Tue, Nov 12, 10:43 PM · Restricted Project
mpark updated the diff for D69132: [libc++][P0784] Marked the default allocator constexpr..

Rebased.

Tue, Nov 12, 10:34 PM · Restricted Project
mpark updated the diff for D70117: [libc++][P0174] Deprecated/removed parts of default allocator..

Refined the tests.

Tue, Nov 12, 10:25 PM · Restricted Project
mpark updated the diff for D69803: [libc++][P0784] Marked allocator_traits constexpr..

WIP.

Tue, Nov 12, 3:38 PM · Restricted Project
mpark updated the diff for D69134: [libc++][P0784] Added construct_at and marked destroy_at/destroy/destroy_n constexpr..

Rebased.

Tue, Nov 12, 3:38 PM · Restricted Project
mpark retitled D69132: [libc++][P0784] Marked the default allocator constexpr. from [libc++][P0784] Marked default allocator constexpr. to [libc++][P0784] Marked the default allocator constexpr..
Tue, Nov 12, 3:38 PM · Restricted Project
mpark retitled D69132: [libc++][P0784] Marked the default allocator constexpr. from [libc++][P0784] Marked allocator constexpr. to [libc++][P0784] Marked default allocator constexpr..
Tue, Nov 12, 3:38 PM · Restricted Project
mpark updated the diff for D69132: [libc++][P0784] Marked the default allocator constexpr..

Marked max_size, construct and destroy constexpr as well.

Tue, Nov 12, 3:38 PM · Restricted Project
mpark updated the diff for D70117: [libc++][P0174] Deprecated/removed parts of default allocator..
  • Replaced use of allocator_traits::max_size with implementation of max_size(). This will be replaced to allocator_traits::max_size once allocator::max_size and allocator_traits::max_size are both marked constexpr.
  • Removed deprecated attributes from C++03 codepaths.
  • Moved/added more tests.
Tue, Nov 12, 3:38 PM · Restricted Project
mpark updated the diff for D69803: [libc++][P0784] Marked allocator_traits constexpr..

Updated the synopsis of tests.

Tue, Nov 12, 4:37 AM · Restricted Project
mpark added inline comments to D69803: [libc++][P0784] Marked allocator_traits constexpr..
Tue, Nov 12, 4:37 AM · Restricted Project
mpark updated the diff for D70117: [libc++][P0174] Deprecated/removed parts of default allocator..

Fixed the allocate.depr_in_cxx17.fail.cpp test.

Tue, Nov 12, 4:37 AM · Restricted Project
mpark updated the diff for D69134: [libc++][P0784] Added construct_at and marked destroy_at/destroy/destroy_n constexpr..

Rebased.

Tue, Nov 12, 4:27 AM · Restricted Project
mpark updated the diff for D70117: [libc++][P0174] Deprecated/removed parts of default allocator..

Added a new test allocate.depr_in_cxx17.fail.cpp.

Tue, Nov 12, 4:27 AM · Restricted Project
mpark updated the diff for D69132: [libc++][P0784] Marked the default allocator constexpr..

Rebased on top of D70117.

Tue, Nov 12, 4:16 AM · Restricted Project
mpark updated the diff for D70117: [libc++][P0174] Deprecated/removed parts of default allocator..

Fixed the static_cast result out of allocator<const T>.

Tue, Nov 12, 4:04 AM · Restricted Project
mpark updated the diff for D70117: [libc++][P0174] Deprecated/removed parts of default allocator..

Updated to use allocator_traits<>::max_size().

Tue, Nov 12, 4:04 AM · Restricted Project
mpark created D70117: [libc++][P0174] Deprecated/removed parts of default allocator..
Tue, Nov 12, 3:41 AM · Restricted Project

Mon, Nov 11

mpark committed rGeb8710cb93a5: [libc++][P0980] Marked member functions move/copy/assign of char_traits… (authored by mpark).
[libc++][P0980] Marked member functions move/copy/assign of char_traits…
Mon, Nov 11, 9:55 AM
mpark closed D68840: [libc++][P0980] Marked member functions move/copy/assign of char_traits constexpr..
Mon, Nov 11, 9:55 AM · Restricted Project

Nov 9 2019

mpark updated the diff for D68840: [libc++][P0980] Marked member functions move/copy/assign of char_traits constexpr..

Rebased on master.

Nov 9 2019, 1:44 AM · Restricted Project
mpark updated the diff for D68840: [libc++][P0980] Marked member functions move/copy/assign of char_traits constexpr..

Updated char_traits synopsis.

Nov 9 2019, 1:35 AM · Restricted Project

Nov 8 2019

mpark updated the diff for D69134: [libc++][P0784] Added construct_at and marked destroy_at/destroy/destroy_n constexpr..

Fixed the new test.

Nov 8 2019, 7:31 AM · Restricted Project
mpark updated the diff for D69134: [libc++][P0784] Added construct_at and marked destroy_at/destroy/destroy_n constexpr..

Added the test for construct_at onto a pointer to const.

Nov 8 2019, 7:31 AM · Restricted Project
mpark updated the diff for D69134: [libc++][P0784] Added construct_at and marked destroy_at/destroy/destroy_n constexpr..

Updated to be compatible with compilers with partial constexpr dynamic allocation support.

Nov 8 2019, 7:22 AM · Restricted Project
mpark updated the diff for D68840: [libc++][P0980] Marked member functions move/copy/assign of char_traits constexpr..

Rebased

Nov 8 2019, 7:22 AM · Restricted Project
mpark updated the diff for D69132: [libc++][P0784] Marked the default allocator constexpr..

Rebased

Nov 8 2019, 7:22 AM · Restricted Project

Nov 7 2019

mpark updated the diff for D69132: [libc++][P0784] Marked the default allocator constexpr..

Updated to check for __cpp_constexpr_dynamic_alloc.

Nov 7 2019, 10:01 AM · Restricted Project
mpark updated the diff for D68840: [libc++][P0980] Marked member functions move/copy/assign of char_traits constexpr..

Rebased on top of the new is_constant_evaluated aware macro.

Nov 7 2019, 8:55 AM · Restricted Project
mpark abandoned D69939: [libc++] Initialized variables for compilers that do not allow this in constexpr..
Nov 7 2019, 5:24 AM · Restricted Project
mpark created D69940: [libc++] Fixed copy/copy_n/copy_backward for compilers that do not support is_constant_evaluated..
Nov 7 2019, 4:01 AM · Restricted Project
mpark created D69939: [libc++] Initialized variables for compilers that do not allow this in constexpr..
Nov 7 2019, 4:01 AM · Restricted Project

Nov 6 2019

mpark updated the diff for D68840: [libc++][P0980] Marked member functions move/copy/assign of char_traits constexpr..

Rebased on master.

Nov 6 2019, 5:58 AM · Restricted Project
mpark added a comment to D69132: [libc++][P0784] Marked the default allocator constexpr..

I'm planning to add __cpp_lib_constexpr_dynamic_alloc in a later patch, after the rest of P0784.

Nov 6 2019, 1:37 AM · Restricted Project
mpark updated the diff for D69132: [libc++][P0784] Marked the default allocator constexpr..

Removed unnecessary calls to is_constant_evaluated.

Nov 6 2019, 1:28 AM · Restricted Project

Nov 5 2019

mpark updated the diff for D68837: [libc++][P0202] Marked algorithms copy/copy_n/copy_if/copy_backward constexpr..

Added missing "test_macros.h" header include.

Nov 5 2019, 12:55 AM · Restricted Project

Nov 4 2019

mpark created D69803: [libc++][P0784] Marked allocator_traits constexpr..
Nov 4 2019, 6:46 AM · Restricted Project

Oct 17 2019

mpark added inline comments to D68837: [libc++][P0202] Marked algorithms copy/copy_n/copy_if/copy_backward constexpr..
Oct 17 2019, 6:21 PM · Restricted Project
mpark updated the diff for D68837: [libc++][P0202] Marked algorithms copy/copy_n/copy_if/copy_backward constexpr..

Removed unnecessary marking of runtime code path.

Oct 17 2019, 2:57 PM · Restricted Project
mpark created D69134: [libc++][P0784] Added construct_at and marked destroy_at/destroy/destroy_n constexpr..
Oct 17 2019, 1:31 PM · Restricted Project
mpark updated the diff for D69132: [libc++][P0784] Marked the default allocator constexpr..

Fixed allocate.size.fail.cpp test.

Oct 17 2019, 12:54 PM · Restricted Project
mpark created D69132: [libc++][P0784] Marked the default allocator constexpr..
Oct 17 2019, 12:45 PM · Restricted Project
mpark updated the diff for D68840: [libc++][P0980] Marked member functions move/copy/assign of char_traits constexpr..

Minor formatting fixes.

Oct 17 2019, 12:45 PM · Restricted Project

Oct 16 2019

mpark added inline comments to D68840: [libc++][P0980] Marked member functions move/copy/assign of char_traits constexpr..
Oct 16 2019, 3:17 PM · Restricted Project
mpark updated the diff for D68840: [libc++][P0980] Marked member functions move/copy/assign of char_traits constexpr..

Elaborated on the constexpr comment.

Oct 16 2019, 3:17 PM · Restricted Project
mpark added inline comments to D68840: [libc++][P0980] Marked member functions move/copy/assign of char_traits constexpr..
Oct 16 2019, 3:08 PM · Restricted Project
mpark updated the diff for D68837: [libc++][P0202] Marked algorithms copy/copy_n/copy_if/copy_backward constexpr..

Renamed the duplicate test function.

Oct 16 2019, 2:57 PM · Restricted Project

Oct 11 2019

mpark updated the diff for D68840: [libc++][P0980] Marked member functions move/copy/assign of char_traits constexpr..

Added helper functions __move_constexpr, __copy_constexpr, and __assign_constexpr.

Oct 11 2019, 2:41 PM · Restricted Project
mpark added inline comments to D68837: [libc++][P0202] Marked algorithms copy/copy_n/copy_if/copy_backward constexpr..
Oct 11 2019, 12:36 PM · Restricted Project
mpark updated the diff for D68837: [libc++][P0202] Marked algorithms copy/copy_n/copy_if/copy_backward constexpr..

Updated the tests to run everything under compile-time and runtime.

Oct 11 2019, 12:23 PM · Restricted Project
mpark updated the diff for D68837: [libc++][P0202] Marked algorithms copy/copy_n/copy_if/copy_backward constexpr..

Fixed the bug around the use of __libcpp_is_constant_evaluated.

Oct 11 2019, 11:46 AM · Restricted Project

Oct 10 2019

mpark created D68840: [libc++][P0980] Marked member functions move/copy/assign of char_traits constexpr..
Oct 10 2019, 3:39 PM · Restricted Project
mpark created D68837: [libc++][P0202] Marked algorithms copy/copy_n/copy_if/copy_backward constexpr..
Oct 10 2019, 3:03 PM · Restricted Project

Jun 5 2019

mpark created D62920: Included `test/support/test_workarounds.h` which actually defines `TEST_WORKAROUND_CONSTEXPR_IMPLIES_NOEXCEPT` for variant tests..
Jun 5 2019, 10:46 AM · Restricted Project
mpark updated the summary of D62920: Included `test/support/test_workarounds.h` which actually defines `TEST_WORKAROUND_CONSTEXPR_IMPLIES_NOEXCEPT` for variant tests..
Jun 5 2019, 10:46 AM · Restricted Project

Nov 18 2017

mpark accepted D40210: [libc++] Shrink variant's index type when possible.
Nov 18 2017, 8:18 PM
mpark added inline comments to D40210: [libc++] Shrink variant's index type when possible.
Nov 18 2017, 7:39 PM

Jun 19 2017

mpark committed rL305668: Add a missing SFINAE condition to the `variant`'s converting constructor..
Add a missing SFINAE condition to the `variant`'s converting constructor.
Jun 19 2017, 1:26 AM
mpark closed D34112: Add a missing SFINAE condition to the `variant`'s converting constructor. by committing rL305668: Add a missing SFINAE condition to the `variant`'s converting constructor..
Jun 19 2017, 1:26 AM

Jun 14 2017

mpark committed rL305373: Mark `__is_inplace_*` tests as UNSUPPORTED in <= C++14..
Mark `__is_inplace_*` tests as UNSUPPORTED in <= C++14.
Jun 14 2017, 12:13 AM

Jun 13 2017

mpark committed rL305370: Add an `__is_inplace_index` metafunction..
Add an `__is_inplace_index` metafunction.
Jun 13 2017, 10:52 PM
mpark closed D34111: Add an `__is_inplace_index` metafunction. by committing rL305370: Add an `__is_inplace_index` metafunction..
Jun 13 2017, 10:52 PM
mpark updated the diff for D34111: Add an `__is_inplace_index` metafunction..

Add more tests.

Jun 13 2017, 10:48 PM
mpark updated the diff for D34111: Add an `__is_inplace_index` metafunction..

Lined up the static_asserts.

Jun 13 2017, 10:36 PM
mpark updated the diff for D34111: Add an `__is_inplace_index` metafunction..

Add tests.

Jun 13 2017, 10:23 PM

Jun 12 2017

mpark added a comment to D34111: Add an `__is_inplace_index` metafunction..

LGTM. Do we need any tests?

Jun 12 2017, 9:37 PM
mpark updated the diff for D34111: Add an `__is_inplace_index` metafunction..

Add __uncvref.

Jun 12 2017, 1:22 PM
mpark added inline comments to D34111: Add an `__is_inplace_index` metafunction..
Jun 12 2017, 1:21 PM
mpark updated the diff for D34112: Add a missing SFINAE condition to the `variant`'s converting constructor..

Add tests.

Jun 12 2017, 12:11 PM
mpark abandoned D34113: Add a test case for the `variant` construction with in-place tags..
Jun 12 2017, 12:10 PM
mpark created D34113: Add a test case for the `variant` construction with in-place tags..
Jun 12 2017, 12:10 PM
mpark updated the summary of D34111: Add an `__is_inplace_index` metafunction..
Jun 12 2017, 12:09 PM
mpark updated the summary of D34112: Add a missing SFINAE condition to the `variant`'s converting constructor..
Jun 12 2017, 12:08 PM
mpark added a child revision for D34111: Add an `__is_inplace_index` metafunction.: D34112: Add a missing SFINAE condition to the `variant`'s converting constructor..
Jun 12 2017, 12:08 PM
mpark created D34112: Add a missing SFINAE condition to the `variant`'s converting constructor..
Jun 12 2017, 12:07 PM
mpark created D34111: Add an `__is_inplace_index` metafunction..
Jun 12 2017, 12:06 PM

Jun 7 2017

mpark committed rL304893: Mark LWG 2904 as complete..
Mark LWG 2904 as complete.
Jun 7 2017, 3:27 AM
mpark committed rL304891: Implement LWG 2904..
Implement LWG 2904.
Jun 7 2017, 3:23 AM
mpark closed D33965: Implement LWG 2904. by committing rL304891: Implement LWG 2904..
Jun 7 2017, 3:23 AM
mpark updated the diff for D33965: Implement LWG 2904..

Rebased.

Jun 7 2017, 3:20 AM

Jun 6 2017

mpark accepted D32671: [libcxx] [test] variant: test coverage for LWG2904 and P0602.
Jun 6 2017, 3:56 PM
mpark updated the summary of D33965: Implement LWG 2904..
Jun 6 2017, 3:55 PM
mpark added a child revision for D32671: [libcxx] [test] variant: test coverage for LWG2904 and P0602: D33965: Implement LWG 2904..
Jun 6 2017, 3:55 PM
mpark created D33965: Implement LWG 2904..
Jun 6 2017, 3:54 PM

May 24 2017

mpark added a comment to D32671: [libcxx] [test] variant: test coverage for LWG2904 and P0602.

Yes, you're right that fine-grained SMF triviality is implemented but LWG 2904 is not yet.
I would love it if you can integrate the currently libcxx tests into std tests!

May 24 2017, 10:41 AM

May 23 2017

mpark added a comment to D32671: [libcxx] [test] variant: test coverage for LWG2904 and P0602.

@CaseyCarter: Do these changes pass with the current version?
Also, have you seen the tests in test/libcxx/utilities/variant/variant.variant?
If yes, do those tests and the ones in this diff overlap at all?
Curious as to how we should merge them.

May 23 2017, 6:03 PM
mpark added a comment to D32515: [libcxx] [test] Changes to accommodate LWG 2904 "Make variant move-assignment more exception safe".

Thanks for the tests! I'll try this out with an implementation shortly.

May 23 2017, 5:53 PM

May 11 2017

mpark committed rL302773: Fix `std::visit` for the zero variants case..
Fix `std::visit` for the zero variants case.
May 11 2017, 12:30 AM
mpark closed D33090: Fix `std::visit` for the zero variants case. by committing rL302773: Fix `std::visit` for the zero variants case..
May 11 2017, 12:30 AM
mpark added a comment to D33090: Fix `std::visit` for the zero variants case..

Yep.

May 11 2017, 12:27 AM
mpark updated the summary of D33090: Fix `std::visit` for the zero variants case..
May 11 2017, 12:25 AM
mpark created D33090: Fix `std::visit` for the zero variants case..
May 11 2017, 12:24 AM

Mar 22 2017

mpark committed rL298581: Worked around GCC bug 56480. Explicit specialization in a different namespace..
Worked around GCC bug 56480. Explicit specialization in a different namespace.
Mar 22 2017, 11:33 PM
mpark closed D31273: Worked around GCC bug 56480. Explicit specialization in a different namespace. by committing rL298581: Worked around GCC bug 56480. Explicit specialization in a different namespace..
Mar 22 2017, 11:33 PM
mpark added a reviewer for D31273: Worked around GCC bug 56480. Explicit specialization in a different namespace.: EricWF.
Mar 22 2017, 5:49 PM
mpark created D31273: Worked around GCC bug 56480. Explicit specialization in a different namespace..
Mar 22 2017, 5:47 PM

Mar 6 2017

mpark committed rL297065: Updated email address in `CREDITS.txt`..
Updated email address in `CREDITS.txt`.
Mar 6 2017, 12:58 PM

Feb 28 2017

mpark committed rL296558: Updated the XFAIL comment in variant tests..
Updated the XFAIL comment in variant tests.
Feb 28 2017, 5:20 PM
mpark closed D30481: Updated the XFAIL comment in variant tests. by committing rL296558: Updated the XFAIL comment in variant tests..
Feb 28 2017, 5:19 PM