Page MenuHomePhabricator

[libcxx] Fix libc++ re-exporting logic when Command Line Tools are not installed

Authored by ldionne on Nov 15 2018, 12:08 PM.



When the Xcode Command Line tools are not installed but CMAKE_OSX_SYSROOT is
set, we would try to re-export symbols from the libc++abi.dylib shipped in
the sysroot, which does not exist. This commit changes the build on OS X to
always re-export symbols from the explicit re-export lists, which doesn't
change depending on what system you're building on, and is therefore much
less flaky.

Diff Detail


Event Timeline

ldionne created this revision.Nov 15 2018, 12:08 PM

I tested this on Mojave and High Sierra with and without developer tools installed, but I would appreciate if reviewers could pull this patch, run ninja check-cxx-abilist and make sure it passes.

check-cxx-abilist passes for me with this applied (Mojave, Xcode 10.1).

check-cxx-abilist passes for me with this applied (Mojave, Xcode 10.1).

Thanks for checking!

This revision was not accepted when it landed; it landed in state Needs Review.Nov 27 2018, 1:02 PM
This revision was automatically updated to reflect the committed changes.