This is an archive of the discontinued LLVM Phabricator instance.

Differential D54572

[WebAssembly] Change type of wake count to unsigned int
ClosedPublic

Authored by aheejin on Nov 15 2018, 2:00 AM.

Details

Reviewers
dschuff
sbc100
Commits
rGad9d68c2b44d: [WebAssembly] Change type of wake count to unsigned int
rC347005: [WebAssembly] Change type of wake count to unsigned int
rL347005: [WebAssembly] Change type of wake count to unsigned int
Summary

We discussed this at the Nov 12th CG meeting, and decided to use the
unsigned semantics for the wake count.
Corresponding spec change:
https://github.com/WebAssembly/threads/pull/110

Diff Detail

Event Timeline

aheejin created this revision.Nov 15 2018, 2:00 AM
Herald added subscribers: cfe-commits, jfb, sunfish and 2 others. · View Herald TranscriptNov 15 2018, 2:00 AM
Harbormaster completed remote builds in B25038: Diff 174169.Nov 15 2018, 2:00 AM
sbc100 accepted this revision.Nov 15 2018, 10:28 AM
This revision is now accepted and ready to land.Nov 15 2018, 10:28 AM
Closed by commit rC347005: [WebAssembly] Change type of wake count to unsigned int (authored by aheejin). · Explain WhyNov 15 2018, 4:51 PM
Closed by commit rL347005: [WebAssembly] Change type of wake count to unsigned int (authored by aheejin). · Explain Why
This revision was automatically updated to reflect the committed changes.
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: llvm-commits. · View Herald TranscriptNov 15 2018, 4:51 PM

Revision Contents

PathSize
include/
clang/
Basic/
2 lines
test/
CodeGen/
2 lines

Diff 174169

include/clang/Basic/BuiltinsWebAssembly.def

Show All 31 Lines
// Exception handling builtins. // Exception handling builtins.
BUILTIN(__builtin_wasm_throw, "vUiv*", "r") BUILTIN(__builtin_wasm_throw, "vUiv*", "r")
BUILTIN(__builtin_wasm_rethrow, "v", "r") BUILTIN(__builtin_wasm_rethrow, "v", "r")
// Atomic wait and notify. // Atomic wait and notify.
BUILTIN(__builtin_wasm_atomic_wait_i32, "ii*iLLi", "n") BUILTIN(__builtin_wasm_atomic_wait_i32, "ii*iLLi", "n")
BUILTIN(__builtin_wasm_atomic_wait_i64, "iLLi*LLiLLi", "n") BUILTIN(__builtin_wasm_atomic_wait_i64, "iLLi*LLiLLi", "n")
BUILTIN(__builtin_wasm_atomic_notify, "Uii*i", "n") BUILTIN(__builtin_wasm_atomic_notify, "Uii*Ui", "n")
// Saturating fp-to-int conversions // Saturating fp-to-int conversions
BUILTIN(__builtin_wasm_trunc_saturate_s_i32_f32, "if", "nc") BUILTIN(__builtin_wasm_trunc_saturate_s_i32_f32, "if", "nc")
BUILTIN(__builtin_wasm_trunc_saturate_u_i32_f32, "if", "nc") BUILTIN(__builtin_wasm_trunc_saturate_u_i32_f32, "if", "nc")
BUILTIN(__builtin_wasm_trunc_saturate_s_i32_f64, "id", "nc") BUILTIN(__builtin_wasm_trunc_saturate_s_i32_f64, "id", "nc")
BUILTIN(__builtin_wasm_trunc_saturate_u_i32_f64, "id", "nc") BUILTIN(__builtin_wasm_trunc_saturate_u_i32_f64, "id", "nc")
BUILTIN(__builtin_wasm_trunc_saturate_s_i64_f32, "LLif", "nc") BUILTIN(__builtin_wasm_trunc_saturate_s_i64_f32, "LLif", "nc")
BUILTIN(__builtin_wasm_trunc_saturate_u_i64_f32, "LLif", "nc") BUILTIN(__builtin_wasm_trunc_saturate_u_i64_f32, "LLif", "nc")
▲ Show 20 Lines • Show All 64 Lines • Show Last 20 Lines

test/CodeGen/builtins-wasm.c

Show First 20 Lines • Show All 71 Lines • ▼ Show 20 Lines
} }
int atomic_wait_i64(long long *addr, long long expected, long long timeout) { int atomic_wait_i64(long long *addr, long long expected, long long timeout) {
return __builtin_wasm_atomic_wait_i64(addr, expected, timeout); return __builtin_wasm_atomic_wait_i64(addr, expected, timeout);
// WEBASSEMBLY32: call i32 @llvm.wasm.atomic.wait.i64(i64* %{{.*}}, i64 %{{.*}}, i64 %{{.*}}) // WEBASSEMBLY32: call i32 @llvm.wasm.atomic.wait.i64(i64* %{{.*}}, i64 %{{.*}}, i64 %{{.*}})
// WEBASSEMBLY64: call i32 @llvm.wasm.atomic.wait.i64(i64* %{{.*}}, i64 %{{.*}}, i64 %{{.*}}) // WEBASSEMBLY64: call i32 @llvm.wasm.atomic.wait.i64(i64* %{{.*}}, i64 %{{.*}}, i64 %{{.*}})
} }
unsigned int atomic_notify(int *addr, int count) { unsigned int atomic_notify(int *addr, unsigned int count) {
return __builtin_wasm_atomic_notify(addr, count); return __builtin_wasm_atomic_notify(addr, count);
// WEBASSEMBLY32: call i32 @llvm.wasm.atomic.notify(i32* %{{.*}}, i32 %{{.*}}) // WEBASSEMBLY32: call i32 @llvm.wasm.atomic.notify(i32* %{{.*}}, i32 %{{.*}})
// WEBASSEMBLY64: call i32 @llvm.wasm.atomic.notify(i32* %{{.*}}, i32 %{{.*}}) // WEBASSEMBLY64: call i32 @llvm.wasm.atomic.notify(i32* %{{.*}}, i32 %{{.*}})
} }
int trunc_saturate_s_i32_f32(float f) { int trunc_saturate_s_i32_f32(float f) {
return __builtin_wasm_trunc_saturate_s_i32_f32(f); return __builtin_wasm_trunc_saturate_s_i32_f32(f);
// WEBASSEMBLY: call i32 @llvm.wasm.trunc.saturate.signed.i32.f32(float %f) // WEBASSEMBLY: call i32 @llvm.wasm.trunc.saturate.signed.i32.f32(float %f)
▲ Show 20 Lines • Show All 346 Lines • Show Last 20 Lines