Remove DBG_LABELs in LiveDebugVariables and generate them in
VirtRegRewriter.
This bug is reported in https://bugs.chromium.org/p/chromium/issues/detail?id=898152
Paths
| Differential D54465
[CodeGen] Fix bugs in LiveDebugVariables when debug labels are generated. ClosedPublic Authored by HsiangKai on Nov 12 2018, 11:21 PM.
Details Summary Remove DBG_LABELs in LiveDebugVariables and generate them in This bug is reported in https://bugs.chromium.org/p/chromium/issues/detail?id=898152
Diff Detail
Event Timeline
Comment Actions This patch doesn't seem to apply. Does it need regenerating? vext01@bencher8:~/source/llvm$ patch -Ep0 < D54465.diff patching file lib/CodeGen/LiveDebugVariables.cpp Hunk #2 FAILED at 340. Hunk #3 succeeded at 352 with fuzz 1 (offset -5 lines). Hunk #4 FAILED at 372. Hunk #5 succeeded at 395 (offset -9 lines). Hunk #6 succeeded at 441 (offset -9 lines). Hunk #7 succeeded at 466 (offset -9 lines). Hunk #8 succeeded at 487 (offset -9 lines). Hunk #9 succeeded at 531 (offset -9 lines). Hunk #10 succeeded at 615 (offset -9 lines). Hunk #11 succeeded at 651 (offset -9 lines). Hunk #12 succeeded at 1291 (offset -7 lines). Hunk #13 succeeded at 1348 (offset -7 lines). 2 out of 13 hunks FAILED -- saving rejects to file lib/CodeGen/LiveDebugVariables.cpp.rej The next patch would create the file test/CodeGen/Generic/live-debug-label.ll, which already exists! Assume -R? [n] Comment Actions
Sorry for that.
Comment Actions This looks good to me, but I don't think I can give an official L-G-T-M. Have you addressed all of the reviewers' comments?
Comment Actions A few more comments.
This revision is now accepted and ready to land.Jan 14 2019, 8:02 AM Closed by commit rL351525: [CodeGen] Fix bugs in LiveDebugVariables when debug labels are generated. (authored by HsiangKai). · Explain WhyJan 17 2019, 11:22 PM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 173814 lib/CodeGen/LiveDebugVariables.cpp
test/CodeGen/Generic/live-debug-label.ll
|
Please don't repeat the function name in the Doxygen comment. I know the other code in this file does this, but that should be fixed, too :-)