Page MenuHomePhabricator

wolfgangp (Wolfgang Pieb)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 17 2014, 5:52 PM (401 w, 1 d)

Recent Activity

Wed, May 25

wolfgangp added inline comments to D125998: [Metadata] Add a resize capability to MDNodes and add a push_back interface to MDNodes..
Wed, May 25, 10:57 PM · Restricted Project, Restricted Project
wolfgangp updated the diff for D125998: [Metadata] Add a resize capability to MDNodes and add a push_back interface to MDNodes..

Addressed review comments.

Wed, May 25, 10:56 PM · Restricted Project, Restricted Project

Mon, May 23

wolfgangp committed rGae9489025f1a: [NFC][Metadata] Define move constructor and move assignment operator for… (authored by wolfgangp).
[NFC][Metadata] Define move constructor and move assignment operator for…
Mon, May 23, 8:15 PM · Restricted Project, Restricted Project
wolfgangp closed D125994: [NFC] Define move and copy constructors and copy assignment operators for MDOperand..
Mon, May 23, 8:15 PM · Restricted Project, Restricted Project
wolfgangp updated the diff for D125994: [NFC] Define move and copy constructors and copy assignment operators for MDOperand..

Added a unit test to make sure the move constructor and the move assignment op of MDOperand adjust tracking info.

Mon, May 23, 2:19 PM · Restricted Project, Restricted Project

Sat, May 21

wolfgangp updated the diff for D125999: [Metadata] Use push_back() to append operands of MDTuples to other MDTuples.

Use a better way to create a distinct node from an existing uniqued one and simplify dealing with AppendUnique module flags.

Sat, May 21, 1:23 PM · Restricted Project, Restricted Project
wolfgangp updated the diff for D125998: [Metadata] Add a resize capability to MDNodes and add a push_back interface to MDNodes..

Use the default constructor for LargeStorageVector followed by a resize instead of the constructor using a numOps parameter. Doing the latter requires the copy constructor for MDOperand.

Sat, May 21, 1:20 PM · Restricted Project, Restricted Project
wolfgangp updated the diff for D125994: [NFC] Define move and copy constructors and copy assignment operators for MDOperand..

Only define the move constructor and move assignment operator. Use retrack() instead of relying on the destructor to untrack the source op.

Sat, May 21, 1:15 PM · Restricted Project, Restricted Project

Thu, May 19

wolfgangp added inline comments to D125994: [NFC] Define move and copy constructors and copy assignment operators for MDOperand..
Thu, May 19, 4:59 PM · Restricted Project, Restricted Project
wolfgangp added inline comments to D125994: [NFC] Define move and copy constructors and copy assignment operators for MDOperand..
Thu, May 19, 2:34 PM · Restricted Project, Restricted Project
wolfgangp added a reviewer for D125999: [Metadata] Use push_back() to append operands of MDTuples to other MDTuples: dexonsmith.

This patch depends on D125998. When appending module flags to the module flags of another module (probably during module linking) we want to append the operands to the destination module's MDTuple instead of creating new ones. This should fix issue 51893.

Thu, May 19, 11:47 AM · Restricted Project, Restricted Project
wolfgangp requested review of D125999: [Metadata] Use push_back() to append operands of MDTuples to other MDTuples.
Thu, May 19, 11:41 AM · Restricted Project, Restricted Project
wolfgangp added a comment to D125998: [Metadata] Add a resize capability to MDNodes and add a push_back interface to MDNodes..

You mentioned that phabricator reviews can be linked. I'm having trouble finding out how.

NM, found it.

Thu, May 19, 11:34 AM · Restricted Project, Restricted Project
wolfgangp requested review of D125998: [Metadata] Add a resize capability to MDNodes and add a push_back interface to MDNodes..
Thu, May 19, 11:33 AM · Restricted Project, Restricted Project
wolfgangp requested review of D125994: [NFC] Define move and copy constructors and copy assignment operators for MDOperand..
Thu, May 19, 11:25 AM · Restricted Project, Restricted Project

Fri, May 13

wolfgangp committed rG2740c1875d1c: [NFC][Metadata] Refactor allocation, initalization and deletion of MDNodes. (authored by wolfgangp).
[NFC][Metadata] Refactor allocation, initalization and deletion of MDNodes.
Fri, May 13, 4:09 PM · Restricted Project, Restricted Project
wolfgangp closed D125489: [Metadata][NFC] Refactor allocation, initialization, and deletion of MDNodes.
Fri, May 13, 4:09 PM · Restricted Project, Restricted Project

Thu, May 12

wolfgangp requested review of D125489: [Metadata][NFC] Refactor allocation, initialization, and deletion of MDNodes.
Thu, May 12, 11:33 AM · Restricted Project, Restricted Project

Tue, May 3

wolfgangp added inline comments to D124548: [Metadata] Add a resize/reserve capability for MDNodes.
Tue, May 3, 11:15 AM · Restricted Project, Restricted Project

Apr 27 2022

wolfgangp requested review of D124548: [Metadata] Add a resize/reserve capability for MDNodes.
Apr 27 2022, 11:49 AM · Restricted Project, Restricted Project

Apr 16 2022

wolfgangp added a comment to D122865: [HLSL][clang][Driver] Support target profile command line option..

Seems to be fine now. Thanks.

Apr 16 2022, 9:36 AM · Restricted Project, Restricted Project

Apr 15 2022

wolfgangp added a comment to D122865: [HLSL][clang][Driver] Support target profile command line option..

Hi, there seems to be a unit test failure, for example here.

Apr 15 2022, 5:39 PM · Restricted Project, Restricted Project

Mar 29 2022

wolfgangp added a comment to D118416: [Metadata] Use temporary MD nodes when appending module flags during module linking.

This is a breakdown of MDNodes by number of operands using a bootstrap and a couple of other internal builds (-g -O2). The second column gives the percentage of MDnodes with the number of operands in the first column.
99.9 percent of all nodes have 15 operands or fewer. Almost half have 2 operands.

Mar 29 2022, 5:08 PM · Restricted Project, Restricted Project

Mar 25 2022

Herald added a project to D118416: [Metadata] Use temporary MD nodes when appending module flags during module linking: Restricted Project.

I'm finally getting around to take a stab at this. One thing in particular is giving me trouble:

Mar 25 2022, 11:34 AM · Restricted Project, Restricted Project

Feb 2 2022

wolfgangp added a comment to D118416: [Metadata] Use temporary MD nodes when appending module flags during module linking.

Thanks for looking into this.

Feb 2 2022, 11:05 AM · Restricted Project, Restricted Project

Jan 27 2022

wolfgangp requested review of D118416: [Metadata] Use temporary MD nodes when appending module flags during module linking.
Jan 27 2022, 4:12 PM · Restricted Project, Restricted Project

Jan 10 2022

wolfgangp committed rGd789ea713372: [Diagnostics] Don't drop a statically set NoWarningAsError flag during option… (authored by wolfgangp).
[Diagnostics] Don't drop a statically set NoWarningAsError flag during option…
Jan 10 2022, 4:39 PM
wolfgangp closed D109981: [Diagnostics] Don't drop a statically set NoWarningAsError flag during option processing.
Jan 10 2022, 4:39 PM · Restricted Project

Dec 14 2021

wolfgangp added a comment to D114558: [ASan] Shared optimized callbacks implementation..

Hi. This patch is causing a couple of test failures on one of our internal bots which is still running Ubuntu 18.04. Do you have any idea what could be causing it? I'm posting the test output:

Dec 14 2021, 6:33 PM · Restricted Project, Restricted Project

Dec 13 2021

wolfgangp added a comment to D109981: [Diagnostics] Don't drop a statically set NoWarningAsError flag during option processing.

ping ...

Dec 13 2021, 9:53 AM · Restricted Project

Oct 12 2021

wolfgangp added a comment to D109981: [Diagnostics] Don't drop a statically set NoWarningAsError flag during option processing.

ping ...

Oct 12 2021, 11:02 AM · Restricted Project

Oct 6 2021

wolfgangp added a comment to D111185: Reland [sanitizer] Support Intel CET.

I'd prefer we don't work around such usage which is unsupported. This is an opportunity for users to migrate to -DLLVM_ENABLE_RUNTIMES=compiler-rt

Oct 6 2021, 4:44 PM · Restricted Project
wolfgangp added a comment to D111185: Reland [sanitizer] Support Intel CET.

This is causing problems with gcc versions that don't have cet.h yet. I think cet.h wasn't added until gcc 8.

Please try this:

Oct 6 2021, 4:34 PM · Restricted Project
wolfgangp added a comment to D111185: Reland [sanitizer] Support Intel CET.

This is causing problems with gcc versions that don't have cet.h yet. I think cet.h wasn't added until gcc 8.

Oct 6 2021, 4:08 PM · Restricted Project
wolfgangp committed rGf53d05135e98: [UBSAN][PS4] For the PS4 target, emit the ud2 ocpode for ubsan traps. (authored by wolfgangp).
[UBSAN][PS4] For the PS4 target, emit the ud2 ocpode for ubsan traps.
Oct 6 2021, 11:50 AM
wolfgangp closed D111172: [PS4 UBSAN] Emit ud2 for ubsantrap for the PS4 target..
Oct 6 2021, 11:49 AM · Restricted Project

Oct 5 2021

wolfgangp requested review of D111172: [PS4 UBSAN] Emit ud2 for ubsantrap for the PS4 target..
Oct 5 2021, 11:42 AM · Restricted Project

Oct 4 2021

wolfgangp added a reviewer for D109981: [Diagnostics] Don't drop a statically set NoWarningAsError flag during option processing: thakis.
Oct 4 2021, 10:45 AM · Restricted Project

Sep 30 2021

wolfgangp added a comment to D110783: [clang] Make crash reproducer work with clang-cl.

Hi, the test you modified Driver/crash-report.cpp is failing on the PS4 bot after your change. Can you take a look?

https://lab.llvm.org/buildbot/#/builders/139/builds/10939

Sep 30 2021, 5:51 PM · Restricted Project

Sep 29 2021

wolfgangp added a comment to D109981: [Diagnostics] Don't drop a statically set NoWarningAsError flag during option processing.

ping ...

Sep 29 2021, 9:42 AM · Restricted Project

Sep 17 2021

wolfgangp requested review of D109981: [Diagnostics] Don't drop a statically set NoWarningAsError flag during option processing.
Sep 17 2021, 10:14 AM · Restricted Project

Aug 10 2021

wolfgangp added inline comments to D107745: tsan: add notion of compressed addresses.
Aug 10 2021, 4:42 PM · Restricted Project
wolfgangp added a comment to D107816: [hwasan] Fix test on x86..

@fmayer Hi Florian!
Looks like the double-free test case is still failing here.

Aug 10 2021, 10:58 AM · Restricted Project

Jul 14 2021

wolfgangp committed rGd1116697be05: [ARM] Fix RELA relocations for 32bit ARM. (authored by wolfgangp).
[ARM] Fix RELA relocations for 32bit ARM.
Jul 14 2021, 2:28 PM
wolfgangp updated the diff for D105214: [ARM] RELA relocations for 32bit ARM ignore the addend..

Addressed the review comments:

  • added an assert that verifies that either the addend or LocData is 0
  • renamed the relocation section into .rela.xxx
  • deleted some unnecessary section properties
Jul 14 2021, 11:35 AM · Restricted Project

Jul 13 2021

wolfgangp added a comment to D105214: [ARM] RELA relocations for 32bit ARM ignore the addend..

Ping. Any comments on this more RISCV-specific approach?

Jul 13 2021, 11:06 AM · Restricted Project

Jul 1 2021

wolfgangp updated the diff for D105214: [ARM] RELA relocations for 32bit ARM ignore the addend..

Ignore LocData for RELA relocations except for RISCV, which uses both LocData and Addend.

Jul 1 2021, 4:21 PM · Restricted Project
wolfgangp added a comment to D105214: [ARM] RELA relocations for 32bit ARM ignore the addend..

I've not seen SHT_RELA used for debug data before and I think all of the other LLVM tools assume SHT_REL. Are you planning to add SHT_RELA support to the other LLVM tools?

Jul 1 2021, 9:42 AM · Restricted Project

Jun 30 2021

wolfgangp requested review of D105214: [ARM] RELA relocations for 32bit ARM ignore the addend..
Jun 30 2021, 11:02 AM · Restricted Project

Jun 29 2021

wolfgangp added inline comments to D105064: [llvm-mca] Fix JSON output.
Jun 29 2021, 11:26 AM · Restricted Project

Jun 28 2021

wolfgangp added inline comments to D105064: [llvm-mca] Fix JSON output.
Jun 28 2021, 3:21 PM · Restricted Project

Jun 10 2021

wolfgangp committed rG5a1589fc6d11: [static initializers] Emit global_ctors and global_dtors in reverse order when . (authored by wolfgangp).
[static initializers] Emit global_ctors and global_dtors in reverse order when .
Jun 10 2021, 4:45 PM
wolfgangp closed D103495: [static initializers] Emit global_ctors and global_dtors in reverse order when .ctors/.dtors are used..
Jun 10 2021, 4:45 PM · Restricted Project
wolfgangp added a comment to D103495: [static initializers] Emit global_ctors and global_dtors in reverse order when .ctors/.dtors are used..

If nobody has any more objections, I'll commit this change, then. Please let me know if you think otherwise.

Jun 10 2021, 11:50 AM · Restricted Project

Jun 9 2021

wolfgangp added a comment to D103495: [static initializers] Emit global_ctors and global_dtors in reverse order when .ctors/.dtors are used..

So, a question for @wolfgangp and @probinson , do we need to make adjustments to the LTO library, or is this OK as is?

Jun 9 2021, 2:51 PM · Restricted Project

Jun 8 2021

wolfgangp added a comment to D103495: [static initializers] Emit global_ctors and global_dtors in reverse order when .ctors/.dtors are used..
Jun 8 2021, 10:13 AM · Restricted Project
wolfgangp updated the diff for D103495: [static initializers] Emit global_ctors and global_dtors in reverse order when .ctors/.dtors are used..

Given the assessment on GlobalOpt, removed the LangRef changes and updated the subject line.

Jun 8 2021, 10:11 AM · Restricted Project

Jun 7 2021

wolfgangp updated the diff for D103495: [static initializers] Emit global_ctors and global_dtors in reverse order when .ctors/.dtors are used..

Following the suggestion to define an order of initialization for the entries in llvm.global_ctors and llvm.global_dtors this is mainly a documentation change, as well as a simple reversed emission of global_ctors/dtors entries when InitArray is not used.
3 test cases are affected, 2 of them just by a reversed order of emission of priority-suffixed sections. I added a couple of entries to the third test case to verify in-order emission of entries with equal priority.

Jun 7 2021, 11:19 AM · Restricted Project

Jun 2 2021

wolfgangp added a comment to D103495: [static initializers] Emit global_ctors and global_dtors in reverse order when .ctors/.dtors are used..

+@rsmith @hans @aeubanks

specifically when init_array is not used

Can you elaborate on why that is? Here's what I remember, and what I guess is happening. ELF has two initializer schemes: .init_array and .ctors. They are essentially equivalent, they are both arrays of function pointers, but one is called in reverse order and the other is called in forward order. The compiler knows which scheme is in use and it is controlled by -fuse-init-array.

Jun 2 2021, 3:26 PM · Restricted Project

Jun 1 2021

wolfgangp requested review of D103495: [static initializers] Emit global_ctors and global_dtors in reverse order when .ctors/.dtors are used..
Jun 1 2021, 4:55 PM · Restricted Project

Apr 29 2021

wolfgangp added a comment to D98300: [TLS] Initialization functions of dynamic TLS variables cannot be in a comdat (fix for PR48030).

ping...

Apr 29 2021, 10:47 AM

Mar 25 2021

wolfgangp added a comment to D98300: [TLS] Initialization functions of dynamic TLS variables cannot be in a comdat (fix for PR48030).

ping ...

Mar 25 2021, 8:58 AM

Mar 10 2021

wolfgangp removed a reviewer for D98300: [TLS] Initialization functions of dynamic TLS variables cannot be in a comdat (fix for PR48030): cfe-commits.
Mar 10 2021, 3:10 PM

Mar 9 2021

wolfgangp requested review of D98300: [TLS] Initialization functions of dynamic TLS variables cannot be in a comdat (fix for PR48030).
Mar 9 2021, 3:27 PM

Feb 16 2021

wolfgangp added a comment to D67429: Improve code generation for thread_local variables:.

Ping. Just wondering if there are any new insights on the issue reported in PR48030.

Feb 16 2021, 10:03 AM · Restricted Project, Restricted Project

Jan 25 2021

wolfgangp committed rG231a82a150b3: [X86] Correct some cross references in avxintrin.h. (authored by wolfgangp).
[X86] Correct some cross references in avxintrin.h.
Jan 25 2021, 6:50 PM
wolfgangp committed rG350395d82fdd: [x86] Fix trivial typo in emmintrin.h (authored by wolfgangp).
[x86] Fix trivial typo in emmintrin.h
Jan 25 2021, 5:28 PM

Jan 22 2021

wolfgangp committed rG7143b6301752: [llvm-mca] Adding local lit config file for X86 targets (authored by wolfgangp).
[llvm-mca] Adding local lit config file for X86 targets
Jan 22 2021, 9:54 AM

Jan 21 2021

wolfgangp added a comment to D86644: [llvm-mca] Initial implementation of output serialization using JSON.

FYI I'm seeing clang diagnostic errors, I think from this commit:

Should be fixed now.

I'm still seeing some. Looks like your fix didn't get all of them:

Jan 21 2021, 5:35 PM · Restricted Project
wolfgangp committed rGc6e8f81410a2: [llvm-mca] Addressing build failures due to missing override specifiers (authored by wolfgangp).
[llvm-mca] Addressing build failures due to missing override specifiers
Jan 21 2021, 5:34 PM
wolfgangp added a comment to rGd38be2ba0e4e: [llvm-mca] Initial implementation of serialization using JSON. The views.

Hi. It seems this commit is causing this failure on our aarch64 bulder (https://luci-milo.appspot.com/p/fuchsia/builders/ci/clang-linux-arm64/b8857452110716658368):

Jan 21 2021, 4:31 PM
wolfgangp committed rG020c00b5d3d4: [llvm-mca] Test case was missing a triple. (authored by wolfgangp).
[llvm-mca] Test case was missing a triple.
Jan 21 2021, 4:26 PM
wolfgangp added a comment to D86644: [llvm-mca] Initial implementation of output serialization using JSON.

FYI I'm seeing clang diagnostic errors, I think from this commit:

Jan 21 2021, 3:46 PM · Restricted Project
wolfgangp committed rG04af1ca2e908: [llvm-mca] Forgot a couple of override specifiers. (authored by wolfgangp).
[llvm-mca] Forgot a couple of override specifiers.
Jan 21 2021, 3:46 PM
wolfgangp closed D86644: [llvm-mca] Initial implementation of output serialization using JSON.
Jan 21 2021, 3:46 PM · Restricted Project
wolfgangp committed rGd38be2ba0e4e: [llvm-mca] Initial implementation of serialization using JSON. The views (authored by wolfgangp).
[llvm-mca] Initial implementation of serialization using JSON. The views
Jan 21 2021, 3:16 PM
wolfgangp updated the diff for D86644: [llvm-mca] Initial implementation of output serialization using JSON.

Sorry about the missing files. Some hiccup while generating the diff.

Jan 21 2021, 11:37 AM · Restricted Project

Jan 20 2021

wolfgangp updated the diff for D86644: [llvm-mca] Initial implementation of output serialization using JSON.

Based on Andrea's request to use an OutputKind rather than overriding the printView method in a separate class for JSON output

Jan 20 2021, 6:12 PM · Restricted Project

Jan 15 2021

wolfgangp updated the diff for D86644: [llvm-mca] Initial implementation of output serialization using JSON.

This change is trying to use a more streamlined interface based on Andrea's feedback. I removed the printJSON method from the PipelinePrinter and the singleton object that was used to list the instructions.
Instead, each implemented view now has a <ViewName>JSON derived class that overrides the printView method. When JSON output is requested, objects of these class types are added as views. This leaves the PipelinePrinter largely unchanged.

Jan 15 2021, 5:30 PM · Restricted Project

Dec 17 2020

wolfgangp added inline comments to D86644: [llvm-mca] Initial implementation of output serialization using JSON.
Dec 17 2020, 3:33 AM · Restricted Project
wolfgangp updated the diff for D86644: [llvm-mca] Initial implementation of output serialization using JSON.

Apologies for the long delay, I'm finally ready to resume work on this feature. The update does the following:

Dec 17 2020, 3:30 AM · Restricted Project

Nov 19 2020

wolfgangp added a comment to D91733: [compiler-rt] [builtins] Use _Float16 on extendhfsf2, truncdfhf2 __truncsfhf2 if available.

Isn't COMPILER_RT_HAS_FLOAT16 generated using the host compiler? If so, using the same flag for a compiler_rt test could fail if the host compiler supports f16 and the target compiler does not.

Nov 19 2020, 5:52 PM · Restricted Project

Nov 18 2020

wolfgangp added a reverting change for rG16eb853ffdd1: [tsan] Add pthread_cond_clockwait interceptor: rG87369c626114: Revert "[tsan] Add pthread_cond_clockwait interceptor".
Nov 18 2020, 11:59 AM
wolfgangp committed rG87369c626114: Revert "[tsan] Add pthread_cond_clockwait interceptor" (authored by wolfgangp).
Revert "[tsan] Add pthread_cond_clockwait interceptor"
Nov 18 2020, 11:59 AM
wolfgangp added a reverting change for D91684: [tsan] Add pthread_cond_clockwait interceptor: rG87369c626114: Revert "[tsan] Add pthread_cond_clockwait interceptor".
Nov 18 2020, 11:59 AM · Restricted Project
wolfgangp added a comment to D91684: [tsan] Add pthread_cond_clockwait interceptor.

This seems to fail on some buildbots: e.g. here

Nov 18 2020, 9:47 AM · Restricted Project

Nov 13 2020

wolfgangp added a comment to D89755: [fuzzer] Add Windows Visual C++ exception intercept.

The test seems to fail on some Linux buildbots, see here. Please review.

Nov 13 2020, 1:58 PM · Restricted Project

Oct 15 2020

wolfgangp added a comment to D86644: [llvm-mca] Initial implementation of output serialization using JSON.

Hey Wolfgang,
are you still looking at this patch? Do you have any updates?

Oct 15 2020, 3:40 PM · Restricted Project

Sep 16 2020

wolfgangp added a comment to D86360: Add new hidden option -print-changed which only reports changes to IR.

This commit seems to cause a test failure on some bots, e.g. here.

Sep 16 2020, 4:10 PM · Restricted Project

Aug 26 2020

wolfgangp added a comment to D86644: [llvm-mca] Initial implementation of output serialization using JSON.

Can it simply be autogenerated, without omitting details?

Aug 26 2020, 1:55 PM · Restricted Project
wolfgangp requested review of D86644: [llvm-mca] Initial implementation of output serialization using JSON.
Aug 26 2020, 10:37 AM · Restricted Project

Aug 25 2020

wolfgangp committed rGe02920fe5576: [llvm-mca][NFC] Refactor handling of views that examine individual instructions, (authored by wolfgangp).
[llvm-mca][NFC] Refactor handling of views that examine individual instructions,
Aug 25 2020, 12:13 PM

Aug 24 2020

wolfgangp updated the diff for D86390: [llvm-mca][NFC] Refactor instruction printing.

After some consultation with @andreadb this is some more extensive refactoring:
We create a new base class InstructionView that is meant for views that deal with individual instructions (e.g. print them). The 3 members MCIP (the instruction printer), STI (subtarget info) and Source (the array of machine instructions) live there and can be accessed via getters (they could be made protected as well). Printing the instructions is effected by using a string member in the new base class (which must be mutable along with its associated stream).

Aug 24 2020, 5:24 PM · Restricted Project
wolfgangp updated the diff for D86390: [llvm-mca][NFC] Refactor instruction printing.

Here is another proposal: We're using statics for the Instruction string and the stream to write it and return a reference to it.
The users all immediately write the string to a different stream. This should have even fewer allocations than the original code.

Aug 24 2020, 10:42 AM · Restricted Project

Aug 21 2020

wolfgangp requested review of D86390: [llvm-mca][NFC] Refactor instruction printing.
Aug 21 2020, 7:26 PM · Restricted Project
wolfgangp committed rGcf6adecd6a87: [llvm-mca][NFC] Refactor views to separate data collection from printing. (authored by wolfgangp).
[llvm-mca][NFC] Refactor views to separate data collection from printing.
Aug 21 2020, 11:28 AM
wolfgangp updated the diff for D86177: [llvm-mca][NFC] Separate calculation of display data from its display in the summary and instruction info views.

Addressed review comment:

  • using enumerate() instead of an explicit index variable
Aug 21 2020, 8:56 AM · Restricted Project

Aug 19 2020

wolfgangp added a comment to D86177: [llvm-mca][NFC] Separate calculation of display data from its display in the summary and instruction info views.

Nice!

Thank you Andrea!

I agree with Roman in that we should not guarantee stability of data and/or structure.
Also, changes to the output structure should always be advertised (for example, by adding a line in the release notes), so that people are always aware of it.

Aug 19 2020, 1:59 PM · Restricted Project
wolfgangp updated the diff for D86177: [llvm-mca][NFC] Separate calculation of display data from its display in the summary and instruction info views.

Addressed review comments:

  • Using MutableArrayRef
  • Using range-based for loops with zip
  • Using default initializers with InstructionInfoViewData
Aug 19 2020, 1:51 PM · Restricted Project

Aug 18 2020

wolfgangp requested review of D86177: [llvm-mca][NFC] Separate calculation of display data from its display in the summary and instruction info views.
Aug 18 2020, 4:08 PM · Restricted Project