Page MenuHomePhabricator

wolfgangp (Wolfgang Pieb)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 17 2014, 5:52 PM (314 w, 52 m)

Recent Activity

Wed, Sep 16

wolfgangp added a comment to D86360: Add new hidden option -print-changed which only reports changes to IR.

This commit seems to cause a test failure on some bots, e.g. here.

Wed, Sep 16, 4:10 PM · Restricted Project

Wed, Aug 26

wolfgangp added a comment to D86644: [llvm-mca] Initial implementation of output serialization using JSON.

Can it simply be autogenerated, without omitting details?

Wed, Aug 26, 1:55 PM · Restricted Project
wolfgangp requested review of D86644: [llvm-mca] Initial implementation of output serialization using JSON.
Wed, Aug 26, 10:37 AM · Restricted Project

Tue, Aug 25

wolfgangp committed rGe02920fe5576: [llvm-mca][NFC] Refactor handling of views that examine individual instructions, (authored by wolfgangp).
[llvm-mca][NFC] Refactor handling of views that examine individual instructions,
Tue, Aug 25, 12:13 PM

Aug 24 2020

wolfgangp updated the diff for D86390: [llvm-mca][NFC] Refactor instruction printing.

After some consultation with @andreadb this is some more extensive refactoring:
We create a new base class InstructionView that is meant for views that deal with individual instructions (e.g. print them). The 3 members MCIP (the instruction printer), STI (subtarget info) and Source (the array of machine instructions) live there and can be accessed via getters (they could be made protected as well). Printing the instructions is effected by using a string member in the new base class (which must be mutable along with its associated stream).

Aug 24 2020, 5:24 PM · Restricted Project
wolfgangp updated the diff for D86390: [llvm-mca][NFC] Refactor instruction printing.

Here is another proposal: We're using statics for the Instruction string and the stream to write it and return a reference to it.
The users all immediately write the string to a different stream. This should have even fewer allocations than the original code.

Aug 24 2020, 10:42 AM · Restricted Project

Aug 21 2020

wolfgangp requested review of D86390: [llvm-mca][NFC] Refactor instruction printing.
Aug 21 2020, 7:26 PM · Restricted Project
wolfgangp committed rGcf6adecd6a87: [llvm-mca][NFC] Refactor views to separate data collection from printing. (authored by wolfgangp).
[llvm-mca][NFC] Refactor views to separate data collection from printing.
Aug 21 2020, 11:28 AM
wolfgangp updated the diff for D86177: [llvm-mca][NFC] Separate calculation of display data from its display in the summary and instruction info views.

Addressed review comment:

  • using enumerate() instead of an explicit index variable
Aug 21 2020, 8:56 AM · Restricted Project

Aug 19 2020

wolfgangp added a comment to D86177: [llvm-mca][NFC] Separate calculation of display data from its display in the summary and instruction info views.

Nice!

Thank you Andrea!

I agree with Roman in that we should not guarantee stability of data and/or structure.
Also, changes to the output structure should always be advertised (for example, by adding a line in the release notes), so that people are always aware of it.

Aug 19 2020, 1:59 PM · Restricted Project
wolfgangp updated the diff for D86177: [llvm-mca][NFC] Separate calculation of display data from its display in the summary and instruction info views.

Addressed review comments:

  • Using MutableArrayRef
  • Using range-based for loops with zip
  • Using default initializers with InstructionInfoViewData
Aug 19 2020, 1:51 PM · Restricted Project

Aug 18 2020

wolfgangp requested review of D86177: [llvm-mca][NFC] Separate calculation of display data from its display in the summary and instruction info views.
Aug 18 2020, 4:08 PM · Restricted Project

Jul 30 2020

wolfgangp committed rG9f0225894254: Make a test case more flexible on Windows wrt the number of backslashes. (authored by wolfgangp).
Make a test case more flexible on Windows wrt the number of backslashes.
Jul 30 2020, 8:39 PM

Jul 6 2020

wolfgangp committed rG129387497e58: Correct 3 spelling errors in headers and doc strings. (authored by wolfgangp).
Correct 3 spelling errors in headers and doc strings.
Jul 6 2020, 5:28 PM

Jun 9 2020

wolfgangp added a comment to D68620: DebugInfo: Use base address selection entries for debug_loc.

It looks like this caused a very large increase in binary size (627M->686M). Is that expected/has anyone else observed this?

sorry I didn't see this (somehow ended up muting this thread) - which binary built with what flags? could you run bloaty or otherwise compare the objects before/after. I'd expect some growth in linked executable size of a non-split, optimized debug build, but that seems a bit more than I'd expect/seems to be observed elsewhere so far as I know.

Jun 9 2020, 5:09 PM · Restricted Project

Jun 1 2020

wolfgangp added a comment to D80293: [clangd] Run PreambleThread in async mode behind a flag.

Shortly after this patch went in, we started to see intermittent failures with the unittest TUSchedulerTests.ManyUpdates. The build server (Windows) we're running it on is quite powerful and our own hand-run tests only take about 400 ms, so we don't really understand what could be happening. Any help would be appreciated.

Jun 1 2020, 3:43 PM · Restricted Project

Apr 24 2020

wolfgangp added inline comments to D78555: [DebugInfo][DWARF64] Fix dumping pre-standard .debug_str_offsets.dwo sections..
Apr 24 2020, 10:49 AM · debug-info, Restricted Project

Apr 23 2020

wolfgangp added a comment to D78555: [DebugInfo][DWARF64] Fix dumping pre-standard .debug_str_offsets.dwo sections..

LGTM, with a slight caveat regarding reporting an error for degenerate stubs of string offset sections.

Apr 23 2020, 11:53 AM · debug-info, Restricted Project

Mar 25 2020

wolfgangp committed rG93f7743851b7: Fixing a sanitizer lint problem that was breaking some builds. (authored by wolfgangp).
Fixing a sanitizer lint problem that was breaking some builds.
Mar 25 2020, 6:58 PM
wolfgangp added inline comments to D76073: [compiler-rt][tsan] Fix: Leak of ThreadSignalContext memory mapping when destroying fibers..
Mar 25 2020, 6:58 PM · Restricted Project, Restricted Project

Nov 18 2019

wolfgangp committed rGf805c60a0933: Revert "[clangd] Implement rename by using SelectionTree and… (authored by wolfgangp).
Revert "[clangd] Implement rename by using SelectionTree and…
Nov 18 2019, 3:50 PM
wolfgangp added a reverting change for rG4f80fc2491cc: [clangd] Implement rename by using SelectionTree and findExplicitReferences.: rGf805c60a0933: Revert "[clangd] Implement rename by using SelectionTree and….
Nov 18 2019, 3:50 PM

Nov 15 2019

wolfgangp added a comment to D70267: [X86][SSE] Simplify extract(shuffle(load())) handling (PR43971).

I'm unfortunately still getting a loop in DAGcombiner with this one (llc -mattr=+avx on linux). If you make the 1.000 in the select instr into 0.000 it finishes.

define float @test(<8 x float> *%a0) {
entry:
  %0 = load <8 x float>, <8 x float>* %a0, align 32
  %vecext = extractelement <8 x float> %0, i32 1
  %cmp = fcmp oeq float %vecext, 0.000000e+00
  %cond = select i1 %cmp, float 1.000000e+00, float %vecext
  ret float %cond
}
Nov 15 2019, 4:35 PM · Restricted Project

Nov 14 2019

wolfgangp updated subscribers of D70267: [X86][SSE] Simplify extract(shuffle(load())) handling (PR43971).

I applied your patch to ToT, but now I'm seeing a loop with the following IR (on linux). Seems still stuck in DAGCombine.

Nov 14 2019, 6:00 PM · Restricted Project

Sep 26 2019

wolfgangp added a comment to D67998: [llvm-readobj/llvm-readelf]: Dump stack-size entry for all function symbols that have a particular value (fixes PR43245).

Yes, good observation. There is also the question what to do if the sizes of 2 different entries with the same address don't match. This should probably elicit a warning.

<snip>

  1. Display the first entry size, for each symbol. This is probably the simplest.

For some reason, I didn't see your response until I had posted my updated. I basically implemented number 3.

Sep 26 2019, 4:39 PM
wolfgangp updated the diff for D67998: [llvm-readobj/llvm-readelf]: Dump stack-size entry for all function symbols that have a particular value (fixes PR43245).
  1. Rebased with the latest upstream changes.
  2. Addressed review comments as follows:
    • Keeping track of stack sizes already dumped so that duplicate entries only are printed once.
    • Issue a warning when a duplicate entry with a different stack size is encountered.
    • Simplified code by collapsing some warning code into a lambda.
    • added the appropriate test cases for the changed functionality and added one for STT_NOTYPE.
    • added an early return in a case where no valid symbol is found.
Sep 26 2019, 1:08 PM

Sep 25 2019

wolfgangp added a comment to D67998: [llvm-readobj/llvm-readelf]: Dump stack-size entry for all function symbols that have a particular value (fixes PR43245).

One issue that just occurred to me, is what happens if you still have the stack size entry in this case? Something like:

<snip>

I think this is undesirable. Perhaps you need to track whether a stack size entry for a given address has been printed yet, and skip it if it has?

Sep 25 2019, 11:00 AM

Sep 24 2019

wolfgangp created D67998: [llvm-readobj/llvm-readelf]: Dump stack-size entry for all function symbols that have a particular value (fixes PR43245).
Sep 24 2019, 5:15 PM

Sep 23 2019

wolfgangp committed rL372670: Request commit access for wolfgangp.
Request commit access for wolfgangp
Sep 23 2019, 4:37 PM

Aug 7 2019

wolfgangp committed rGab751a7c8b9b: [llvm-strip] Support --strip-sections (authored by wolfgangp).
[llvm-strip] Support --strip-sections
Aug 7 2019, 5:36 PM
wolfgangp committed rL368241: [llvm-strip] Support --strip-sections.
[llvm-strip] Support --strip-sections
Aug 7 2019, 5:34 PM
wolfgangp closed D65787: [llvm-strip] Support --strip-sections with the llvm-strip command..
Aug 7 2019, 5:34 PM · Restricted Project
wolfgangp updated the diff for D65787: [llvm-strip] Support --strip-sections with the llvm-strip command..

Addressed review comments:

Aug 7 2019, 10:45 AM · Restricted Project
wolfgangp updated the summary of D65787: [llvm-strip] Support --strip-sections with the llvm-strip command..
Aug 7 2019, 10:39 AM · Restricted Project
wolfgangp added a comment to D65787: [llvm-strip] Support --strip-sections with the llvm-strip command..

This sentence in the description:

The reasons for this are unclear, so this patch adds the option to llvm-strip.

We do not add options merely for "unclear" reasons. It is because the option is a good fit for llvm-strip.

Aug 7 2019, 10:28 AM · Restricted Project

Aug 6 2019

wolfgangp added a comment to D65787: [llvm-strip] Support --strip-sections with the llvm-strip command..

I'm a bit unclear on what this means:

Aug 6 2019, 10:59 AM · Restricted Project

Aug 5 2019

wolfgangp created D65787: [llvm-strip] Support --strip-sections with the llvm-strip command..
Aug 5 2019, 6:19 PM · Restricted Project
wolfgangp committed rGc71c62992656: [llvm-readelf] Support dumping of stack sizes sections with readelf --stack… (authored by wolfgangp).
[llvm-readelf] Support dumping of stack sizes sections with readelf --stack…
Aug 5 2019, 3:47 PM
wolfgangp committed rL367942: [llvm-readelf] Support dumping of stack sizes sections with readelf --stack….
[llvm-readelf] Support dumping of stack sizes sections with readelf --stack…
Aug 5 2019, 3:46 PM
wolfgangp closed D65313: [llvm-readelf] Dump the stack sizes sections with --stack-sizes.
Aug 5 2019, 3:46 PM · Restricted Project

Aug 2 2019

wolfgangp added inline comments to D65313: [llvm-readelf] Dump the stack sizes sections with --stack-sizes.
Aug 2 2019, 11:55 AM · Restricted Project
wolfgangp updated the diff for D65313: [llvm-readelf] Dump the stack sizes sections with --stack-sizes.

Addressed review comments:

Aug 2 2019, 11:55 AM · Restricted Project

Aug 1 2019

wolfgangp added a comment to D65313: [llvm-readelf] Dump the stack sizes sections with --stack-sizes.

Left the question about whether --stack-sizes should be include in --all open. This is still a discussion point.

Do you have a discussion going on somewhere you can link to?

Aug 1 2019, 5:48 PM · Restricted Project

Jul 31 2019

wolfgangp updated the diff for D65313: [llvm-readelf] Dump the stack sizes sections with --stack-sizes.

Addressed review comments:

  • renamed one of the printStackSize() functions.
  • removed superfluous check for nonrelocatable object
  • Used SectionRef::getName() instead of the explicit sequence to extract a section name.
  • Fixed the calls to the DataExtractor() constructor to use Obj->isLittleEndian()
  • Added some comments to explain the error handling policy.
  • Moved a SectionName variable definition closer to the use point.
Jul 31 2019, 3:39 PM · Restricted Project

Jul 29 2019

wolfgangp added inline comments to D65313: [llvm-readelf] Dump the stack sizes sections with --stack-sizes.
Jul 29 2019, 12:41 PM · Restricted Project
wolfgangp updated the diff for D65313: [llvm-readelf] Dump the stack sizes sections with --stack-sizes.
  • Undertook some refactoring of the change with the following motivation: The printStackSize* methods do mostly extracting and validating, printing the output is only a minor part. Yet they were methods of the GNUStyle class, which would have made it more difficult to implement LLVM style dumping. So I moved them mostly into the base class (DumpStyle), and delegated the printing mostly to a new method printStackSizeEntry(), which is style specific.
  • Addressed the formatting comments
  • Added 2 test cases (demangling and verifiying the 'not implemented' message we get from llvm-readobj.
  • Explained the rationale using consumeError().
Jul 29 2019, 12:41 PM · Restricted Project

Jul 25 2019

wolfgangp created D65313: [llvm-readelf] Dump the stack sizes sections with --stack-sizes.
Jul 25 2019, 6:43 PM · Restricted Project

Jun 10 2019

wolfgangp committed rG54cbae1e8d5b: [ELF][llvm-objdump] Treat dynamic tag values as virtual addresses instead of… (authored by wolfgangp).
[ELF][llvm-objdump] Treat dynamic tag values as virtual addresses instead of…
Jun 10 2019, 10:48 AM
wolfgangp committed rL362969: [ELF][llvm-objdump] Treat dynamic tag values as virtual addresses instead of….
[ELF][llvm-objdump] Treat dynamic tag values as virtual addresses instead of…
Jun 10 2019, 10:47 AM
wolfgangp closed D62972: [ELF] Treat dynamic tag values as virtual addresses instead of offsets.
Jun 10 2019, 10:47 AM · Restricted Project

Jun 7 2019

wolfgangp updated the diff for D62972: [ELF] Treat dynamic tag values as virtual addresses instead of offsets.

Addressed review comments as suggested.

Jun 7 2019, 11:05 AM · Restricted Project

Jun 6 2019

wolfgangp created D62972: [ELF] Treat dynamic tag values as virtual addresses instead of offsets.
Jun 6 2019, 12:12 PM · Restricted Project

May 22 2019

wolfgangp added inline comments to D62196: [LiveDebugValues] Close range for previous variable's location when deducing new variable's location.
May 22 2019, 10:05 AM · Restricted Project, debug-info

May 14 2019

wolfgangp added inline comments to D61890: [LiveDebugValues] End variable's range with multiple locations at block entry.
May 14 2019, 6:25 PM · debug-info

Apr 19 2019

wolfgangp added a comment to D60913: [GVN+LICM] Use line 0 locations for better crash attribution.

LGTM

Apr 19 2019, 3:04 PM · Restricted Project
wolfgangp added a comment to D28390: [DWARF] LICM should null out the debug loc of hoisted loop invariant instructions.

@danielcdh @wolfgangp -- Would switching to line 0 locations for hoisted instructions have an adverse effect on Sample PGO?

Apr 19 2019, 10:44 AM · Restricted Project

Apr 15 2019

wolfgangp committed rG4fe42214e242: [DEBUGINFO] Prevent Instcombine from dropping debuginfo when removing zexts (authored by wolfgangp).
[DEBUGINFO] Prevent Instcombine from dropping debuginfo when removing zexts
Apr 15 2019, 10:40 AM
wolfgangp committed rL358431: [DEBUGINFO] Prevent Instcombine from dropping debuginfo when removing zexts.
[DEBUGINFO] Prevent Instcombine from dropping debuginfo when removing zexts
Apr 15 2019, 10:40 AM
wolfgangp closed D60641: [DebugInfo@O2] Prevent Instcombine from dropping debug info when removing zexts (fixes PR41475).
Apr 15 2019, 10:40 AM · Restricted Project

Apr 12 2019

wolfgangp created D60641: [DebugInfo@O2] Prevent Instcombine from dropping debug info when removing zexts (fixes PR41475).
Apr 12 2019, 3:41 PM · Restricted Project

Feb 21 2019

wolfgangp added a comment to D58238: [DebugInfo] MachineSink: Insert undef DBG_VALUEs when sinking instructions, try to forward copies.

So this basically prevents the debugger from displaying an inconsistent program state when some of the sideeffects from a line preceding its current stopping point have not been completed yet. Makes sense to me. One minor concern: If the sunk instruction does not get sunk past the next source line, we may create some unneeded location list entries, e.g.:

Feb 21 2019, 3:39 PM · Restricted Project

Feb 11 2019

wolfgangp added inline comments to D58042: [LiveDebugValues] Emit parameter's entry value.
Feb 11 2019, 6:16 PM · Restricted Project, debug-info

Feb 4 2019

wolfgangp committed rG90d856cd5f4c: [DEBUGINFO] Reposting r352642: Handle restore instructions in LiveDebugValues (authored by wolfgangp).
[DEBUGINFO] Reposting r352642: Handle restore instructions in LiveDebugValues
Feb 4 2019, 12:46 PM
wolfgangp committed rL353089: [DEBUGINFO] Reposting r352642: Handle restore instructions in LiveDebugValues.
[DEBUGINFO] Reposting r352642: Handle restore instructions in LiveDebugValues
Feb 4 2019, 12:45 PM

Feb 1 2019

wolfgangp committed rL352889: [DWARF v5] Fix DWARF emitter and consumer to produce/expect a uleb for a….
[DWARF v5] Fix DWARF emitter and consumer to produce/expect a uleb for a…
Feb 1 2019, 9:12 AM
wolfgangp closed D57550: [DWARF v5] A location description's length is a uleb not a short (Fixing PR40525)..
Feb 1 2019, 9:11 AM · Restricted Project

Jan 31 2019

wolfgangp retitled D57550: [DWARF v5] A location description's length is a uleb not a short (Fixing PR40525). from [DWARF v5] A location descriptionlength is a uleb not a short (Fixing PR40525). to [DWARF v5] A location description's length is a uleb not a short (Fixing PR40525)..
Jan 31 2019, 3:13 PM · Restricted Project
wolfgangp created D57550: [DWARF v5] A location description's length is a uleb not a short (Fixing PR40525)..
Jan 31 2019, 3:07 PM · Restricted Project

Jan 30 2019

wolfgangp committed rL352666: Reverting r352642 - Handle restore instructions in LiveDebugValues - as it's….
Reverting r352642 - Handle restore instructions in LiveDebugValues - as it's…
Jan 30 2019, 12:37 PM
wolfgangp committed rL352651: The test comitted with r348896 needed -march=x86=64 on the llc command line..
The test comitted with r348896 needed -march=x86=64 on the llc command line.
Jan 30 2019, 11:16 AM
wolfgangp committed rL352642: [DEBUGINFO] Handle restore instructions in LiveDebugValues.
[DEBUGINFO] Handle restore instructions in LiveDebugValues
Jan 30 2019, 10:34 AM
wolfgangp closed D57271: [DebugInfo] Handle restore instructions in LiveDebugValues.
Jan 30 2019, 10:34 AM

Jan 29 2019

wolfgangp updated the diff for D57271: [DebugInfo] Handle restore instructions in LiveDebugValues.
  • Addressed review comments on code structure and clarifying comments.
Jan 29 2019, 3:14 PM
wolfgangp updated the diff for D57271: [DebugInfo] Handle restore instructions in LiveDebugValues.

Changed the function names from isSpillInstruction/isRestoreInstruction to getSpillSize/getRestoreSize.

Jan 29 2019, 11:50 AM
wolfgangp added inline comments to D57271: [DebugInfo] Handle restore instructions in LiveDebugValues.
Jan 29 2019, 10:52 AM

Jan 28 2019

wolfgangp added inline comments to D57271: [DebugInfo] Handle restore instructions in LiveDebugValues.
Jan 28 2019, 6:42 PM
wolfgangp updated the diff for D57271: [DebugInfo] Handle restore instructions in LiveDebugValues.
  • Added methods to MachineInstr to recognize Spills and restores and have AsmPrinter and LIvedebugValues use them
  • Unified tranferSpill and transferRestore functions.
  • Addressed other minor review comments.
Jan 28 2019, 6:42 PM
wolfgangp accepted D57050: [CodeGenPrepare] Handle all debug calls in dupRetToEnableTailCallOpts().

LGTM

Jan 28 2019, 11:10 AM

Jan 25 2019

wolfgangp created D57271: [DebugInfo] Handle restore instructions in LiveDebugValues.
Jan 25 2019, 5:17 PM

Jan 24 2019

wolfgangp added a comment to D57050: [CodeGenPrepare] Handle all debug calls in dupRetToEnableTailCallOpts().

If that's the case a brief excerpt of the original source construct (C, C++ or otherwise) that was used to produce the IR along with a couple of command lines to produce the MIR file should be sufficient. It doesn't have to be exact, but just so that the poor soul who has to regenerate the IR at some point in the future has something to go on. Check out llvm/test/CodeGen/MIR/X86/branch-folder-with-label.mir for an example.

Jan 24 2019, 9:24 AM

Jan 23 2019

wolfgangp added a comment to D57050: [CodeGenPrepare] Handle all debug calls in dupRetToEnableTailCallOpts().

The test case looks much better now, thanks.

Jan 23 2019, 10:47 AM

Jan 22 2019

wolfgangp added a comment to D57050: [CodeGenPrepare] Handle all debug calls in dupRetToEnableTailCallOpts().
Jan 22 2019, 11:47 AM

Dec 11 2018

wolfgangp committed rL348896: [Debuginfo] Prevent CodeGenPrepare from dropping debuginfo references..
[Debuginfo] Prevent CodeGenPrepare from dropping debuginfo references.
Dec 11 2018, 1:17 PM
wolfgangp closed D55396: [DebugInfo] Make sure CodeGenPrepare does not drop MD references to locals..
Dec 11 2018, 1:17 PM · debug-info

Dec 10 2018

wolfgangp updated the diff for D55396: [DebugInfo] Make sure CodeGenPrepare does not drop MD references to locals..

Revised to explicitly keep track of uses in dbg value intrinsics . This is more straightforward and does not miss any edge cases as in the previous implementation. Thanks to Vedant for the suggestion.

Dec 10 2018, 5:04 PM · debug-info

Dec 6 2018

wolfgangp added inline comments to D55396: [DebugInfo] Make sure CodeGenPrepare does not drop MD references to locals..
Dec 6 2018, 5:53 PM · debug-info
wolfgangp created D55396: [DebugInfo] Make sure CodeGenPrepare does not drop MD references to locals..
Dec 6 2018, 3:58 PM · debug-info

Nov 26 2018

wolfgangp updated the diff for D41044: Implementation of -fextend-lifetimes and -fextend-this-ptr to aid with debugging of optimized code.

Rebased on r347577 with some test cases.

Nov 26 2018, 11:39 AM · debug-info
wolfgangp updated the diff for D41043: Support for an intrinsic "fake.use" (and corresponding operand) representing a use of an operand to aid debugging.

Rebased on r347573 with some test cases and bugfixes.

Nov 26 2018, 11:37 AM

Nov 15 2018

wolfgangp added inline comments to D54465: [CodeGen] Fix bugs in LiveDebugVariables when debug labels are generated..
Nov 15 2018, 2:07 PM · debug-info

Nov 2 2018

wolfgangp committed rL346061: [DWARF v5] Verifier: Add checks for DW_FORM_strx* forms..
[DWARF v5] Verifier: Add checks for DW_FORM_strx* forms.
Nov 2 2018, 5:30 PM
wolfgangp closed D54049: [DWARF v5] Verifier: Add checks for DW_FORM_strx* forms..
Nov 2 2018, 5:30 PM
wolfgangp added inline comments to D54049: [DWARF v5] Verifier: Add checks for DW_FORM_strx* forms..
Nov 2 2018, 3:07 PM
wolfgangp added inline comments to D54049: [DWARF v5] Verifier: Add checks for DW_FORM_strx* forms..
Nov 2 2018, 2:37 PM
wolfgangp created D54049: [DWARF v5] Verifier: Add checks for DW_FORM_strx* forms..
Nov 2 2018, 2:34 PM

Oct 31 2018

wolfgangp committed rL345776: [DWARF][NFC] Refactor a function to return Optional<> instead of bool.
[DWARF][NFC] Refactor a function to return Optional<> instead of bool
Oct 31 2018, 2:08 PM
wolfgangp closed D53948: [DWARF][NFC] Refactor a function to return Optional<> instead of bool.
Oct 31 2018, 2:08 PM
wolfgangp created D53948: [DWARF][NFC] Refactor a function to return Optional<> instead of bool.
Oct 31 2018, 12:00 PM

Oct 30 2018

wolfgangp committed rL345687: [DWARF] Revert r345546: Refactor range list extraction and dumping.
[DWARF] Revert r345546: Refactor range list extraction and dumping
Oct 30 2018, 6:16 PM

Oct 29 2018

wolfgangp added inline comments to D53545: [DWARF][NFC] NFC patch for reverted r342218 (refactoring rangelist handling).
Oct 29 2018, 4:50 PM