wolfgangp (Wolfgang Pieb)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 17 2014, 5:52 PM (192 w, 3 d)

Recent Activity

Fri, May 18

wolfgangp committed rL332772: Fixing buildbot error introduced with r332759..
Fixing buildbot error introduced with r332759.
Fri, May 18, 2:51 PM
wolfgangp committed rL332766: Addressing a couple of compiler warnings introduced with r332759..
Addressing a couple of compiler warnings introduced with r332759.
Fri, May 18, 1:55 PM
wolfgangp committed rL332762: Fixing build error introduced with r332759..
Fixing build error introduced with r332759.
Fri, May 18, 1:39 PM
wolfgangp committed rL332759: [DWARF v5] Improved support for .debug_rnglists (consumer). Enables any….
[DWARF v5] Improved support for .debug_rnglists (consumer). Enables any…
Fri, May 18, 1:17 PM
wolfgangp closed D45549: [DWARF v5] improved support for .debug_rnglists/consumer.
Fri, May 18, 1:16 PM
wolfgangp added inline comments to D45549: [DWARF v5] improved support for .debug_rnglists/consumer.
Fri, May 18, 9:47 AM

Wed, May 16

wolfgangp added inline comments to D45549: [DWARF v5] improved support for .debug_rnglists/consumer.
Wed, May 16, 10:21 AM

Mon, May 14

wolfgangp updated the diff for D45549: [DWARF v5] improved support for .debug_rnglists/consumer.

Sorry for the long delay on this (I was out of the country with sketchy internet connections). I'm using the 'WithColor' convenience functions as Jonas suggested. Otherwise, I believe all review comments have been addressed.

Mon, May 14, 10:53 AM

Thu, May 10

wolfgangp committed rL332030: [DWARF] Fixing a bug in DWARF v5 string offsets tables where the length encoded….
[DWARF] Fixing a bug in DWARF v5 string offsets tables where the length encoded…
Thu, May 10, 1:06 PM
wolfgangp closed D45922: [DWARF v5] incorrect length of string offsets tables.
Thu, May 10, 1:06 PM

Apr 21 2018

wolfgangp created D45922: [DWARF v5] incorrect length of string offsets tables.
Apr 21 2018, 6:19 AM

Apr 13 2018

wolfgangp added inline comments to D45549: [DWARF v5] improved support for .debug_rnglists/consumer.
Apr 13 2018, 11:33 AM
wolfgangp updated the diff for D45549: [DWARF v5] improved support for .debug_rnglists/consumer.

Addressed review comments:

Apr 13 2018, 11:33 AM

Apr 11 2018

wolfgangp created D45549: [DWARF v5] improved support for .debug_rnglists/consumer.
Apr 11 2018, 5:57 PM

Apr 5 2018

wolfgangp committed rL329345: [DWARF v5][NFC]: Refactor DebugRnglists to prepare for the support of the….
[DWARF v5][NFC]: Refactor DebugRnglists to prepare for the support of the…
Apr 5 2018, 2:05 PM
wolfgangp closed D45307: [DWARF v5][NFC] Refactor the implementation of DebugRnglists .
Apr 5 2018, 2:05 PM
wolfgangp added inline comments to D45307: [DWARF v5][NFC] Refactor the implementation of DebugRnglists .
Apr 5 2018, 10:53 AM

Apr 4 2018

wolfgangp created D45307: [DWARF v5][NFC] Refactor the implementation of DebugRnglists .
Apr 4 2018, 6:09 PM

Mar 27 2018

wolfgangp committed rL328662: [DWARF][DWARF v5]: Adding support for dumping DW_RLE_offset_pair and….
[DWARF][DWARF v5]: Adding support for dumping DW_RLE_offset_pair and…
Mar 27 2018, 1:30 PM
wolfgangp closed D44811: DWARF] DWARF v5: .debug_rnglists: adding support for DW_RLE_offset_pair and DW_RLE_base_address.
Mar 27 2018, 1:30 PM

Mar 23 2018

wolfgangp updated the diff for D44811: DWARF] DWARF v5: .debug_rnglists: adding support for DW_RLE_offset_pair and DW_RLE_base_address.

Addressed review comment on separating DW_RLW_offset_pair and DW_RLE_start_length when dumping their contents.

Mar 23 2018, 5:23 PM
wolfgangp added inline comments to D44811: DWARF] DWARF v5: .debug_rnglists: adding support for DW_RLE_offset_pair and DW_RLE_base_address.
Mar 23 2018, 10:47 AM
wolfgangp added inline comments to D44811: DWARF] DWARF v5: .debug_rnglists: adding support for DW_RLE_offset_pair and DW_RLE_base_address.
Mar 23 2018, 10:20 AM

Mar 22 2018

wolfgangp created D44811: DWARF] DWARF v5: .debug_rnglists: adding support for DW_RLE_offset_pair and DW_RLE_base_address.
Mar 22 2018, 4:29 PM

Mar 8 2018

wolfgangp committed rL327059: [DWARF v5] Support for verbose dumping of .debug_rnglist entries.
[DWARF v5] Support for verbose dumping of .debug_rnglist entries
Mar 8 2018, 12:55 PM
wolfgangp closed D43366: [DWARF v5] Supporting verbose dumping of .dbg_rnglist entries.
Mar 8 2018, 12:55 PM

Mar 7 2018

wolfgangp added inline comments to D43366: [DWARF v5] Supporting verbose dumping of .dbg_rnglist entries.
Mar 7 2018, 6:31 PM
wolfgangp added a comment to D43366: [DWARF v5] Supporting verbose dumping of .dbg_rnglist entries.

Seems OK as an intermediate step - what's your end-goal/plan? I would think this would need to be merged in some way with existing range list support so that things like the symbolizer can work with DWARF 5? (see DWARFUnit::extractRangeList and DWARFDie::getAddressRanges for example)

Mar 7 2018, 6:31 PM

Mar 5 2018

wolfgangp updated the diff for D43366: [DWARF v5] Supporting verbose dumping of .dbg_rnglist entries.

Review comments: Aligning the closing brackets (']') of range list entries on the right, added a space to 'raw' content dumping of start/length pairs to align the contents with interval-style display.

Mar 5 2018, 6:59 PM

Feb 28 2018

wolfgangp added inline comments to D43366: [DWARF v5] Supporting verbose dumping of .dbg_rnglist entries.
Feb 28 2018, 4:31 PM
wolfgangp updated the diff for D43366: [DWARF v5] Supporting verbose dumping of .dbg_rnglist entries.

Addressing review comments: The dump routine(s) are using DIDumpOptions more consistently. Added a "DisplayRawContents" flag to DIDumpOptions and using it to inform DWARFAddressRange to either display a range as an interval or print its contents as is.

Feb 28 2018, 4:31 PM
wolfgangp abandoned D42937: [DWARF] Make llvm-dwp handle DWARF v5 string offsets tables and indexed strings..
Feb 28 2018, 10:24 AM
wolfgangp added a comment to D42937: [DWARF] Make llvm-dwp handle DWARF v5 string offsets tables and indexed strings..

Ok, souunds like the best thing to do would be to abandon this approach and start over in favor of a v5 only approach (in addition to the existing one of course).

Feb 28 2018, 10:21 AM

Feb 26 2018

wolfgangp updated the diff for D43366: [DWARF v5] Supporting verbose dumping of .dbg_rnglist entries.

Addressed James' review comments and gave default values to RangeListEntry's constructor parameters for better use. Added an error test for the currently unsupported DWARF64 format.

Feb 26 2018, 11:57 AM
wolfgangp added inline comments to D43366: [DWARF v5] Supporting verbose dumping of .dbg_rnglist entries.
Feb 26 2018, 11:57 AM

Feb 22 2018

wolfgangp added inline comments to D42937: [DWARF] Make llvm-dwp handle DWARF v5 string offsets tables and indexed strings..
Feb 22 2018, 5:02 PM
wolfgangp added a comment to D42937: [DWARF] Make llvm-dwp handle DWARF v5 string offsets tables and indexed strings..

(this patch doesn't have any changes to llvm-dwp - are those missing? Did they already get reviewed/submitted? something else?)

Feb 22 2018, 4:48 PM
wolfgangp added a comment to D43366: [DWARF v5] Supporting verbose dumping of .dbg_rnglist entries.

Seems awkward/not ideal to compute the start/end, then reverse those computations to compute the values appropriate to print in verbose mode - probably better to keep the original values & compute the final values when needed/printing?

Also I think there's probably some similar printing logic, maybe for the debug_loc.dwo section? Maybe check that to see how the different kinds of address range specifications (start+length, start+end, base address specifier, etc) are printed there & whether there's some uniformity that can be applied/reused/improved here?

Feb 22 2018, 4:34 PM
wolfgangp updated the diff for D43366: [DWARF v5] Supporting verbose dumping of .dbg_rnglist entries.

Revised the code to take advantage of DWARFAddressRange::dump(), which simplified both non-verbose and verbose dumping. I reduced the range list entries to just raw fields of uint64_t which seems less awkward than using a union with one of the fields an AddressRange. After that there was enough commonality between verbose and non-verbose dumping that it could be handled in one function instead of two.

Feb 22 2018, 4:31 PM

Feb 21 2018

wolfgangp added inline comments to D42937: [DWARF] Make llvm-dwp handle DWARF v5 string offsets tables and indexed strings..
Feb 21 2018, 11:07 AM
wolfgangp updated the diff for D42937: [DWARF] Make llvm-dwp handle DWARF v5 string offsets tables and indexed strings..

Removed the test for dwo-only input since it's redundant. The 'mixed' test of dwo + dwp file covers all cases.

Feb 21 2018, 11:04 AM

Feb 15 2018

wolfgangp created D43366: [DWARF v5] Supporting verbose dumping of .dbg_rnglist entries.
Feb 15 2018, 5:57 PM
wolfgangp added a comment to D42937: [DWARF] Make llvm-dwp handle DWARF v5 string offsets tables and indexed strings..

I'm still producing the dwo files from IR, I could turn those into assembly files as well, if that's preferable.

I think it'd probably be better - could you explain what the motivation is for them being IR tests? (what's the different needs there compared to the assembly test cases?)

Feb 15 2018, 2:21 PM

Feb 14 2018

wolfgangp updated the diff for D42937: [DWARF] Make llvm-dwp handle DWARF v5 string offsets tables and indexed strings..

Changed the test (string_offsets.test) to perform the 2 tests independently (instead of the second test depending on the result of the first). Added a hand-constructed dwp file to serve as input to test case 2. It has a mix of v5 and v4 units, type units to make sure the reference strings correctly and has the string offsets table contributions in a different order than the order in which the CUs appear in the index table.

Feb 14 2018, 6:15 PM

Feb 9 2018

wolfgangp added a comment to D42937: [DWARF] Make llvm-dwp handle DWARF v5 string offsets tables and indexed strings..

Curious combination of tests - some assembly, some IR. I think I made the existing test cases all checked in binaries.

Perhaps we could come up with a uniform approach/strategy here? (& yeah, I'd probably separate the "testing DWP input" from "testing DWP output" rather than weaving one into the other)

Feb 9 2018, 5:42 PM
wolfgangp added inline comments to D42937: [DWARF] Make llvm-dwp handle DWARF v5 string offsets tables and indexed strings..
Feb 9 2018, 11:03 AM
wolfgangp updated the diff for D42937: [DWARF] Make llvm-dwp handle DWARF v5 string offsets tables and indexed strings..

Addressed review comments, added a test for detecting DW_FORM_strp which is not supported in dwp files.

Feb 9 2018, 11:03 AM

Feb 8 2018

wolfgangp accepted D42801: [DebugInfo] Don't insert DEBUG_VALUE after terminators.

LGTM.

Feb 8 2018, 8:51 AM · debug-info

Feb 7 2018

wolfgangp added a comment to D42801: [DebugInfo] Don't insert DEBUG_VALUE after terminators.

Change LGTM with minor comment on possible readability improvement.

Feb 7 2018, 10:28 AM · debug-info

Feb 5 2018

wolfgangp created D42937: [DWARF] Make llvm-dwp handle DWARF v5 string offsets tables and indexed strings..
Feb 5 2018, 4:37 PM

Jan 30 2018

wolfgangp committed rL323804: [DWARF] Recommitting a test that was removed with r323564. Restricted to x86….
[DWARF] Recommitting a test that was removed with r323564. Restricted to x86…
Jan 30 2018, 10:43 AM

Jan 29 2018

wolfgangp committed rL323721: [DWARF] Corrected test committed in r323670 to use llc instead of llc_dwarf to….
[DWARF] Corrected test committed in r323670 to use llc instead of llc_dwarf to…
Jan 29 2018, 5:13 PM
wolfgangp committed rL323670: [DWARF] Recommitting a test reverted in r323560. Moved to x86 directory with….
[DWARF] Recommitting a test reverted in r323560. Moved to x86 directory with…
Jan 29 2018, 9:50 AM

Jan 26 2018

wolfgangp committed rL323564: [DWARF] Temporarily removing test to make buildbots happy while investigating..
[DWARF] Temporarily removing test to make buildbots happy while investigating.
Jan 26 2018, 1:26 PM
wolfgangp committed rL323560: [DWARF] Temporarily removing a test that caused an independent failure on the….
[DWARF] Temporarily removing a test that caused an independent failure on the…
Jan 26 2018, 12:51 PM
wolfgangp committed rL323546: [DWARF] Generate DWARF v5 string offsets tables along with strx* index forms..
[DWARF] Generate DWARF v5 string offsets tables along with strx* index forms.
Jan 26 2018, 10:55 AM
wolfgangp closed D42021: [DWARF] v5 implementation of string offsets tables - producer side.
Jan 26 2018, 10:55 AM

Jan 25 2018

wolfgangp added inline comments to D42021: [DWARF] v5 implementation of string offsets tables - producer side.
Jan 25 2018, 5:41 PM

Jan 24 2018

wolfgangp added a comment to D42021: [DWARF] v5 implementation of string offsets tables - producer side.

Dave, I think I addressed most of your comments, and commented on the ones I didn't. On the subject of tradeoffs wrt shared string offsets contributions, one idea would be to give each type unit (but not compile unit) its own contribution for easy removability by the linker. However, I'd like to do that or any other improvements as a follow-on patch if that's OK with you.

Jan 24 2018, 6:23 PM

Jan 17 2018

wolfgangp added inline comments to D42021: [DWARF] v5 implementation of string offsets tables - producer side.
Jan 17 2018, 6:42 PM
wolfgangp updated the diff for D42021: [DWARF] v5 implementation of string offsets tables - producer side.

Addressed most of David's review comments and commented on the ones I didn't address.

Jan 17 2018, 6:42 PM

Jan 12 2018

wolfgangp created D42021: [DWARF] v5 implementation of string offsets tables - producer side.
Jan 12 2018, 5:01 PM
wolfgangp accepted D41226: [LiveDebugValues] recognize spilled register that is killed in instruction after the spill.
Jan 12 2018, 12:00 PM

Jan 10 2018

wolfgangp committed rL322250: [DWARF][NFC] Overload AsmPrinter::emitDwarfStringOffsets() to take a….
[DWARF][NFC] Overload AsmPrinter::emitDwarfStringOffsets() to take a…
Jan 10 2018, 6:36 PM
wolfgangp closed D41920: [DWARF][NFC] Prep for upcoming DWARF v5 string offsets table producer patch..
Jan 10 2018, 6:36 PM
wolfgangp added a comment to D41920: [DWARF][NFC] Prep for upcoming DWARF v5 string offsets table producer patch..

Could you please upload patches with more context in the future? git diff -U9999 is good :-)

Jan 10 2018, 5:43 PM
wolfgangp created D41920: [DWARF][NFC] Prep for upcoming DWARF v5 string offsets table producer patch..
Jan 10 2018, 2:57 PM

Jan 8 2018

wolfgangp added inline comments to D41226: [LiveDebugValues] recognize spilled register that is killed in instruction after the spill.
Jan 8 2018, 5:33 PM
wolfgangp added a comment to D41226: [LiveDebugValues] recognize spilled register that is killed in instruction after the spill.

I agree that this is a solution to a specific case. I would be OK with it going in for now (after addressing the remaining review comments) with a FIXME comment added to provide a more comprehensive solution later, i.e. one that addresses bundles and kills in instructions further down the chain, as Bjorn suggested.

Jan 8 2018, 9:58 AM

Dec 21 2017

wolfgangp committed rL321330: [DWARF] Fix formatting bug with r321295. This fixes a MIPS buildbot failure..
[DWARF] Fix formatting bug with r321295. This fixes a MIPS buildbot failure.
Dec 21 2017, 5:13 PM
wolfgangp committed rL321295: [DWARF v5] Rework of string offsets table reader.
[DWARF v5] Rework of string offsets table reader
Dec 21 2017, 11:39 AM
wolfgangp closed D41146: [DWARF] DWARF v5: Rework of string offsets table reader.
Dec 21 2017, 11:39 AM

Dec 20 2017

wolfgangp added inline comments to D41146: [DWARF] DWARF v5: Rework of string offsets table reader.
Dec 20 2017, 5:38 PM
wolfgangp added inline comments to D41146: [DWARF] DWARF v5: Rework of string offsets table reader.
Dec 20 2017, 3:29 PM
wolfgangp updated the diff for D41146: [DWARF] DWARF v5: Rework of string offsets table reader.

Addressed more review comments: Made the logic on how to sort and unique string offsets table contributions a bit more readable when getting ready for dumping.

Dec 20 2017, 3:29 PM
wolfgangp added inline comments to D41146: [DWARF] DWARF v5: Rework of string offsets table reader.
Dec 20 2017, 11:15 AM
wolfgangp updated the diff for D41146: [DWARF] DWARF v5: Rework of string offsets table reader.

Refactored the string offsets contribution descriptor using Optional<>, which removes the need for a "valid" bit. Addressed some other review comments.

Dec 20 2017, 11:15 AM

Dec 19 2017

wolfgangp added inline comments to D41226: [LiveDebugValues] recognize spilled register that is killed in instruction after the spill.
Dec 19 2017, 4:05 PM
wolfgangp closed D40914: [NFC] Change the DWARF v5 string offsets table tests to generate the test object as part of the test..
Dec 19 2017, 8:56 AM

Dec 15 2017

wolfgangp updated the diff for D41146: [DWARF] DWARF v5: Rework of string offsets table reader.

Forgot to use std::move() on return of a vector.

Dec 15 2017, 11:42 AM

Dec 14 2017

wolfgangp added inline comments to D41146: [DWARF] DWARF v5: Rework of string offsets table reader.
Dec 14 2017, 5:33 PM
wolfgangp updated the diff for D41146: [DWARF] DWARF v5: Rework of string offsets table reader.

Addressed review comments. Streamlined the parseDWARF??StringOffsetsTableHeader() functions a bit and implemented a couple of other suggested changes.

Dec 14 2017, 5:33 PM

Dec 13 2017

wolfgangp added inline comments to D41146: [DWARF] DWARF v5: Rework of string offsets table reader.
Dec 13 2017, 10:41 AM

Dec 12 2017

wolfgangp created D41146: [DWARF] DWARF v5: Rework of string offsets table reader.
Dec 12 2017, 5:22 PM

Dec 11 2017

wolfgangp added inline comments to D41043: Support for an intrinsic "fake.use" (and corresponding operand) representing a use of an operand to aid debugging.
Dec 11 2017, 5:41 PM

Dec 8 2017

wolfgangp added a comment to D41044: Implementation of -fextend-lifetimes and -fextend-this-ptr to aid with debugging of optimized code.

A quick note on usage: Compile your source with "clang -O2 -g -c -fextend-lifetimes foo.cpp" to see the effects (or use -fextend-this-ptr if you just want to extend the lifetime of 'this').

Dec 8 2017, 5:31 PM · debug-info
wolfgangp added a comment to D41043: Support for an intrinsic "fake.use" (and corresponding operand) representing a use of an operand to aid debugging.

The clang portion has been posted in https://reviews.llvm.org/D41044.

Dec 8 2017, 5:29 PM
wolfgangp created D41044: Implementation of -fextend-lifetimes and -fextend-this-ptr to aid with debugging of optimized code.
Dec 8 2017, 5:27 PM · debug-info
wolfgangp created D41043: Support for an intrinsic "fake.use" (and corresponding operand) representing a use of an operand to aid debugging.
Dec 8 2017, 5:19 PM
wolfgangp committed rL320227: [NFC] Change the string offsets table tests to generate the object on the fly.
[NFC] Change the string offsets table tests to generate the object on the fly
Dec 8 2017, 4:40 PM

Dec 6 2017

wolfgangp created D40914: [NFC] Change the DWARF v5 string offsets table tests to generate the test object as part of the test..
Dec 6 2017, 11:56 AM

Oct 31 2017

wolfgangp committed rL317053: Making a couple of tests a bit more flexible wrt thunk mangling. Fixes checkin….
Making a couple of tests a bit more flexible wrt thunk mangling. Fixes checkin…
Oct 31 2017, 5:01 PM
wolfgangp committed rL317047: Fix for PR33930. Short-circuit metadata mapping when cloning a varargs thunk..
Fix for PR33930. Short-circuit metadata mapping when cloning a varargs thunk.
Oct 31 2017, 3:50 PM
wolfgangp closed D39396: Fix for PR33930. Short-circuit metadata mapping when cloning a varargs thunk. by committing rL317047: Fix for PR33930. Short-circuit metadata mapping when cloning a varargs thunk..
Oct 31 2017, 3:50 PM
wolfgangp committed rL317018: [Metadata][NFC] Make MDNode::resolve() public in preparation for the fix to….
[Metadata][NFC] Make MDNode::resolve() public in preparation for the fix to…
Oct 31 2017, 11:26 AM

Oct 30 2017

wolfgangp added a comment to D39396: Fix for PR33930. Short-circuit metadata mapping when cloning a varargs thunk..

This works for me, but as I said previously, perhaps we can get by with just not having any variables described in the thunk to further simplify the code.

Oct 30 2017, 6:23 PM
wolfgangp added inline comments to D39396: Fix for PR33930. Short-circuit metadata mapping when cloning a varargs thunk..
Oct 30 2017, 1:06 PM
wolfgangp updated the diff for D39396: Fix for PR33930. Short-circuit metadata mapping when cloning a varargs thunk..

Incorporated review comments.

Oct 30 2017, 1:05 PM

Oct 27 2017

wolfgangp created D39396: Fix for PR33930. Short-circuit metadata mapping when cloning a varargs thunk..
Oct 27 2017, 4:59 PM

Jul 19 2017

wolfgangp committed rL308527: Forgot to add triple to test in r308513..
Forgot to add triple to test in r308513.
Jul 19 2017, 2:46 PM