Page MenuHomePhabricator

Remove comments after header includes.
ClosedPublic

Authored by JDevlieghere on Nov 10 2018, 4:01 PM.

Details

Summary

This patch removes the comments following the header includes.

Personally I believe they add very little value, are often outdates and burdensome to maintain. Please let me know if you disagree or see a better alternative.

Because this is a large diff I've left out the context on purpose.

Diff Detail

Repository
rL LLVM

Event Timeline

JDevlieghere created this revision.Nov 10 2018, 4:01 PM
JDevlieghere edited the summary of this revision. (Show Details)Nov 10 2018, 4:04 PM
vsk accepted this revision as: vsk.Nov 10 2018, 4:22 PM
vsk added a subscriber: vsk.

Thanks, lgtm.

This revision is now accepted and ready to land.Nov 10 2018, 4:22 PM

Do we also want to get rid of the // C Includes comments that are in some files? LLVM isn't using them either and just removing lines doesn't make git blame more complicated.

source/Plugins/Instruction/MIPS/EmulateInstructionMIPS.cpp
38 ↗(On Diff #173537)

Just FYI: That's not one of the 'for X' kind of comments like the rest, but it also seems of redundant so let's also remove it.

Do we also want to get rid of the // C Includes comments that are in some files? LLVM isn't using them either and just removing lines doesn't make git blame more complicated.

Yup, I'll do that in a follow up!

This revision was automatically updated to reflect the committed changes.