[WebAssembly] Renumber and LEB128-encode SIMD opcodes
ClosedPublic

Authored by tlively on Mon, Nov 5, 4:33 PM.

Diff Detail

Repository
rL LLVM
tlively created this revision.Mon, Nov 5, 4:33 PM
aheejin added inline comments.Mon, Nov 5, 5:16 PM
lib/Target/WebAssembly/WebAssemblyInstrSIMD.td
40 ↗(On Diff #172679)

Is there any reason the section orders in this file have all changed? If possible keeping them the same would be helpful to view the diff to figure out what part has changed in which way.

tlively updated this revision to Diff 172696.Mon, Nov 5, 6:03 PM
  • Restore original section order
tlively marked an inline comment as done.Mon, Nov 5, 6:03 PM
aheejin added a comment.EditedTue, Nov 6, 3:00 PM

This CL does not only do renumbering but also do some of refactoring by unifying classes into unaries and binaries. Ideally they can be splitted, but if we want to do them herer together maybe we can add that part of explanation to the CL/commit description.

lib/Target/WebAssembly/WebAssemblyInstrSIMD.td
555 ↗(On Diff #172696)

Can we use SIMDUnary for this?

tlively updated this revision to Diff 173214.Thu, Nov 8, 1:09 PM
  • Renumber again
tlively updated this revision to Diff 173228.Thu, Nov 8, 2:32 PM
  • Use SIMDUnary for NOT
tlively marked an inline comment as done.Thu, Nov 8, 2:33 PM
aheejin accepted this revision.Thu, Nov 8, 2:45 PM
This revision is now accepted and ready to land.Thu, Nov 8, 2:45 PM
This revision was automatically updated to reflect the committed changes.