Fix build on sparc64-linux-gnu.

[marxin]

Summary

Following fixes build on Debian buster/sid NA
4.16.0-1-sparc64-smp.

As seen on the system sparcv9 macro is not defined, arch64__ is.
ifdef SANITIZER_SOLARIS is wrong as it's always defined (0/1 values).

The issue was introduced in r320740.

[krytarowski]

Adding @ro for check whether it's fine for Solaris and SPARC.

I'm not sure entirely whether this is fine for all supported OSes so I will let others to review.

[ro]

Overall, this looks good to me, with the nits noted.

However, I wonder how you tested this:

• SPARC isn't among cmake/config-ix.cmake (ALL_ASAN_SUPPORTED_ARCH); in fact there's no compiler-rt support for SPARC at all.

• In gcc, it's similar: there's no definition of TARGET_ASAN_SHADOW_OFFSET in the SPARC backend yet. I've submitted one for Solaris/SPARC in PR sanitizer/80953 and hope to finish and post it soon, but right now there's nothing.

Wondering...

lib/sanitizer_common/sanitizer_linux.cc

1949 ↗

(On Diff #172324)

Could you please remove the blank before (__sparcv9)? My mistake.

I've checked both gcc and clang and those two cover all OSes with
SPARC support.

1956 ↗

(On Diff #172324)

Good catch. Prompted by this, I checked the rest of compiler-rt
and there's only one other instance of #ifdef SANITIZER_<PLATFORM>
in lib/sanitizer_common/sanitizer_symbolizer.h with SANITIZER_WINDOWS.

[marxin]

In D54030#1286807, @ro wrote:

Overall, this looks good to me, with the nits noted.

However, I wonder how you tested this:

• SPARC isn't among cmake/config-ix.cmake (ALL_ASAN_SUPPORTED_ARCH); in fact there's no compiler-rt support for SPARC at all.

• In gcc, it's similar: there's no definition of TARGET_ASAN_SHADOW_OFFSET in the SPARC backend yet. I've submitted one for Solaris/SPARC in PR sanitizer/80953 and hope to finish and post it soon, but right now there's nothing.

Wondering...

I just built GCC on gcc202 machine of Compile farm. Even though the target is not supported, the libsanitizer runtime library is still built in GCC.

[ro]

In D54030#1286927, @marxin wrote:

I just built GCC on gcc202 machine of Compile farm. Even though the target is not supported, the libsanitizer runtime library is still built in GCC.

I see. Forgot to mention that I tested the patch myself on Solaris/SPARC in GCC mainline without regressions.

LGTM.

Thanks.

Rainer

compiler-rt/trunk/lib/sanitizer_common/sanitizer_linux.cc

#elif defined(__powerpc__) || defined(__powerpc64__)
   *pc = ucontext->uc_mcontext.regs->nip;
   *sp = ucontext->uc_mcontext.regs->gpr[PT_R1];
   // The powerpc{,64}-linux ABIs do not specify r31 as the frame
   // pointer, but GCC always uses r31 when we need a frame pointer.
   *bp = ucontext->uc_mcontext.regs->gpr[PT_R31];
 #elif defined(__sparc__)
   ucontext_t *ucontext = (ucontext_t*)context;
   uptr *stk_ptr;
-# if defined (__sparcv9)
+# if defined(__sparcv9) || defined (__arch64__)
 # ifndef MC_PC
 #  define MC_PC REG_PC
 # endif
 # ifndef MC_O6
 #  define MC_O6 REG_O6
 # endif
-# ifdef SANITIZER_SOLARIS
+# if SANITIZER_SOLARIS
 #  define mc_gregs gregs
 # endif
   *pc = ucontext->uc_mcontext.mc_gregs[MC_PC];
   *sp = ucontext->uc_mcontext.mc_gregs[MC_O6];
   stk_ptr = (uptr *) (*sp + 2047);
   *bp = stk_ptr[15];
 # else
   *pc = ucontext->uc_mcontext.gregs[REG_PC];