Page MenuHomePhabricator

marxin (Martin Liška)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 24 2016, 2:50 AM (332 w, 1 d)

Recent Activity

May 5 2022

marxin requested review of D125004: sanitizer: fix GCC warnings.
May 5 2022, 5:03 AM · Restricted Project

May 4 2022

marxin committed rGf1b9245199f3: tsan: fix GCC warnings (authored by marxin).
tsan: fix GCC warnings
May 4 2022, 1:23 AM · Restricted Project, Restricted Project
marxin closed D124828: tsan: fix GCC warnings.
May 4 2022, 1:23 AM · Restricted Project, Restricted Project
marxin requested review of D124907: hwasan: use NODEBUG and ALWAYS_INLINE attributes.
May 4 2022, 1:21 AM · Restricted Project

May 3 2022

marxin added a comment to D124832: sanitizer: support GCC's fallthrough attribute.

Fixed in: https://github.com/llvm/llvm-project/commit/903b8845fb5a0a366266d6f28231f994a5721178

May 3 2022, 4:58 AM · Restricted Project, Restricted Project
marxin committed rG903b8845fb5a: sanitizer: Fix fallthrough detection. (authored by marxin).
sanitizer: Fix fallthrough detection.
May 3 2022, 4:58 AM · Restricted Project, Restricted Project
marxin added a comment to D124832: sanitizer: support GCC's fallthrough attribute.

Yep, that works. Let me push such change.

May 3 2022, 4:54 AM · Restricted Project, Restricted Project
marxin added a comment to D124832: sanitizer: support GCC's fallthrough attribute.

It caused:

May 3 2022, 4:40 AM · Restricted Project, Restricted Project
marxin committed rG0a1bcab9f3bf: tsan: fix deadlock in libbacktrace (authored by marxin).
tsan: fix deadlock in libbacktrace
May 3 2022, 3:52 AM · Restricted Project, Restricted Project
marxin closed D124838: tsan: fix deadlock in libbacktrace.
May 3 2022, 3:51 AM · Restricted Project, Restricted Project
marxin updated the diff for D124838: tsan: fix deadlock in libbacktrace.
May 3 2022, 3:46 AM · Restricted Project, Restricted Project
marxin requested review of D124838: tsan: fix deadlock in libbacktrace.
May 3 2022, 3:45 AM · Restricted Project, Restricted Project
marxin updated the diff for D124828: tsan: fix GCC warnings.

V2 of the patch.

May 3 2022, 2:44 AM · Restricted Project, Restricted Project
marxin committed rGf496a0eba4f7: sanitizer: use pragma clang conditionally (authored by marxin).
sanitizer: use pragma clang conditionally
May 3 2022, 2:35 AM · Restricted Project, Restricted Project
marxin closed D124829: sanitizer: use pragma clang conditionally.
May 3 2022, 2:34 AM · Restricted Project, Restricted Project
marxin committed rGbc8e6012577b: sanitizer: support GCC's fallthrough attribute (authored by marxin).
sanitizer: support GCC's fallthrough attribute
May 3 2022, 2:31 AM · Restricted Project, Restricted Project
marxin closed D124832: sanitizer: support GCC's fallthrough attribute.
May 3 2022, 2:31 AM · Restricted Project, Restricted Project
marxin requested review of D124832: sanitizer: support GCC's fallthrough attribute.
May 3 2022, 1:55 AM · Restricted Project, Restricted Project
marxin requested review of D124829: sanitizer: use pragma clang conditionally.
May 3 2022, 1:20 AM · Restricted Project, Restricted Project
marxin requested review of D124828: tsan: fix GCC warnings.
May 3 2022, 1:12 AM · Restricted Project, Restricted Project

Apr 25 2022

Herald added a project to D110989: [Sanitizers] intercept md5 and sha2* apis on FreeBSD: Restricted Project.

Note this change caused https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105347

Apr 25 2022, 5:52 AM · Restricted Project, Restricted Project

Dec 9 2021

marxin added a reviewer for D115447: [PATCH] ASAN: Align declaration with definition of a fn: vitalybuka.
Dec 9 2021, 7:15 AM · Restricted Project
marxin requested review of D115447: [PATCH] ASAN: Align declaration with definition of a fn.
Dec 9 2021, 7:15 AM · Restricted Project

Nov 5 2021

marxin committed rG78d3e0a4f140: sanitizer: Fix -Wpedantic GCC warning (authored by marxin).
sanitizer: Fix -Wpedantic GCC warning
Nov 5 2021, 10:06 AM
marxin closed D113292: [PATCH] sanitizer: Fix -Wpedantic GCC warning.
Nov 5 2021, 10:06 AM · Restricted Project
marxin requested review of D113292: [PATCH] sanitizer: Fix -Wpedantic GCC warning.
Nov 5 2021, 9:06 AM · Restricted Project
marxin committed rG13a442ca494d: Enable -Wformat-pedantic and fix fallout. (authored by marxin).
Enable -Wformat-pedantic and fix fallout.
Nov 5 2021, 5:13 AM
marxin closed D113172: Enable -Wformat-pedantic and fix fallout..
Nov 5 2021, 5:12 AM · Restricted Project
marxin updated the diff for D113172: Enable -Wformat-pedantic and fix fallout..
Nov 5 2021, 5:11 AM · Restricted Project
marxin added inline comments to D113172: Enable -Wformat-pedantic and fix fallout..
Nov 5 2021, 5:11 AM · Restricted Project

Nov 4 2021

marxin requested review of D113172: Enable -Wformat-pedantic and fix fallout..
Nov 4 2021, 1:01 AM · Restricted Project
marxin committed rG629b40dafadb: Fix -Wformat warnings reported by GCC. (authored by marxin).
Fix -Wformat warnings reported by GCC.
Nov 4 2021, 12:53 AM
marxin closed D113099: Fix -Wformat warnings reported by GCC..
Nov 4 2021, 12:53 AM · Restricted Project
marxin updated the diff for D113099: Fix -Wformat warnings reported by GCC..

Fixed formatting.

Nov 4 2021, 12:30 AM · Restricted Project

Nov 3 2021

marxin added a reviewer for D113099: Fix -Wformat warnings reported by GCC.: jwakely.
Nov 3 2021, 5:56 AM · Restricted Project
marxin requested review of D113099: Fix -Wformat warnings reported by GCC..
Nov 3 2021, 5:54 AM · Restricted Project

Nov 2 2021

marxin committed rGc5029023fb07: Fix building with GCC 12: (authored by marxin).
Fix building with GCC 12:
Nov 2 2021, 6:28 AM
marxin closed D112990: Fix building with GCC 12.
Nov 2 2021, 6:28 AM · Restricted Project
marxin added a reviewer for D112990: Fix building with GCC 12: tstellar.
Nov 2 2021, 2:46 AM · Restricted Project
marxin requested review of D112990: Fix building with GCC 12.
Nov 2 2021, 1:37 AM · Restricted Project

Apr 16 2021

marxin added a comment to D100645: Sanitizer built against glibc 2.34 doesn't work.

I do support the suggested change.

Apr 16 2021, 6:54 AM · Restricted Project

Mar 30 2021

marxin added a comment to D96348: [sanitizers] Fix interception of GLibc regexec.

I would like to point to an issue reported on s390x:
https://github.com/google/sanitizers/issues/1390

Mar 30 2021, 4:50 AM · Restricted Project, Restricted Project

Mar 8 2021

marxin accepted D96348: [sanitizers] Fix interception of GLibc regexec.
Mar 8 2021, 1:26 AM · Restricted Project, Restricted Project

Feb 23 2021

marxin added a comment to D97263: [PATCH] Fix UBSAN in __ubsan::Value::getSIntValue.

Can you try to add a test?

Feb 23 2021, 2:11 AM · Restricted Project
marxin committed rG16ede0956cb1: Fix UBSAN in __ubsan::Value::getSIntValue (authored by marxin).
Fix UBSAN in __ubsan::Value::getSIntValue
Feb 23 2021, 2:11 AM
marxin closed D97263: [PATCH] Fix UBSAN in __ubsan::Value::getSIntValue.
Feb 23 2021, 2:10 AM · Restricted Project
marxin requested review of D97263: [PATCH] Fix UBSAN in __ubsan::Value::getSIntValue.
Feb 23 2021, 1:13 AM · Restricted Project

Feb 19 2021

marxin abandoned D95864: [PATCH] libsanitizer: Support non-POSIX extension REG_STARTEND..
Feb 19 2021, 5:50 AM
marxin added inline comments to D95864: [PATCH] libsanitizer: Support non-POSIX extension REG_STARTEND..
Feb 19 2021, 5:48 AM

Feb 18 2021

marxin added inline comments to D96348: [sanitizers] Fix interception of GLibc regexec.
Feb 18 2021, 11:46 PM · Restricted Project, Restricted Project
marxin added a comment to D95864: [PATCH] libsanitizer: Support non-POSIX extension REG_STARTEND..

There is D96348

Feb 18 2021, 11:44 PM
marxin added a reviewer for D95864: [PATCH] libsanitizer: Support non-POSIX extension REG_STARTEND.: vitalybuka.
Feb 18 2021, 3:13 AM

Feb 9 2021

marxin updated the diff for D95864: [PATCH] libsanitizer: Support non-POSIX extension REG_STARTEND..
Feb 9 2021, 8:25 AM

Feb 2 2021

marxin updated the summary of D95864: [PATCH] libsanitizer: Support non-POSIX extension REG_STARTEND..
Feb 2 2021, 4:51 AM
marxin requested review of D95864: [PATCH] libsanitizer: Support non-POSIX extension REG_STARTEND..
Feb 2 2021, 4:51 AM

Oct 20 2020

marxin committed rGad2be02a833e: ASAN: Support detect_invalid_pointer_pairs=1 with… (authored by marxin).
ASAN: Support detect_invalid_pointer_pairs=1 with…
Oct 20 2020, 10:29 AM
marxin closed D89552: ASAN: Support detect_invalid_pointer_pairs=1 with detect_stack_use_after_return=1.
Oct 20 2020, 10:29 AM · Restricted Project
marxin added inline comments to D89552: ASAN: Support detect_invalid_pointer_pairs=1 with detect_stack_use_after_return=1.
Oct 20 2020, 12:41 AM · Restricted Project

Oct 19 2020

marxin updated the diff for D89552: ASAN: Support detect_invalid_pointer_pairs=1 with detect_stack_use_after_return=1.
Oct 19 2020, 1:01 AM · Restricted Project
marxin added inline comments to D89552: ASAN: Support detect_invalid_pointer_pairs=1 with detect_stack_use_after_return=1.
Oct 19 2020, 1:01 AM · Restricted Project

Oct 16 2020

marxin requested review of D89552: ASAN: Support detect_invalid_pointer_pairs=1 with detect_stack_use_after_return=1.
Oct 16 2020, 6:40 AM · Restricted Project

Jun 1 2020

marxin committed rGb638b63b99d6: Move internal_uname to #if SANITIZER_LINUX scope. (authored by marxin).
Move internal_uname to #if SANITIZER_LINUX scope.
Jun 1 2020, 12:27 PM
marxin closed D80864: Move internal_uname to #if SANITIZER_LINUX scope..

Merged to master as b638b63b99d66786cb37336292604a2ae3490cfd.

Jun 1 2020, 12:25 PM
marxin added reviewers for D80864: Move internal_uname to #if SANITIZER_LINUX scope.: vitalybuka, kcc.
Jun 1 2020, 6:23 AM

May 30 2020

marxin created D80864: Move internal_uname to #if SANITIZER_LINUX scope..
May 30 2020, 1:33 AM
marxin added a comment to D80864: Move internal_uname to #if SANITIZER_LINUX scope..

It fixes multilib build in GCC on ppc64 after libsanitizer merge.

May 30 2020, 1:33 AM

Nov 27 2019

marxin committed rG2045d2c90e24: Make memory dump same as the one in asan. (authored by marxin).
Make memory dump same as the one in asan.
Nov 27 2019, 9:50 AM
marxin closed D70707: [hwasan] Make memory dump same as the one in asan..
Nov 27 2019, 9:50 AM · Restricted Project, Restricted Project
marxin added a comment to D70707: [hwasan] Make memory dump same as the one in asan..
In D70707#1760759, @pcc wrote:

Test case? (Do none of the tests really need to be updated?)

Nov 27 2019, 9:50 AM · Restricted Project, Restricted Project

Nov 26 2019

marxin added a comment to D70707: [hwasan] Make memory dump same as the one in asan..

Old report look:

Memory tags around the buggy address (one tag corresponds to 16 bytes):
   00  00  00  00  00  00  00  00  00  00  00  00  00  00  00  00   
   00  00  00  00  00  00  00  00  00  00  00  00  00  00  00  00   
   00  00  00  00  00  00  00  00  00  00  00  00  00  00  00  00   
   00  00  00  00  00  00  00  00  00  00  00  00  00  00  00  00   
   00  00  00  00  00  00  00  00  00  00  00  00  00  00  00  00   
   00  00  00  00  00  00  00  00  00  00  00  00  00  00  00  00   
   00  00  00  00  00  00  00  00  00  00  00  00  00  00  00  00   
   00  00  00  00  00  00  00  00  00  00  00  00  00  00  00  00   
=> d7  00 [08] 00  00  00  00  00  00  00  00  00  00  00  00  00 <=
   00  00  00  00  00  00  00  00  00  00  00  00  00  00  00  00   
   00  00  00  00  00  00  00  00  00  00  00  00  00  00  00  00   
   00  00  00  00  00  00  00  00  00  00  00  00  00  00  00  00   
   00  00  00  00  00  00  00  00  00  00  00  00  00  00  00  00   
   00  00  00  00  00  00  00  00  00  00  00  00  00  00  00  00   
   00  00  00  00  00  00  00  00  00  00  00  00  00  00  00  00   
   00  00  00  00  00  00  00  00  00  00  00  00  00  00  00  00   
   00  00  00  00  00  00  00  00  00  00  00  00  00  00  00  00   
Tags for short granules around the buggy address (one tag corresponds to 16 bytes):
   ..  ..  ..  ..  ..  ..  ..  ..  ..  ..  ..  ..  ..  ..  ..  ..   
=> ..  .. [be] ..  ..  ..  ..  ..  ..  ..  ..  ..  ..  ..  ..  .. <=
   ..  ..  ..  ..  ..  ..  ..  ..  ..  ..  ..  ..  ..  ..  ..  ..
Nov 26 2019, 1:29 AM · Restricted Project, Restricted Project
marxin created D70707: [hwasan] Make memory dump same as the one in asan..
Nov 26 2019, 1:29 AM · Restricted Project, Restricted Project

Jun 13 2019

marxin added a comment to D59876: Improve error message when '=' is missing in {ASAN,...}_OPTIONS..

Thank you for review. Can you please install the commit?

Jun 13 2019, 1:01 AM · Restricted Project

Jun 12 2019

marxin added inline comments to D59876: Improve error message when '=' is missing in {ASAN,...}_OPTIONS..
Jun 12 2019, 12:58 AM · Restricted Project
marxin updated the diff for D59876: Improve error message when '=' is missing in {ASAN,...}_OPTIONS..
Jun 12 2019, 12:58 AM · Restricted Project

Jun 11 2019

marxin updated the diff for D59876: Improve error message when '=' is missing in {ASAN,...}_OPTIONS..

Updated version of the patch.

Jun 11 2019, 1:58 AM · Restricted Project
marxin added inline comments to D59876: Improve error message when '=' is missing in {ASAN,...}_OPTIONS..
Jun 11 2019, 1:58 AM · Restricted Project

Jun 10 2019

marxin added a reviewer for D59876: Improve error message when '=' is missing in {ASAN,...}_OPTIONS.: vitalybuka.
Jun 10 2019, 3:03 AM · Restricted Project

May 16 2019

marxin updated the diff for D59876: Improve error message when '=' is missing in {ASAN,...}_OPTIONS..

Updated patch with a test-case.

May 16 2019, 2:38 AM · Restricted Project

Apr 8 2019

marxin added a comment to D59876: Improve error message when '=' is missing in {ASAN,...}_OPTIONS..

May I please ping this..

Apr 8 2019, 5:19 AM · Restricted Project

Mar 28 2019

marxin updated the diff for D59876: Improve error message when '=' is missing in {ASAN,...}_OPTIONS..

I've made the error message more verbose.

Mar 28 2019, 1:37 AM · Restricted Project

Mar 27 2019

marxin created D59876: Improve error message when '=' is missing in {ASAN,...}_OPTIONS..
Mar 27 2019, 6:16 AM · Restricted Project

Mar 6 2019

marxin committed rGa25a2c7c9a7e: Always compare C++ typeinfo (based on libstdc++ implementation). (authored by marxin).
Always compare C++ typeinfo (based on libstdc++ implementation).
Mar 6 2019, 12:36 AM
marxin committed rL355488: Always compare C++ typeinfo (based on libstdc++ implementation)..
Always compare C++ typeinfo (based on libstdc++ implementation).
Mar 6 2019, 12:36 AM
marxin committed rCRT355488: Always compare C++ typeinfo (based on libstdc++ implementation)..
Always compare C++ typeinfo (based on libstdc++ implementation).
Mar 6 2019, 12:36 AM
marxin closed D58028: Always compare C++ typeinfo (based on libstdc++ implementation)..
Mar 6 2019, 12:36 AM · Restricted Project, Restricted Project

Mar 5 2019

marxin added a comment to D58028: Always compare C++ typeinfo (based on libstdc++ implementation)..

Update version where I address last comment.

Mar 5 2019, 4:06 AM · Restricted Project, Restricted Project

Mar 1 2019

marxin updated the diff for D58028: Always compare C++ typeinfo (based on libstdc++ implementation)..

Update version where I address last comment.

Mar 1 2019, 1:25 AM · Restricted Project, Restricted Project

Feb 26 2019

marxin added a comment to D58028: Always compare C++ typeinfo (based on libstdc++ implementation)..

Gentle ping.

Feb 26 2019, 2:27 AM · Restricted Project, Restricted Project

Feb 21 2019

marxin updated the diff for D58028: Always compare C++ typeinfo (based on libstdc++ implementation)..

Updated version which preserves behavior on MACOS and IOS. For other targets SANITIZER_NON_UNIQUE_TYPEINFO is set to true.

Feb 21 2019, 1:55 AM · Restricted Project, Restricted Project

Feb 19 2019

marxin added a comment to D58028: Always compare C++ typeinfo (based on libstdc++ implementation)..

I do not believe this change is correct for MacOS or iOS. The original bug does not reproduce on MacOS, and on arm64 iOS you always need to compare strings. Could you preserve the existing behavior for those platforms?

Feb 19 2019, 3:45 AM · Restricted Project, Restricted Project

Feb 14 2019

marxin added a comment to D58028: Always compare C++ typeinfo (based on libstdc++ implementation)..

There hasn't been any reply yet. May I understand that as approval?

Feb 14 2019, 1:31 AM · Restricted Project, Restricted Project

Feb 11 2019

marxin created D58028: Always compare C++ typeinfo (based on libstdc++ implementation)..
Feb 11 2019, 12:36 AM · Restricted Project, Restricted Project
marxin abandoned D56485: Always compare C++ typeinfo (based on libstdc++ implementation)..
Feb 11 2019, 12:33 AM

Feb 5 2019

marxin added a comment to D56485: Always compare C++ typeinfo (based on libstdc++ implementation)..

Hi, there's no reply from the people who were added to this review.
May I understand that as ready to be installed?

filcab is still marked as blocking this. Also I thought you were going to file a new differential that had the commits list cc’ed correctly? See above where I asked you to add a couple of relevant reviewers to the new differential (and me as a subscriber) when you do.

Feb 5 2019, 12:07 AM
marxin added reviewers for D56485: Always compare C++ typeinfo (based on libstdc++ implementation).: Bigcheese, dcoughlin.
Feb 5 2019, 12:05 AM

Feb 4 2019

marxin added a comment to D56485: Always compare C++ typeinfo (based on libstdc++ implementation)..

Hi, there's no reply from the people who were added to this review.
May I understand that as ready to be installed?

Feb 4 2019, 6:12 AM

Jan 24 2019

marxin added a comment to D56485: Always compare C++ typeinfo (based on libstdc++ implementation)..

I would suggest to revert the commit, and submit the new differential with properly subscribed lists this time.
At least that is the 'recommended' general practice.

Jan 24 2019, 12:46 AM
marxin committed rL352033: Revert https://reviews.llvm.org/D56485..
Revert https://reviews.llvm.org/D56485.
Jan 24 2019, 12:46 AM
marxin committed rCRT352033: Revert https://reviews.llvm.org/D56485..
Revert https://reviews.llvm.org/D56485.
Jan 24 2019, 12:46 AM
marxin added a comment to D56485: Always compare C++ typeinfo (based on libstdc++ implementation)..

Please wait 1 or 2 days (to see if there are objections), and then you can consider the patch LGTMed.

Except the lists aren't subscibed, thus no feedback can happen :S
So this wasn't really reviewed.

Jan 24 2019, 12:41 AM