User Details
User Details
- User Since
- Feb 24 2016, 2:50 AM (396 w, 6 d)
Apr 19 2023
Apr 19 2023
marxin committed rGad42ea33bb39: Make use of '#pragma clang diagnostic' only with __clang__. (authored by marxin).
Make use of '#pragma clang diagnostic' only with __clang__.
marxin requested review of D148695: Make use of '#pragma clang diagnostic' only with __clang__..
Feb 24 2023
Feb 24 2023
ASAN: keep support for Global::location
Feb 23 2023
Feb 23 2023
marxin updated the diff for D144424: ASAN: keep support for Global::location.
marxin added a comment to D144424: ASAN: keep support for Global::location.
Feb 20 2023
Feb 20 2023
marxin requested review of D144424: ASAN: keep support for Global::location.
Nov 28 2022
Nov 28 2022
marxin abandoned D138039: sanitizer: fix GCC warnings.
Fair enough, then let's discard this.
Nov 28 2022, 6:26 AM · Restricted Project
Nov 21 2022
Nov 21 2022
Nov 21 2022, 12:36 AM · Restricted Project
Nov 15 2022
Nov 15 2022
marxin updated the summary of D138039: sanitizer: fix GCC warnings.
Nov 15 2022, 8:16 AM · Restricted Project
marxin requested review of D138039: sanitizer: fix GCC warnings.
Nov 15 2022, 8:16 AM · Restricted Project
May 5 2022
May 5 2022
marxin requested review of D125004: sanitizer: fix GCC warnings.
May 5 2022, 5:03 AM · Restricted Project
May 4 2022
May 4 2022
tsan: fix GCC warnings
marxin requested review of D124907: hwasan: use NODEBUG and ALWAYS_INLINE attributes.
May 4 2022, 1:21 AM · Restricted Project
May 3 2022
May 3 2022
marxin added a comment to D124832: sanitizer: support GCC's fallthrough attribute.
sanitizer: Fix fallthrough detection.
marxin added a comment to D124832: sanitizer: support GCC's fallthrough attribute.
Yep, that works. Let me push such change.
marxin added a comment to D124832: sanitizer: support GCC's fallthrough attribute.
It caused:
tsan: fix deadlock in libbacktrace
marxin updated the diff for D124838: tsan: fix deadlock in libbacktrace.
marxin requested review of D124838: tsan: fix deadlock in libbacktrace.
marxin updated the diff for D124828: tsan: fix GCC warnings.
V2 of the patch.
sanitizer: use pragma clang conditionally
marxin committed rGbc8e6012577b: sanitizer: support GCC's fallthrough attribute (authored by marxin).
sanitizer: support GCC's fallthrough attribute
marxin requested review of D124832: sanitizer: support GCC's fallthrough attribute.
marxin requested review of D124829: sanitizer: use pragma clang conditionally.
marxin requested review of D124828: tsan: fix GCC warnings.
Apr 25 2022
Apr 25 2022
Herald added a project to D110989: [Sanitizers] intercept md5 and sha2* apis on FreeBSD: Restricted Project.
Note this change caused https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105347
Dec 9 2021
Dec 9 2021
marxin added a reviewer for D115447: [PATCH] ASAN: Align declaration with definition of a fn: vitalybuka.
Dec 9 2021, 7:15 AM · Restricted Project
marxin requested review of D115447: [PATCH] ASAN: Align declaration with definition of a fn.
Dec 9 2021, 7:15 AM · Restricted Project
Nov 5 2021
Nov 5 2021
sanitizer: Fix -Wpedantic GCC warning
Nov 5 2021, 10:06 AM · Restricted Project
marxin requested review of D113292: [PATCH] sanitizer: Fix -Wpedantic GCC warning.
Nov 5 2021, 9:06 AM · Restricted Project
Enable -Wformat-pedantic and fix fallout.
Nov 5 2021, 5:12 AM · Restricted Project
marxin updated the diff for D113172: Enable -Wformat-pedantic and fix fallout..
Nov 5 2021, 5:11 AM · Restricted Project
marxin added inline comments to D113172: Enable -Wformat-pedantic and fix fallout..
Nov 5 2021, 5:11 AM · Restricted Project
Nov 4 2021
Nov 4 2021
marxin requested review of D113172: Enable -Wformat-pedantic and fix fallout..
Nov 4 2021, 1:01 AM · Restricted Project
Fix -Wformat warnings reported by GCC.
Nov 4 2021, 12:53 AM · Restricted Project
marxin updated the diff for D113099: Fix -Wformat warnings reported by GCC..
Fixed formatting.
Nov 4 2021, 12:30 AM · Restricted Project
Nov 3 2021
Nov 3 2021
Nov 3 2021, 5:56 AM · Restricted Project
marxin requested review of D113099: Fix -Wformat warnings reported by GCC..
Nov 3 2021, 5:54 AM · Restricted Project
Nov 2 2021
Nov 2 2021
Fix building with GCC 12:
Nov 2 2021, 6:28 AM · Restricted Project
Nov 2 2021, 2:46 AM · Restricted Project
marxin requested review of D112990: Fix building with GCC 12.
Nov 2 2021, 1:37 AM · Restricted Project
Apr 16 2021
Apr 16 2021
marxin added a comment to D100645: Sanitizer built against glibc 2.34 doesn't work.
I do support the suggested change.
Apr 16 2021, 6:54 AM · Restricted Project
Mar 30 2021
Mar 30 2021
marxin added a comment to D96348: [sanitizers] Fix interception of GLibc regexec.
I would like to point to an issue reported on s390x:
https://github.com/google/sanitizers/issues/1390
Mar 8 2021
Mar 8 2021
Feb 23 2021
Feb 23 2021
marxin added a comment to D97263: [PATCH] Fix UBSAN in __ubsan::Value::getSIntValue.
Feb 23 2021, 2:11 AM · Restricted Project
Fix UBSAN in __ubsan::Value::getSIntValue
Feb 23 2021, 2:10 AM · Restricted Project
marxin requested review of D97263: [PATCH] Fix UBSAN in __ubsan::Value::getSIntValue.
Feb 23 2021, 1:13 AM · Restricted Project
Feb 19 2021
Feb 19 2021
marxin added inline comments to D95864: [PATCH] libsanitizer: Support non-POSIX extension REG_STARTEND..
Feb 18 2021
Feb 18 2021
marxin added inline comments to D96348: [sanitizers] Fix interception of GLibc regexec.
marxin added a comment to D95864: [PATCH] libsanitizer: Support non-POSIX extension REG_STARTEND..
marxin added a reviewer for D95864: [PATCH] libsanitizer: Support non-POSIX extension REG_STARTEND.: vitalybuka.
Feb 9 2021
Feb 9 2021
marxin updated the diff for D95864: [PATCH] libsanitizer: Support non-POSIX extension REG_STARTEND..
Feb 2 2021
Feb 2 2021
marxin updated the summary of D95864: [PATCH] libsanitizer: Support non-POSIX extension REG_STARTEND..
marxin requested review of D95864: [PATCH] libsanitizer: Support non-POSIX extension REG_STARTEND..
Oct 20 2020
Oct 20 2020
marxin committed rGad2be02a833e: ASAN: Support detect_invalid_pointer_pairs=1 with… (authored by marxin).
ASAN: Support detect_invalid_pointer_pairs=1 with…
marxin closed D89552: ASAN: Support detect_invalid_pointer_pairs=1 with detect_stack_use_after_return=1.
Oct 20 2020, 10:29 AM · Restricted Project
marxin added inline comments to D89552: ASAN: Support detect_invalid_pointer_pairs=1 with detect_stack_use_after_return=1.
Oct 20 2020, 12:41 AM · Restricted Project
Oct 19 2020
Oct 19 2020
marxin updated the diff for D89552: ASAN: Support detect_invalid_pointer_pairs=1 with detect_stack_use_after_return=1.
Oct 19 2020, 1:01 AM · Restricted Project
marxin added inline comments to D89552: ASAN: Support detect_invalid_pointer_pairs=1 with detect_stack_use_after_return=1.
Oct 19 2020, 1:01 AM · Restricted Project
Oct 16 2020
Oct 16 2020
marxin requested review of D89552: ASAN: Support detect_invalid_pointer_pairs=1 with detect_stack_use_after_return=1.
Oct 16 2020, 6:40 AM · Restricted Project
Jun 1 2020
Jun 1 2020
marxin committed rGb638b63b99d6: Move internal_uname to #if SANITIZER_LINUX scope. (authored by marxin).
Move internal_uname to #if SANITIZER_LINUX scope.
Merged to master as b638b63b99d66786cb37336292604a2ae3490cfd.
marxin added reviewers for D80864: Move internal_uname to #if SANITIZER_LINUX scope.: vitalybuka, kcc.
May 30 2020
May 30 2020
marxin added a comment to D80864: Move internal_uname to #if SANITIZER_LINUX scope..
It fixes multilib build in GCC on ppc64 after libsanitizer merge.
Nov 27 2019
Nov 27 2019
Make memory dump same as the one in asan.
marxin added a comment to D70707: [hwasan] Make memory dump same as the one in asan..
Nov 26 2019
Nov 26 2019
marxin added a comment to D70707: [hwasan] Make memory dump same as the one in asan..
Old report look:
Memory tags around the buggy address (one tag corresponds to 16 bytes): 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 => d7 00 [08] 00 00 00 00 00 00 00 00 00 00 00 00 00 <= 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 Tags for short granules around the buggy address (one tag corresponds to 16 bytes): .. .. .. .. .. .. .. .. .. .. .. .. .. .. .. .. => .. .. [be] .. .. .. .. .. .. .. .. .. .. .. .. .. <= .. .. .. .. .. .. .. .. .. .. .. .. .. .. .. ..
Jun 13 2019
Jun 13 2019
marxin added a comment to D59876: Improve error message when '=' is missing in {ASAN,...}_OPTIONS..
Thank you for review. Can you please install the commit?
Jun 13 2019, 1:01 AM · Restricted Project
Jun 12 2019
Jun 12 2019
marxin added inline comments to D59876: Improve error message when '=' is missing in {ASAN,...}_OPTIONS..
Jun 12 2019, 12:58 AM · Restricted Project
marxin updated the diff for D59876: Improve error message when '=' is missing in {ASAN,...}_OPTIONS..
Jun 12 2019, 12:58 AM · Restricted Project
Jun 11 2019
Jun 11 2019
marxin updated the diff for D59876: Improve error message when '=' is missing in {ASAN,...}_OPTIONS..
Updated version of the patch.
Jun 11 2019, 1:58 AM · Restricted Project
marxin added inline comments to D59876: Improve error message when '=' is missing in {ASAN,...}_OPTIONS..
Jun 11 2019, 1:58 AM · Restricted Project
Jun 10 2019
Jun 10 2019
marxin added a reviewer for D59876: Improve error message when '=' is missing in {ASAN,...}_OPTIONS.: vitalybuka.
Jun 10 2019, 3:03 AM · Restricted Project
May 16 2019
May 16 2019
marxin updated the diff for D59876: Improve error message when '=' is missing in {ASAN,...}_OPTIONS..
Updated patch with a test-case.
May 16 2019, 2:38 AM · Restricted Project
Apr 8 2019
Apr 8 2019
marxin added a comment to D59876: Improve error message when '=' is missing in {ASAN,...}_OPTIONS..
May I please ping this..
Apr 8 2019, 5:19 AM · Restricted Project
Mar 28 2019
Mar 28 2019
marxin updated the diff for D59876: Improve error message when '=' is missing in {ASAN,...}_OPTIONS..
I've made the error message more verbose.
Mar 28 2019, 1:37 AM · Restricted Project
Mar 27 2019
Mar 27 2019
Mar 27 2019, 6:16 AM · Restricted Project
Mar 6 2019
Mar 6 2019
marxin committed rGa25a2c7c9a7e: Always compare C++ typeinfo (based on libstdc++ implementation). (authored by marxin).
Always compare C++ typeinfo (based on libstdc++ implementation).
Always compare C++ typeinfo (based on libstdc++ implementation).
Always compare C++ typeinfo (based on libstdc++ implementation).
Mar 5 2019
Mar 5 2019
marxin added a comment to D58028: Always compare C++ typeinfo (based on libstdc++ implementation)..
Mar 1 2019
Mar 1 2019
marxin updated the diff for D58028: Always compare C++ typeinfo (based on libstdc++ implementation)..
Update version where I address last comment.
Feb 26 2019
Feb 26 2019
marxin added a comment to D58028: Always compare C++ typeinfo (based on libstdc++ implementation)..
Gentle ping.