Page MenuHomePhabricator

marxin (Martin Liška)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 24 2016, 2:50 AM (177 w, 6 d)

Recent Activity

Jun 13 2019

marxin added a comment to D59876: Improve error message when '=' is missing in {ASAN,...}_OPTIONS..

Thank you for review. Can you please install the commit?

Jun 13 2019, 1:01 AM · Restricted Project

Jun 12 2019

marxin added inline comments to D59876: Improve error message when '=' is missing in {ASAN,...}_OPTIONS..
Jun 12 2019, 12:58 AM · Restricted Project
marxin updated the diff for D59876: Improve error message when '=' is missing in {ASAN,...}_OPTIONS..
Jun 12 2019, 12:58 AM · Restricted Project

Jun 11 2019

marxin updated the diff for D59876: Improve error message when '=' is missing in {ASAN,...}_OPTIONS..

Updated version of the patch.

Jun 11 2019, 1:58 AM · Restricted Project
marxin added inline comments to D59876: Improve error message when '=' is missing in {ASAN,...}_OPTIONS..
Jun 11 2019, 1:58 AM · Restricted Project

Jun 10 2019

marxin added a reviewer for D59876: Improve error message when '=' is missing in {ASAN,...}_OPTIONS.: vitalybuka.
Jun 10 2019, 3:03 AM · Restricted Project

May 16 2019

marxin updated the diff for D59876: Improve error message when '=' is missing in {ASAN,...}_OPTIONS..

Updated patch with a test-case.

May 16 2019, 2:38 AM · Restricted Project

Apr 8 2019

marxin added a comment to D59876: Improve error message when '=' is missing in {ASAN,...}_OPTIONS..

May I please ping this..

Apr 8 2019, 5:19 AM · Restricted Project

Mar 28 2019

marxin updated the diff for D59876: Improve error message when '=' is missing in {ASAN,...}_OPTIONS..

I've made the error message more verbose.

Mar 28 2019, 1:37 AM · Restricted Project

Mar 27 2019

marxin created D59876: Improve error message when '=' is missing in {ASAN,...}_OPTIONS..
Mar 27 2019, 6:16 AM · Restricted Project

Mar 6 2019

marxin committed rGa25a2c7c9a7e: Always compare C++ typeinfo (based on libstdc++ implementation). (authored by marxin).
Always compare C++ typeinfo (based on libstdc++ implementation).
Mar 6 2019, 12:36 AM
marxin committed rL355488: Always compare C++ typeinfo (based on libstdc++ implementation)..
Always compare C++ typeinfo (based on libstdc++ implementation).
Mar 6 2019, 12:36 AM
marxin committed rCRT355488: Always compare C++ typeinfo (based on libstdc++ implementation)..
Always compare C++ typeinfo (based on libstdc++ implementation).
Mar 6 2019, 12:36 AM
marxin closed D58028: Always compare C++ typeinfo (based on libstdc++ implementation)..
Mar 6 2019, 12:36 AM · Restricted Project, Restricted Project

Mar 5 2019

marxin added a comment to D58028: Always compare C++ typeinfo (based on libstdc++ implementation)..

Update version where I address last comment.

Mar 5 2019, 4:06 AM · Restricted Project, Restricted Project

Mar 1 2019

marxin updated the diff for D58028: Always compare C++ typeinfo (based on libstdc++ implementation)..

Update version where I address last comment.

Mar 1 2019, 1:25 AM · Restricted Project, Restricted Project

Feb 26 2019

marxin added a comment to D58028: Always compare C++ typeinfo (based on libstdc++ implementation)..

Gentle ping.

Feb 26 2019, 2:27 AM · Restricted Project, Restricted Project

Feb 21 2019

marxin updated the diff for D58028: Always compare C++ typeinfo (based on libstdc++ implementation)..

Updated version which preserves behavior on MACOS and IOS. For other targets SANITIZER_NON_UNIQUE_TYPEINFO is set to true.

Feb 21 2019, 1:55 AM · Restricted Project, Restricted Project

Feb 19 2019

marxin added a comment to D58028: Always compare C++ typeinfo (based on libstdc++ implementation)..

I do not believe this change is correct for MacOS or iOS. The original bug does not reproduce on MacOS, and on arm64 iOS you always need to compare strings. Could you preserve the existing behavior for those platforms?

Feb 19 2019, 3:45 AM · Restricted Project, Restricted Project

Feb 14 2019

marxin added a comment to D58028: Always compare C++ typeinfo (based on libstdc++ implementation)..

There hasn't been any reply yet. May I understand that as approval?

Feb 14 2019, 1:31 AM · Restricted Project, Restricted Project

Feb 11 2019

marxin created D58028: Always compare C++ typeinfo (based on libstdc++ implementation)..
Feb 11 2019, 12:36 AM · Restricted Project, Restricted Project
marxin abandoned D56485: Always compare C++ typeinfo (based on libstdc++ implementation)..
Feb 11 2019, 12:33 AM

Feb 5 2019

marxin added a comment to D56485: Always compare C++ typeinfo (based on libstdc++ implementation)..

Hi, there's no reply from the people who were added to this review.
May I understand that as ready to be installed?

filcab is still marked as blocking this. Also I thought you were going to file a new differential that had the commits list cc’ed correctly? See above where I asked you to add a couple of relevant reviewers to the new differential (and me as a subscriber) when you do.

Feb 5 2019, 12:07 AM
marxin added reviewers for D56485: Always compare C++ typeinfo (based on libstdc++ implementation).: Bigcheese, dcoughlin.
Feb 5 2019, 12:05 AM

Feb 4 2019

marxin added a comment to D56485: Always compare C++ typeinfo (based on libstdc++ implementation)..

Hi, there's no reply from the people who were added to this review.
May I understand that as ready to be installed?

Feb 4 2019, 6:12 AM

Jan 24 2019

marxin added a comment to D56485: Always compare C++ typeinfo (based on libstdc++ implementation)..

I would suggest to revert the commit, and submit the new differential with properly subscribed lists this time.
At least that is the 'recommended' general practice.

Jan 24 2019, 12:46 AM
marxin committed rL352033: Revert https://reviews.llvm.org/D56485..
Revert https://reviews.llvm.org/D56485.
Jan 24 2019, 12:46 AM
marxin committed rCRT352033: Revert https://reviews.llvm.org/D56485..
Revert https://reviews.llvm.org/D56485.
Jan 24 2019, 12:46 AM
marxin added a comment to D56485: Always compare C++ typeinfo (based on libstdc++ implementation)..

Please wait 1 or 2 days (to see if there are objections), and then you can consider the patch LGTMed.

Except the lists aren't subscibed, thus no feedback can happen :S
So this wasn't really reviewed.

Jan 24 2019, 12:41 AM
marxin committed rCRT352032: Always compare C++ typeinfo (based on libstdc++ implementation)..
Always compare C++ typeinfo (based on libstdc++ implementation).
Jan 24 2019, 12:25 AM
marxin committed rL352032: Always compare C++ typeinfo (based on libstdc++ implementation)..
Always compare C++ typeinfo (based on libstdc++ implementation).
Jan 24 2019, 12:25 AM

Jan 21 2019

marxin added a comment to D56485: Always compare C++ typeinfo (based on libstdc++ implementation)..
In D56485#1364241, @pcc wrote:

This change would only impact the "diagnostic" (non-production) mode of CFI. In production builds we do not link the runtime library at all. So from a CFI perspective this is fine.

Well, that makes sense. CFI was my biggest problem with this, so I'm tempted to accept the patch (The * doesn't seem to be a valid character for Itanium C++ ABI names, so I think having the test there should only trigger on gcc code).
Please wait 1 or 2 days (to see if there are objections), and then you can consider the patch LGTMed. I'll try to poke it on tuesday/wednesday.

Thank you,

Filipe
Jan 21 2019, 3:28 AM

Jan 18 2019

marxin added a comment to D56485: Always compare C++ typeinfo (based on libstdc++ implementation)..

Sample code I used:

namespace { struct S { S () {} ~S () {} virtual void foo () { asm volatile (""); } }; }
namespace { struct T : public S { T () {} ~T () {} virtual void foo () { asm volatile ("nop"); } }; }
void bar (S &s) { s.foo (); }
void baz () { S s; T t; bar (s); bar (t); }
Jan 18 2019, 1:48 AM
marxin added inline comments to D56485: Always compare C++ typeinfo (based on libstdc++ implementation)..
Jan 18 2019, 1:43 AM

Jan 16 2019

marxin added a reviewer for D56485: Always compare C++ typeinfo (based on libstdc++ implementation).: filcab.
Jan 16 2019, 11:51 PM
marxin added a reviewer for D11502: [UBSan] Fix isDerivedFromAtOffset on iOS ARM64: filcab.
Jan 16 2019, 11:50 PM

Jan 14 2019

marxin added a reviewer for D56485: Always compare C++ typeinfo (based on libstdc++ implementation).: alekseyshl.
Jan 14 2019, 5:16 AM

Jan 9 2019

marxin added a reviewer for D56485: Always compare C++ typeinfo (based on libstdc++ implementation).: kcc.
Jan 9 2019, 3:36 AM
marxin created D56485: Always compare C++ typeinfo (based on libstdc++ implementation)..
Jan 9 2019, 3:36 AM
marxin closed D54856: Do not rely on that subject of ErrorAllocTypeMismatch is a heap address..

It's installed.

Jan 9 2019, 3:33 AM

Dec 27 2018

marxin committed rL350085: Do not rely on that subject of ErrorAllocTypeMismatch is a heap address..
Do not rely on that subject of ErrorAllocTypeMismatch is a heap address.
Dec 27 2018, 12:43 AM
marxin committed rCRT350085: Do not rely on that subject of ErrorAllocTypeMismatch is a heap address..
Do not rely on that subject of ErrorAllocTypeMismatch is a heap address.
Dec 27 2018, 12:42 AM

Nov 30 2018

marxin updated the diff for D54856: Do not rely on that subject of ErrorAllocTypeMismatch is a heap address..

The right patch, previous one belongs to GCC :)

Nov 30 2018, 2:57 AM
marxin updated the diff for D54856: Do not rely on that subject of ErrorAllocTypeMismatch is a heap address..

Updated version of the patch.

Nov 30 2018, 2:56 AM
marxin added a comment to D54856: Do not rely on that subject of ErrorAllocTypeMismatch is a heap address..

Thanks for testing Vitaly. I must confirm that i386 is broken on my openSUSE, thus I can't test that.

Nov 30 2018, 2:55 AM

Nov 28 2018

marxin updated the diff for D54856: Do not rely on that subject of ErrorAllocTypeMismatch is a heap address..

Updated patch that introduces 2 new tests.

Nov 28 2018, 4:53 AM

Nov 27 2018

marxin added a comment to D54856: Do not rely on that subject of ErrorAllocTypeMismatch is a heap address..

@vitalybuka: I modified the patch based on your notes.

Nov 27 2018, 6:03 AM
marxin updated the diff for D54856: Do not rely on that subject of ErrorAllocTypeMismatch is a heap address..

Updated patch, I also found a test-case that fails for clang before my patch:

Nov 27 2018, 6:02 AM

Nov 23 2018

marxin created D54856: Do not rely on that subject of ErrorAllocTypeMismatch is a heap address..
Nov 23 2018, 4:19 AM

Nov 5 2018

marxin committed rCRT346129: Fix build on sparc64-linux-gnu..
Fix build on sparc64-linux-gnu.
Nov 5 2018, 4:30 AM
marxin committed rL346129: Fix build on sparc64-linux-gnu..
Fix build on sparc64-linux-gnu.
Nov 5 2018, 4:30 AM
marxin closed D54030: Fix build on sparc64-linux-gnu..
Nov 5 2018, 4:30 AM

Nov 4 2018

marxin updated the diff for D54030: Fix build on sparc64-linux-gnu..
Nov 4 2018, 11:45 PM
marxin added a comment to D54030: Fix build on sparc64-linux-gnu..
In D54030#1286807, @ro wrote:

Overall, this looks good to me, with the nits noted.

However, I wonder how you tested this:

  • SPARC isn't among cmake/config-ix.cmake (ALL_ASAN_SUPPORTED_ARCH); in fact there's no compiler-rt support for SPARC at all.
  • In gcc, it's similar: there's no definition of TARGET_ASAN_SHADOW_OFFSET in the SPARC backend yet. I've submitted one for Solaris/SPARC in PR sanitizer/80953 and hope to finish and post it soon, but right now there's nothing.

    Wondering...
Nov 4 2018, 11:45 PM

Nov 2 2018

marxin created D54030: Fix build on sparc64-linux-gnu..
Nov 2 2018, 2:13 AM

Oct 25 2018

Herald updated subscribers of D39924: [PowerPC][tsan] Update tsan to handle changed memory layouts in newer kernels.
Oct 25 2018, 12:40 AM

Oct 23 2018

marxin committed rL345006: Come up with MIN_PERCENTAGE_CHANGE value..
Come up with MIN_PERCENTAGE_CHANGE value.
Oct 23 2018, 12:11 AM
marxin closed D53136: [LNT] Come up with MIN_PERCENTAGE_CHANGE value.
Oct 23 2018, 12:11 AM

Oct 11 2018

marxin created D53136: [LNT] Come up with MIN_PERCENTAGE_CHANGE value.
Oct 11 2018, 5:49 AM
marxin abandoned D51609: [LNT] Enable X-Forwarded-* headers to be accepted..
Oct 11 2018, 5:47 AM

Oct 1 2018

marxin committed rL343504: Fix fallout caused by YAML files ordering..
Fix fallout caused by YAML files ordering.
Oct 1 2018, 10:23 AM
marxin closed D52723: [LNT] Fix fallout caused by YAML files ordering..
Oct 1 2018, 10:23 AM
marxin created D52723: [LNT] Fix fallout caused by YAML files ordering..
Oct 1 2018, 6:05 AM
marxin committed rL343467: Install missing files..
Install missing files.
Oct 1 2018, 5:40 AM
marxin committed rL343466: Sort fields according to order defined in YAML files..
Sort fields according to order defined in YAML files.
Oct 1 2018, 5:34 AM
marxin closed D52593: [LNT] Sort fields according to order defined in YAML files..
Oct 1 2018, 5:34 AM
marxin committed rL343465: Use unit_abbrev of Fields in reports..
Use unit_abbrev of Fields in reports.
Oct 1 2018, 5:33 AM
marxin closed D51916: [LNT] Use unit_abbrev of Fields in reports..
Oct 1 2018, 5:33 AM
marxin committed rL343464: Improve alignment of HTML report..
Improve alignment of HTML report.
Oct 1 2018, 5:28 AM
marxin closed D51915: [LNT] Improve alignment of HTML report..
Oct 1 2018, 5:28 AM
marxin committed rL343463: Print machine name in LNT graph tooltip..
Print machine name in LNT graph tooltip.
Oct 1 2018, 5:25 AM
marxin closed D52346: [LNT] Print machine name in LNT graph tooltip..
Oct 1 2018, 5:24 AM
marxin committed rL343462: Introduce Latest Runs Report..
Introduce Latest Runs Report.
Oct 1 2018, 5:22 AM
marxin closed D51405: [LNT][RFC] Introduce Latest Runs Report..
Oct 1 2018, 5:22 AM

Sep 27 2018

marxin created D52593: [LNT] Sort fields according to order defined in YAML files..
Sep 27 2018, 3:05 AM

Sep 21 2018

marxin created D52346: [LNT] Print machine name in LNT graph tooltip..
Sep 21 2018, 2:56 AM
marxin added a comment to D51405: [LNT][RFC] Introduce Latest Runs Report..

May I please remind this review..

Sep 21 2018, 2:37 AM

Sep 17 2018

marxin added inline comments to D51916: [LNT] Use unit_abbrev of Fields in reports..
Sep 17 2018, 4:12 AM
marxin updated the diff for D51916: [LNT] Use unit_abbrev of Fields in reports..

Updated to check for 'bytes' to be field.unit and field.unit_abbrev == 'B'.

Sep 17 2018, 4:12 AM

Sep 11 2018

marxin created D51916: [LNT] Use unit_abbrev of Fields in reports..
Sep 11 2018, 1:02 AM
marxin added a comment to D51915: [LNT] Improve alignment of HTML report..

The revision depends on: https://reviews.llvm.org/D51405

Sep 11 2018, 12:49 AM
marxin created D51915: [LNT] Improve alignment of HTML report..
Sep 11 2018, 12:49 AM
marxin added a comment to D51405: [LNT][RFC] Introduce Latest Runs Report..

May I please ping this.

Sep 11 2018, 12:06 AM

Sep 5 2018

marxin updated the diff for D51405: [LNT][RFC] Introduce Latest Runs Report..

One more update where I add accordion for easier orientation on the report page.

Sep 5 2018, 5:53 AM
marxin added a comment to D51609: [LNT] Enable X-Forwarded-* headers to be accepted..

I use Apache2 + mod_wsgi.

Sep 5 2018, 1:39 AM

Sep 4 2018

marxin added a comment to D51609: [LNT] Enable X-Forwarded-* headers to be accepted..

The docs mention "Do not use this middleware in non-proxy setups for security reasons." I would assume because this allows the client to set the host information. I use this in our setups. I think I apply it in the app launch file that we hand to gunicorn instead of here.

Sep 4 2018, 11:45 AM
marxin created D51609: [LNT] Enable X-Forwarded-* headers to be accepted..
Sep 4 2018, 12:50 AM

Aug 30 2018

marxin added a comment to D51405: [LNT][RFC] Introduce Latest Runs Report..

Changes from previous version:

  • I removed try, except in v4_latest_runs_report
  • I added at least check_html test, once installed I add some real checking content
  • accordion toggle added to HTML report, it's easier to navigate now
  • all nits you mentioned should be fixed now
Aug 30 2018, 4:34 AM
marxin updated the diff for D51405: [LNT][RFC] Introduce Latest Runs Report..
Aug 30 2018, 4:30 AM

Aug 29 2018

marxin created D51405: [LNT][RFC] Introduce Latest Runs Report..
Aug 29 2018, 12:56 AM

Aug 1 2018

marxin created D50131: Fix sizeof(struct pthread) in glibc 2.14..
Aug 1 2018, 12:43 AM

Jun 12 2018

marxin committed rL334482: Sort machines in machines view..
Sort machines in machines view.
Jun 12 2018, 12:58 AM
marxin closed D48003: [LNT] Sort machines in machines view..
Jun 12 2018, 12:58 AM

Jun 11 2018

marxin created D48003: [LNT] Sort machines in machines view..
Jun 11 2018, 2:04 AM

Jun 1 2018

marxin added a comment to D47581: [LNT] Fix use of field index in daily report.

Thank you for the fix.

Jun 1 2018, 6:17 AM

May 29 2018

marxin abandoned D47486: [LNT] Request authentization for lnt submit command via secret_key in lnt.cfg file..

@MatzeB: Agree with you, restricting methods will be the easiest way how to achieve that:

May 29 2018, 10:54 AM
marxin created D47486: [LNT] Request authentization for lnt submit command via secret_key in lnt.cfg file..
May 29 2018, 10:01 AM

May 25 2018

marxin committed rL333260: Sort machines in Compare to by names..
Sort machines in Compare to by names.
May 25 2018, 1:00 AM
marxin closed D47186: [LNT] Sort machines in Compare to by names..
May 25 2018, 1:00 AM
marxin committed rL333259: API: add Tests resource..
API: add Tests resource.
May 25 2018, 1:00 AM