This is an archive of the discontinued LLVM Phabricator instance.

[WebAssembly] Add V128 to WebAssemblyInstrInfo::copyPhysReg
ClosedPublic

Authored by tlively on Oct 30 2018, 10:01 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

tlively created this revision.Oct 30 2018, 10:01 AM

Can we have a test case? I think we can have an mir test case with COPY opcode in there. To lower COPY to the relevant COPY_type opcode, we need this function.

tlively updated this revision to Diff 172829.Nov 6 2018, 12:40 PM
  • Add MIR test

Can we have a test case? I think we can have an mir test case with COPY opcode in there. To lower COPY to the relevant COPY_type opcode, we need this function.

Done.

aheejin added inline comments.Nov 6 2018, 1:51 PM
test/CodeGen/WebAssembly/regcopy.mir
31 ↗(On Diff #172829)

I think you can remove these for virtual registers?

35 ↗(On Diff #172829)

Do we need frameinfo here?

tlively updated this revision to Diff 172854.Nov 6 2018, 2:15 PM
  • Further minimize test case
tlively marked an inline comment as done.Nov 6 2018, 2:16 PM
tlively added inline comments.
test/CodeGen/WebAssembly/regcopy.mir
31 ↗(On Diff #172829)

Doesn't seem so, but I removed some other things.

35 ↗(On Diff #172829)

Nope.

aheejin accepted this revision.Nov 7 2018, 1:53 PM

Otherwise LGTM

test/CodeGen/WebAssembly/regcopy.mir
31 ↗(On Diff #172829)

I think you can remove this and add :i32 to the code itself as you did for %0, as in
%0:i32 = COPY %1:i32
The same for other %1 usages in other functions.

This revision is now accepted and ready to land.Nov 7 2018, 1:53 PM
This revision was automatically updated to reflect the committed changes.
tlively marked an inline comment as done.