Page MenuHomePhabricator

[libc++abi] Provide __cxa_thread_atexit on Fuchsia
ClosedPublic

Authored by phosek on Oct 28 2018, 2:01 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

phosek created this revision.Oct 28 2018, 2:01 PM

I don't know what's affected by the presence of that declaration. Certainly it should be defined.
AFAICT this has nothing to do with solving the problem of the symbol not existing in the library.
That needs CMakeLists.txt:34 changed so it compiles cxa_thread_atexit.cpp for Fuchsia.
We also need to make sure that the cmake check for presence of __cxa_thread_atexit_impl in libc is passing correctly.

phosek updated this revision to Diff 171442.Oct 28 2018, 4:34 PM

I don't know what's affected by the presence of that declaration. Certainly it should be defined.
AFAICT this has nothing to do with solving the problem of the symbol not existing in the library.
That needs CMakeLists.txt:34 changed so it compiles cxa_thread_atexit.cpp for Fuchsia.

I missed that one.

We also need to make sure that the cmake check for presence of __cxa_thread_atexit_impl in libc is passing correctly.

I already checked that one and it's being detected properly.

This revision is now accepted and ready to land.Oct 28 2018, 4:39 PM
ldionne accepted this revision.Oct 29 2018, 9:47 AM
This revision was automatically updated to reflect the committed changes.