This is an archive of the discontinued LLVM Phabricator instance.

Support g++ headers in include/g++
ClosedPublic

Authored by greened on Oct 26 2018, 10:27 AM.

Details

Summary

Cray's gcc installation puts C++ headers in PREFIX/include/g++ without indicating a gcc version at all. Typically this is because the version is encoded somewhere in PREFIX.

Diff Detail

Repository
rC Clang

Event Timeline

greened created this revision.Oct 26 2018, 10:27 AM
rsmith added a subscriber: rsmith.Oct 26 2018, 12:34 PM

This needs a test.

lib/Driver/ToolChains/Linux.cpp
927–928

It'd be useful to say who this "some" is, so we can check whether this is still a valid concern in the future.

greened added inline comments.Oct 29 2018, 7:29 AM
lib/Driver/ToolChains/Linux.cpp
927–928

I will try to find out where we got the package from.

greened updated this revision to Diff 171801.Oct 30 2018, 2:34 PM
greened edited the summary of this revision. (Show Details)

Explain that Cray packages gcc such that headers are in include/g++.

Looks good with an accompanying test. (You can probably copy whatever was added for the FreeScale line above.)

This revision was not accepted when it landed; it landed in state Needs Review.Nov 13 2018, 1:41 PM
This revision was automatically updated to reflect the committed changes.

Oops, I didn't realize this hadn't been formally accepted yet. Still learning the Phab process. Let me know if you want it reverted for a formal accept.

Oops, I didn't realize this hadn't been formally accepted yet. Still learning the Phab process. Let me know if you want it reverted for a formal accept.

No, this is fine.