[clang-tidy] UppercaseLiteralSuffixCheck: bugfix: don't cripple substNonTypeTemplateParmExpr

[lebedev.ri]

Summary

The previous, clearly broken output:

/tmp/test.cpp:4:17: warning: integer literal has suffix 'lignment', which is not uppercase [hicpp-uppercase-literal-suffix]
  static_assert(alignment, "");
                ^~~~~~~~~
                 LIGNMENT

https://godbolt.org/z/iyWIrX

Is there some more general way this should be avoided?
Too bad i haven't thought of this/triggered this while developing :/

[JonasToth]

What do you mean by "general way to avoid"? Templates?

[lebedev.ri]

In D53719#1276208, @JonasToth wrote:

What do you mean by "general way to avoid"? Templates?

I'm basically asking "is the unless(hasParent(substNonTypeTemplateParmExpr())) fix correct? or is there something else i'm missing?"

[JonasToth]

I'm basically asking "is the unless(hasParent(substNonTypeTemplateParmExpr())) fix correct? or is there something else i'm missing?"

Ah ok, I am not aware of another way, but not an expert on the AST either :)
LGTM

[lebedev.ri]

Reverted the check, reopened D52670.

clang-tidy/readability/UppercaseLiteralSuffixCheck.cpp

 
 void UppercaseLiteralSuffixCheck::registerMatchers(MatchFinder *Finder) {
   // Sadly, we can't check whether the literal has sufix or not.
   // E.g. i32 suffix still results in 'BuiltinType::Kind::Int'.
   // And such an info is not stored in the *Literal itself.
   Finder->addMatcher(
       stmt(allOf(eachOf(integerLiteral().bind(IntegerLiteralCheck::Name),
                         floatLiteral().bind(FloatingLiteralCheck::Name)),
-                 unless(hasParent(userDefinedLiteral())))),
+                 unless(anyOf(hasParent(userDefinedLiteral()),
+                              hasParent(substNonTypeTemplateParmExpr()))))),
       this);
 }
 
 template <typename LiteralType>
 bool UppercaseLiteralSuffixCheck::checkBoundMatch(
     const MatchFinder::MatchResult &Result) {
   const auto *Literal =
       Result.Nodes.getNodeAs<typename LiteralType::type>(LiteralType::Name);

test/clang-tidy/readability-uppercase-literal-suffix-integer.cpp

 }
 
 // Check that user-defined literals do not cause any diags.
 
 unsigned long long int operator"" _ull(unsigned long long int);
 void user_defined_literals() {
   1_ull;
 }
+
+template <unsigned alignment>
+void template_test() {
+  static_assert(alignment, "");
+}
+void actual_template_test() {
+  template_test<4>();
+}