[clang-tidy] UppercaseLiteralSuffixCheck: bugfix: ignore implicit code

[lebedev.ri]

Summary

The previous, clearly broken output:

/tmp/test.cpp:13:15: warning: integer literal has suffix 'le', which is not uppercase [hicpp-uppercase-literal-suffix]
for (auto i : table) {
              ^  ~~
                 LE

I'm so so sad that i'm only now discovering this brokenness.

[JonasToth]

Did you discover these in a real project? May I ask which one and add it to my BB? :)

[lebedev.ri]

Reverted the check, reopened D52670.

clang-tidy/readability/UppercaseLiteralSuffixCheck.cpp

 
 void UppercaseLiteralSuffixCheck::registerMatchers(MatchFinder *Finder) {
   // Sadly, we can't check whether the literal has sufix or not.
   // E.g. i32 suffix still results in 'BuiltinType::Kind::Int'.
   // And such an info is not stored in the *Literal itself.
   Finder->addMatcher(
       stmt(allOf(eachOf(integerLiteral().bind(IntegerLiteralCheck::Name),
                         floatLiteral().bind(FloatingLiteralCheck::Name)),
-                 unless(anyOf(hasParent(userDefinedLiteral()),
+                 unless(anyOf(hasAncestor(isImplicit()),
+                              hasParent(userDefinedLiteral()),
                               hasParent(substNonTypeTemplateParmExpr()))))),
       this);
 }
 
 template <typename LiteralType>
 bool UppercaseLiteralSuffixCheck::checkBoundMatch(
     const MatchFinder::MatchResult &Result) {
   const auto *Literal =

test/clang-tidy/readability-uppercase-literal-suffix-integer.cpp

 
 template <unsigned alignment>
 void template_test() {
   static_assert(alignment, "");
 }
 void actual_template_test() {
   template_test<4>();
 }
+
+const int table[6] = {};
+void read_test() {
+  for (auto i : table) {
+  }
+}