Page MenuHomePhabricator

[ELF] Don't check if symbols in .llvm.call-graph-profile are unorderable
ClosedPublic

Authored by MaskRay on Oct 24 2018, 1:47 PM.

Diff Detail

Repository
rLLD LLVM Linker

Event Timeline

MaskRay created this revision.Oct 24 2018, 1:47 PM
ruiu added a comment.Oct 24 2018, 1:52 PM

Could you add a test?

Could you add a test?

ToSym is never covered by a test. Is it fine?

grimar added a subscriber: grimar.Oct 25 2018, 1:59 AM
ruiu added a comment.Oct 25 2018, 11:03 AM

Maybe we should remove these warnings altogether as we discussed offline.

I'm all in favor of removing the warnings. I was against adding them to begin with.

ruiu added a comment.Oct 25 2018, 1:02 PM

Let's remove them, then.

MaskRay updated this revision to Diff 171190.Oct 25 2018, 1:52 PM
MaskRay retitled this revision from [ELF] Don't check if ToSym if unorderable to [ELF] Don't check if symbols in .llvm.call-graph-profile are unorderable.
MaskRay edited the summary of this revision. (Show Details)

Update title. Don't check if symbols are unorderable

ruiu added inline comments.Oct 25 2018, 2:24 PM
ELF/Driver.cpp
692–693

I don't think you need to leave any comment. In particular, this comment does not actually give any justification on why you are not doing it.

MaskRay updated this revision to Diff 171199.Oct 25 2018, 2:29 PM

Delete comments

ruiu accepted this revision.Oct 25 2018, 2:58 PM

LGTM

This revision is now accepted and ready to land.Oct 25 2018, 2:58 PM
This revision was automatically updated to reflect the committed changes.