Page MenuHomePhabricator

Extend shelf-life by 70 years
AcceptedPublic

Authored by bmwiedemann on Oct 6 2018, 9:32 PM.

Details

Summary

Without this patch, tests would fail after 2030.

Note: requires timestamps with more than 31 bits

Diff Detail

Event Timeline

bmwiedemann created this revision.Oct 6 2018, 9:32 PM
RKSimon resigned from this revision.Oct 10 2018, 3:50 AM
RKSimon added reviewers: rsmith, bruno, rtrieu.

Sorry I'm not the right person to review this - adding some other potentials

I tested now, that it still works on i586 (in addition to x86_64)

bruno accepted this revision.Thu, Nov 29, 5:50 PM

Out of curiosity, why? If it makes you happy though, go for it! LGTM

This revision is now accepted and ready to land.Thu, Nov 29, 5:50 PM
rsmith accepted this revision.Thu, Nov 29, 6:11 PM

I'm assuming this is a patch from a time traveller who has come back from 11 years in the future seeking to prevent some disaster, after this test case somehow becomes part of some critical infrastructure. Definitely don't want to stand in the way of that!

As to the why: I'm working on reproducible builds for openSUSE and for that I verify that our packages can still give identical build results 15 years from now (which is the expected lifetime of today's enterprise software). kvm -rtc base option helps there.
Sometimes I even make it +20 years to find year-2038 bugs such as those in ninja and python, because it is better to fix them now rather than be surprised later and have a hard time with plenty busy work getting the fixes everywhere in time.

Now, it would be nice if someone could push this patch to the git repo.
I already got 200+ forks in my github home - most with just 1 small patch that eventually gets merged.