This is an archive of the discontinued LLVM Phabricator instance.

[clangd] Make binary index format the default, remove dead flag.
ClosedPublic

Authored by sammccall on Oct 4 2018, 3:19 AM.

Event Timeline

sammccall created this revision.Oct 4 2018, 3:19 AM
ilya-biryukov added inline comments.Oct 4 2018, 3:35 AM
clangd/indexer/IndexerMain.cpp
84

Maybe we should suggest a default extensions here? E.g. index.riff?

hokein added inline comments.Oct 4 2018, 3:54 AM
clangd/indexer/IndexerMain.cpp
58

If we remove the assume-header-dir, we probably remove FallbackDir too? I can't remember why we added this option, there is no usage internally either.

84

+1

sammccall added inline comments.Oct 4 2018, 3:55 AM
clangd/indexer/IndexerMain.cpp
84

I considered this but am not sure it's useful:

  • means an unneccesary change to workflows if we change the format (happened once!)
  • riff is associated with audio, and I'd expect OSes that care about extensions to draw the wrong conclusion :-)
sammccall marked an inline comment as done.Oct 4 2018, 7:13 AM
sammccall added inline comments.
clangd/indexer/IndexerMain.cpp
58

It's used in our internal mr_indexer

84

Settled on clangd.dex which is at least easy to understand and only kind of misleading.

sammccall updated this revision to Diff 168287.Oct 4 2018, 7:14 AM

example filename "clangd.dex"

hokein accepted this revision.Oct 5 2018, 1:17 AM

looks good.

This revision is now accepted and ready to land.Oct 5 2018, 1:17 AM
This revision was automatically updated to reflect the committed changes.