This is an archive of the discontinued LLVM Phabricator instance.

Update Clang Windows getting started docs
ClosedPublic

Authored by rnk on Oct 3 2018, 12:52 PM.

Details

Summary
  • Update the example VS project generation to use VS2017.
  • Add docs for generating ninja build files, since they are popular.
  • Remove reference to "make update" which no longer exists. Mention the monorepo instead.
  • Try to explain gnuwin32/coreutils requirements better.

Event Timeline

rnk created this revision.Oct 3 2018, 12:52 PM
smeenai added a subscriber: smeenai.Oct 3 2018, 2:09 PM
smeenai added inline comments.
clang/www/get_started.html
197

Does the Win64 generator automatically imply -Thost=x64?

steveire added inline comments.
clang/www/get_started.html
197

Nope.

And using "Visual Studio 15 2017 Win64" is deprecated. Use -G "Visual Studio 15 2017" -A x64 instead as per https://cmake.org/cmake/help/latest/generator/Visual%20Studio%2015%202017.html

STL_MSFT added inline comments.Oct 3 2018, 3:28 PM
clang/www/get_started.html
158–159

This URL redirects to https://cmake.org/download/. (Clang's docs should use HTTPS everywhere possible, especially for self-links.)

159–164

Redirected to https://www.python.org/downloads/.

179

Can these be HTTPS? (I had to figure out HTTPS incantations for git clone and git svn init, but I haven't used SVN directly.)

245

This assumes the Professional SKU; perhaps the instructions should be for Community?

zturner added inline comments.Oct 3 2018, 4:01 PM
clang/www/get_started.html
245

Would something like %VS2017INSTALLDIR% be even better?

245

Granted it assumes 2017, but not as bad as assuming both Professional SKU + default installation path.

rnk updated this revision to Diff 168205.Oct 3 2018, 4:34 PM
  • Use https: where possible over http:
  • Fix CMake VS generator invocation
rnk marked 3 inline comments as done.Oct 3 2018, 4:36 PM
rnk added inline comments.
clang/www/get_started.html
179

These can, but getgnuwin32 is http-only for now I guess. =/

197

Thanks, check the new instructions, hopefully they are correct.

245

I'll change it, and hopefully users of Professional will understand what "run the appropriate vcvarsall.bat incantation" means.

rnk marked an inline comment as done.Oct 4 2018, 1:35 PM

I'm going to go ahead and commit this. Hopefully it's more accurate and useful than what we have, and we can fix any issues in post.

This revision was not accepted when it landed; it landed in state Needs Review.Oct 4 2018, 1:36 PM
This revision was automatically updated to reflect the committed changes.