This is an archive of the discontinued LLVM Phabricator instance.

[WebAssembly] Saturating arithmetic intrinsics
ClosedPublic

Authored by tlively on Oct 2 2018, 4:30 PM.

Diff Detail

Event Timeline

tlively created this revision.Oct 2 2018, 4:30 PM
tlively updated this revision to Diff 168058.Oct 2 2018, 5:16 PM
  • Add newline for readability.
aheejin added inline comments.Oct 3 2018, 9:06 AM
lib/Target/WebAssembly/WebAssemblyISelLowering.cpp
993

Newline here? :3

tlively updated this revision to Diff 168134.Oct 3 2018, 10:39 AM
tlively marked an inline comment as done.
  • Another newline
tlively updated this revision to Diff 168166.Oct 3 2018, 1:50 PM
  • Rebase
aheejin added inline comments.Oct 3 2018, 2:40 PM
test/CodeGen/WebAssembly/simd-arith.ll
6

Do we need both the slow and fast versions for NO-SIMD128 too? Aren't they the same anyway?

tlively updated this revision to Diff 168197.Oct 3 2018, 4:13 PM
tlively marked an inline comment as done.
  • Remove unused FileCheck labels
aheejin added inline comments.Oct 3 2018, 5:32 PM
test/CodeGen/WebAssembly/simd-arith.ll
6

Oh what I meant is... do we need to test both with and without fastisel for NO-SIMD128? With NO-SIMD128 we are just testing the pre-existing scalar expansion behavior and checking the SIMD instructions do not kick in.

tlively added inline comments.Oct 4 2018, 2:29 PM
test/CodeGen/WebAssembly/simd-arith.ll
6

Sounds like fast isel is responsible for complying with architecture features itself, so we still need this test.

aheejin accepted this revision.Oct 4 2018, 4:25 PM
This revision is now accepted and ready to land.Oct 4 2018, 4:25 PM
This revision was automatically updated to reflect the committed changes.