Depends on D52765.
Details
Details
Diff Detail
Diff Detail
- Repository
- rL LLVM
- Build Status
Buildable 23343 Build 23342: arc lint + arc unit
Event Timeline
Comment Actions
No, I haven't been able to find any existing tests or an obvious place to add new ones for DAG combining. I guess the fact that all the backends still work is something.
Comment Actions
So this change is not necessarily related to minimum/maximum new intrinsics, because they are pre-existing. So this means FMINNAN/FMAXNAN nodes have not been optimized in DAG combiner so far. Strange. Anyway apparently what this does is constant folding on DAG nodes, so I think we can come up with a test?
lib/CodeGen/SelectionDAG/DAGCombiner.cpp | ||
---|---|---|
12110 | Is this line clang-formatted? |
test/CodeGen/WebAssembly/simd-arith.ll | ||
---|---|---|
827 ↗ | (On Diff #170502) | These transpositions show the canonicalization working. |
Is this line clang-formatted?