This is an archive of the discontinued LLVM Phabricator instance.

[WebAssembly] any_true and all_true intrinsics and instructions
ClosedPublic

Authored by tlively on Oct 1 2018, 4:08 PM.

Diff Detail

Event Timeline

tlively created this revision.Oct 1 2018, 4:08 PM
tlively updated this revision to Diff 168031.Oct 2 2018, 2:25 PM
  • Remove unused FileCheck lines
aheejin accepted this revision.Oct 2 2018, 4:57 PM
aheejin added inline comments.
lib/Target/WebAssembly/WebAssemblyISelLowering.cpp
961

Nit: maybe a newline here for readability?

This revision is now accepted and ready to land.Oct 2 2018, 4:57 PM

Is there any reason why intrinsic names don't have underscores like anytrue but instruction names do, like any_true?

Is there any reason why intrinsic names don't have underscores like anytrue but instruction names do, like any_true?

Underscores in intrinsic tablegen names are turned into dots at the IR level. I liked anytrue better than any.true.

tlively marked an inline comment as done.Oct 2 2018, 5:17 PM
tlively added inline comments.
lib/Target/WebAssembly/WebAssemblyISelLowering.cpp
961

Done in D52813 to avoid annoying rebases.

This revision was automatically updated to reflect the committed changes.
tlively marked an inline comment as done.
aheejin added inline comments.Oct 3 2018, 9:05 AM
llvm/trunk/lib/Target/WebAssembly/WebAssemblyInstrSIMD.td
200 ↗(On Diff #168060)

Sorry, but the indentation looks like it should have one more whitespace here