Details
- Reviewers
alexfh aaron.ballman hokein - Commits
- rG28a4c0ff3b46: [clang-tidy] NFC use CHECK-NOTES in tests for performance-move-constructor-init
rCTE343791: [clang-tidy] NFC use CHECK-NOTES in tests for performance-move-constructor-init
rL343791: [clang-tidy] NFC use CHECK-NOTES in tests for performance-move-constructor-init
Diff Detail
- Repository
- rCTE Clang Tools Extra
Event Timeline
test/clang-tidy/performance-move-constructor-init.cpp | ||
---|---|---|
115–117 | This is an example of not very useful CHECK-NOTES patterns. The corresponding notes are issued in Clang and there's not much value in testing them here. They also duplicate the CHECK-FIXES pattern below. Should the script filter these notes out, maybe? |
test/clang-tidy/performance-move-constructor-init.cpp | ||
---|---|---|
115–117 | I agree that they dont add any value. |
check_clang_tidy now ignores note: FIX-IT, so only diagnostics directly emitted from the check are tested
test/clang-tidy/check_clang_tidy.py | ||
---|---|---|
174 | SGTM, if it works. |
-note remove spurious reordering
test/clang-tidy/check_clang_tidy.py | ||
---|---|---|
174 | Unfortunatly didnt work with LLVM regex, doing in python now |
SGTM, if it works.