[analyzer] scan-build: if --status-bugs is passed, don't forget about the exit status of the actual build

[lebedev.ri]

Summary

This has been bothering me for a while, but only now i have actually looked into this.
I'm using one CI job for static analysis - clang static analyzers as compilers + clang-tidy via cmake.
And i'd like for the build to fail if at least one of those finds issues.
If clang-tidy finds issues, it will fail the build since the warnings-as-errors is set.
If static analyzer finds anything, since --status-bugs is set, it will fail the build.
But if clang-tidy find anything, but static analyzer does not, the build succeeds :/

[lebedev.ri]

Updated the --help, too.

[jroelofs]

LGTM

[lebedev.ri]

In D52530#1246459, @jroelofs wrote:

LGTM

Thank you for the speedy review!

[george.karpenkov]

@jroelofs Thanks, but in general code owners would need to take a look as well.
@lebedev.ri The code looks great, thanks!

tools/scan-build/bin/scan-build

-plist-html
 
    By default the output of scan-build is a set of HTML files. This option
    outputs the results as a set of HTML and .plist files.
 
  --status-bugs
 
    By default, the exit status of scan-build is the same as the executed build
    command. Specifying this option causes the exit status of scan-build to be 1
-   if it found potential bugs and 0 otherwise.
+   if it found potential bugs and the exit status of the build itself otherwise.
 
  --exclude <path>
 
    Do not run static analyzer against files found in this
    directory (You can specify this option multiple times).
    Could be useful when project contains 3rd party libraries.
 
  --use-cc [compiler path]
if ($Options{ViewResults} and -r "$Options{OutputDir}/index.html") {
       my $ScanView = Cwd::realpath("$RealBin/scan-view");
       if (! -x $ScanView) { $ScanView = "scan-view"; }
       if (! -x $ScanView) { $ScanView = Cwd::realpath("$RealBin/../../scan-view/bin/scan-view"); }
       exec $ScanView, "$Options{OutputDir}";
     }
 
     if ($Options{ExitStatusFoundBugs}) {
       exit 1 if ($NumBugs > 0);
-      exit 0;
+      exit $ExitStatus;
     }
   }
 }
 
 exit $ExitStatus;