This is an archive of the discontinued LLVM Phabricator instance.

[AArch64][AsmParser] Show name of missing feature for system instructions
ClosedPublic

Authored by olista01 on Sep 25 2018, 7:17 AM.

Details

Summary

Parsing of the system instructions (IC, DC, AT and TLBI) uses this
function to show the required architecture when the operand is valid,
but the architecture is not enabled. Armv8.5A adds a few different
system instructions as part of optional features, so we need to extend
it to show individual features, not just base architectures.

This is NFC for now, but will be used by three different features added
in v8.5A, and will be tested by them.

Patch by David Spickett!

Diff Detail

Repository
rL LLVM

Event Timeline

olista01 created this revision.Sep 25 2018, 7:17 AM
SjoerdMeijer accepted this revision.Sep 25 2018, 9:25 AM

Looks okay to me.

lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp
2781 ↗(On Diff #166895)

Coding style nit, should this be: Extension &e?

This revision is now accepted and ready to land.Sep 25 2018, 9:25 AM
This revision was automatically updated to reflect the committed changes.