Make sure JSONRPCDispatcher outlives the worker threads, they access
its fields to remove the stored cancellations when Context dies.
Details
Details
Diff Detail
Diff Detail
- Repository
- rL LLVM
Paths
| Differential D52420
[clangd] Fix crash if pending computations were active on exit ClosedPublic Authored by ilya-biryukov on Sep 24 2018, 7:39 AM.
Details Summary Make sure JSONRPCDispatcher outlives the worker threads, they access
Diff Detail
Event TimelineHerald added subscribers: kadircet, arphaman, jkorous, MaskRay. · View Herald TranscriptSep 24 2018, 7:39 AM
This revision is now accepted and ready to land.Sep 25 2018, 3:07 AM Closed by commit rL343067: [clangd] Fix crash if pending computations were active on exit (authored by ibiryukov). · Explain WhySep 25 2018, 10:50 PM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 167046 clang-tools-extra/trunk/clangd/ClangdLSPServer.h
clang-tools-extra/trunk/clangd/ClangdLSPServer.cpp
|