This is an archive of the discontinued LLVM Phabricator instance.

Differential D52368

[libc++abi] is_strcmp parameter to is_equal is unused for WIN32
ClosedPublic

Authored by pirama on Sep 21 2018, 10:31 AM.

Details

Reviewers
EricWF
srhines
mstorsjo
mclow.lists
Commits
rG546de6100083: [libc++abi] is_strcmp parameter to is_equal is unused for WIN32
rCXXA342764: [libc++abi] is_strcmp parameter to is_equal is unused for WIN32
rL342764: [libc++abi] is_strcmp parameter to is_equal is unused for WIN32
Summary

Mark it as unused to avoid -Wunused-parameter.

Diff Detail

Event Timeline

pirama created this revision.Sep 21 2018, 10:31 AM
Herald added subscribers: libcxx-commits, ldionne, christof. · View Herald TranscriptSep 21 2018, 10:31 AM
Harbormaster completed remote builds in B22933: Diff 166502.Sep 21 2018, 10:31 AM
mclow.lists added a subscriber: mclow.lists.Sep 21 2018, 11:08 AM

This seems like overkill to me; why not add (void) use_strcmp right before line 67 instead?

pirama updated this revision to Diff 166527.Sep 21 2018, 11:55 AM

Simplify patch.

Harbormaster completed remote builds in B22937: Diff 166527.Sep 21 2018, 11:55 AM
mclow.lists accepted this revision.Sep 21 2018, 12:14 PM

LGTM.

This revision is now accepted and ready to land.Sep 21 2018, 12:14 PM
Closed by commit rL342764: [libc++abi] is_strcmp parameter to is_equal is unused for WIN32 (authored by pirama). · Explain WhySep 21 2018, 1:02 PM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: llvm-commits. · View Herald TranscriptSep 21 2018, 1:02 PM

Revision Contents

PathSize
src/
1 line

Diff 166527

src/private_typeinfo.cpp

Show First 20 Lines • Show All 58 Lines • ▼ Show 20 Lines
bool bool
is_equal(const std::type_info* x, const std::type_info* y, bool use_strcmp) is_equal(const std::type_info* x, const std::type_info* y, bool use_strcmp)
{ {
#ifndef _WIN32 #ifndef _WIN32
if (!use_strcmp) if (!use_strcmp)
return x == y; return x == y;
return strcmp(x->name(), y->name()) == 0; return strcmp(x->name(), y->name()) == 0;
#else #else
(void) use_strcmp;
return (x == y) || (strcmp(x->name(), y->name()) == 0); return (x == y) || (strcmp(x->name(), y->name()) == 0);
#endif #endif
} }
namespace __cxxabiv1 namespace __cxxabiv1
{ {
// __shim_type_info // __shim_type_info
▲ Show 20 Lines • Show All 1,225 Lines • Show Last 20 Lines