This is an archive of the discontinued LLVM Phabricator instance.

Paths

[libc++abi] is_strcmp parameter to is_equal is unused for WIN32
ClosedPublic

Authored by pirama on Sep 21 2018, 10:31 AM.

Reviewers

Commits

Summary

Mark it as unused to avoid -Wunused-parameter.

This seems like overkill to me; why not add (void) use_strcmp right before line 67 instead?

Simplify patch.

LGTM.

This revision is now accepted and ready to land.Sep 21 2018, 12:14 PM

This revision was automatically updated to reflect the committed changes.

Path

Size

libcxxabi/

trunk/

src/

1 line

	Show First 20 Lines • Show All 58 Lines • ▼ Show 20 Lines
	bool			bool
	is_equal(const std::type_info* x, const std::type_info* y, bool use_strcmp)			is_equal(const std::type_info* x, const std::type_info* y, bool use_strcmp)
	{			{
	#ifndef _WIN32			#ifndef _WIN32
	if (!use_strcmp)			if (!use_strcmp)
	return x == y;			return x == y;
	return strcmp(x->name(), y->name()) == 0;			return strcmp(x->name(), y->name()) == 0;
	#else			#else
				(void) use_strcmp;
	return (x == y) \|\| (strcmp(x->name(), y->name()) == 0);			return (x == y) \|\| (strcmp(x->name(), y->name()) == 0);
	#endif			#endif
	}			}

	namespace __cxxabiv1			namespace __cxxabiv1
	{			{

	// __shim_type_info			// __shim_type_info
	▲ Show 20 Lines • Show All 1,225 Lines • Show Last 20 Lines